cleveragents/cleveragents-core

Fork 3

UAT: TDD features for open bugs (#989, #993, #1039) are @skip instead of @tdd_expected_fail — CI not capturing these known bugs #5692

New issue

Open

opened 2026-04-09 08:37:54 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-09 08:37:54 +00:00

Owner

Background and Context

CONTRIBUTING.md states under Bug Fix Workflow:

TDD issue-capture tests use the @tdd_expected_fail tag to pass CI while the bug is unfixed. These are not "unaddressed" failures; they are tracked and resolved through the TDD workflow.

Three feature files for open bugs are tagged @skip at the feature level instead of having active @tdd_expected_fail tags. This means CI is not capturing these known bugs — the tests are simply not running at all.

Current Behavior

Feature File	Referenced Issue	Issue State	Current Tag
`tdd_json_decode_crash_persistence.feature`	#989	open	`@skip`
`tdd_server_connect_atomic_writes.feature`	#993	open	`@skip`
`tdd_missing_validation_unit_tests_yaml.feature`	#1039	open	`@skip`

All three features have @skip at the feature level, meaning:

The bug-capturing tests are NOT running
CI is not verifying these bugs still exist
If someone accidentally "fixes" one of these bugs without proper process, CI won't detect it
The TDD workflow is broken for these issues

The correct behavior per CONTRIBUTING.md is:

Active @tdd_expected_fail tag → test runs, fails (proving bug exists), CI reports as passed
@skip → test doesn't run at all, CI has no information about the bug

Expected Behavior

For open bugs with TDD tests:

The @skip tag should be removed
The @tdd_expected_fail tag should be active (not commented out)
The scenarios should run and fail (proving the bug exists)
CI should report them as passed (via the inversion mechanism)

Acceptance Criteria

tdd_json_decode_crash_persistence.feature: @skip removed, @tdd_expected_fail active
tdd_server_connect_atomic_writes.feature: @skip removed, @tdd_expected_fail active
tdd_missing_validation_unit_tests_yaml.feature: @skip removed, @tdd_expected_fail active
All three features run in CI and are reported as passed (via inversion)

Supporting Information

From tdd_json_decode_crash_persistence.feature:

# @tdd_issue @tdd_issue_989 @tdd_expected_fail @skip
@skip
Feature: TDD Bug #989 — automation profile persistence crashes on corrupt JSON

From tdd_server_connect_atomic_writes.feature:

# @tdd_expected_fail @tdd_issue @tdd_issue_993
@skip
Feature: TDD Issue #993 — server_connect writes three config values non-atomically

From tdd_missing_validation_unit_tests_yaml.feature:

# @tdd_expected_fail @tdd_issue @tdd_issue_1039
@skip
Feature: TDD Bug #1039 — Missing validations/unit-tests.yaml configuration

Metadata

Commit Message: fix(tests): restore @tdd_expected_fail for open bugs #989 #993 #1039 — remove @skip
Branch: fix/restore-tdd-expected-fail-open-bugs

Subtasks

Remove @skip from tdd_json_decode_crash_persistence.feature, add active @tdd_expected_fail
Remove @skip from tdd_server_connect_atomic_writes.feature, add active @tdd_expected_fail
Remove @skip from tdd_missing_validation_unit_tests_yaml.feature, add active @tdd_expected_fail
Verify all three features run and are reported as passed by CI

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created with the prescribed commit message.
The commit is pushed to the branch and submitted as a pull request to master, reviewed, and merged.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Background and Context CONTRIBUTING.md states under **Bug Fix Workflow**: > TDD issue-capture tests use the `@tdd_expected_fail` tag to pass CI while the bug is unfixed. These are not "unaddressed" failures; they are tracked and resolved through the TDD workflow. Three feature files for **open** bugs are tagged `@skip` at the feature level instead of having active `@tdd_expected_fail` tags. This means CI is not capturing these known bugs — the tests are simply not running at all. ## Current Behavior | Feature File | Referenced Issue | Issue State | Current Tag | |---|---|---|---| | `tdd_json_decode_crash_persistence.feature` | #989 | **open** | `@skip` | | `tdd_server_connect_atomic_writes.feature` | #993 | **open** | `@skip` | | `tdd_missing_validation_unit_tests_yaml.feature` | #1039 | **open** | `@skip` | All three features have `@skip` at the feature level, meaning: 1. The bug-capturing tests are NOT running 2. CI is not verifying these bugs still exist 3. If someone accidentally "fixes" one of these bugs without proper process, CI won't detect it 4. The TDD workflow is broken for these issues The correct behavior per CONTRIBUTING.md is: - Active `@tdd_expected_fail` tag → test runs, fails (proving bug exists), CI reports as passed - `@skip` → test doesn't run at all, CI has no information about the bug ## Expected Behavior For open bugs with TDD tests: 1. The `@skip` tag should be removed 2. The `@tdd_expected_fail` tag should be active (not commented out) 3. The scenarios should run and fail (proving the bug exists) 4. CI should report them as passed (via the inversion mechanism) ## Acceptance Criteria - [ ] `tdd_json_decode_crash_persistence.feature`: `@skip` removed, `@tdd_expected_fail` active - [ ] `tdd_server_connect_atomic_writes.feature`: `@skip` removed, `@tdd_expected_fail` active - [ ] `tdd_missing_validation_unit_tests_yaml.feature`: `@skip` removed, `@tdd_expected_fail` active - [ ] All three features run in CI and are reported as passed (via inversion) ## Supporting Information From `tdd_json_decode_crash_persistence.feature`: ``` # @tdd_issue @tdd_issue_989 @tdd_expected_fail @skip @skip Feature: TDD Bug #989 — automation profile persistence crashes on corrupt JSON ``` From `tdd_server_connect_atomic_writes.feature`: ``` # @tdd_expected_fail @tdd_issue @tdd_issue_993 @skip Feature: TDD Issue #993 — server_connect writes three config values non-atomically ``` From `tdd_missing_validation_unit_tests_yaml.feature`: ``` # @tdd_expected_fail @tdd_issue @tdd_issue_1039 @skip Feature: TDD Bug #1039 — Missing validations/unit-tests.yaml configuration ``` ## Metadata - **Commit Message**: `fix(tests): restore @tdd_expected_fail for open bugs #989 #993 #1039 — remove @skip` - **Branch**: `fix/restore-tdd-expected-fail-open-bugs` ## Subtasks - [ ] Remove `@skip` from `tdd_json_decode_crash_persistence.feature`, add active `@tdd_expected_fail` - [ ] Remove `@skip` from `tdd_server_connect_atomic_writes.feature`, add active `@tdd_expected_fail` - [ ] Remove `@skip` from `tdd_missing_validation_unit_tests_yaml.feature`, add active `@tdd_expected_fail` - [ ] Verify all three features run and are reported as passed by CI ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created with the prescribed commit message. - The commit is pushed to the branch and submitted as a pull request to `master`, reviewed, and merged. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added the

labels

2026-04-09 08:38:58 +00:00

HAL9000 added this to the v3.2.0 milestone

2026-04-09 08:46:46 +00:00

HAL9000 commented

2026-04-09 08:49:04 +00:00

Author

Owner

Label compliance fix applied:

Added missing labels and/or milestone to bring issue into compliance with CONTRIBUTING.md

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: backlog-groomer

Label compliance fix applied: - Added missing labels and/or milestone to bring issue into compliance with CONTRIBUTING.md --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: backlog-groomer

HAL9000 referenced this issue

2026-04-09 09:03:59 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 10) #5748

HAL9000 added a new dependency

2026-04-09 09:04:51 +00:00

#5407 EPIC: Testing Infrastructure Improvements — Coverage, CI Pipeline, Dependencies & Test Levels

HAL9000 referenced this issue

2026-04-09 09:13:58 +00:00

[AUTO-EPIC] Epic Planning Health Report (Cycle 11) #5298

HAL9000 referenced this issue

2026-04-09 09:36:39 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 10) #5748