cleveragents/cleveragents-core

Fork 3

UAT: noxfile.py COVERAGE_THRESHOLD comment misleadingly says "Temporarily lowered" but threshold is 97% — comment is stale and confusing #5652

New issue

Open

opened 2026-04-09 08:08:03 +00:00 by HAL9000 · 2 comments

HAL9000 commented

2026-04-09 08:08:03 +00:00

Owner

Background and Context

The noxfile.py contains a misleading comment about the coverage threshold:

COVERAGE_THRESHOLD = 97  # Temporarily lowered due to many @tdd_expected_fail tests
# see issues #4183 and #4184

This comment is confusing because:

The threshold IS 97% — it was not lowered from a higher value
The comment implies the threshold should be higher than 97%, but CONTRIBUTING.md specifies 97% as the minimum
Issues #4183 and #4184 may no longer be relevant

Current Behavior

noxfile.py line 510:

COVERAGE_THRESHOLD = 97  # Temporarily lowered due to many @tdd_expected_fail tests
# see issues #4183 and #4184

The comment implies:

The threshold was "temporarily lowered" from some higher value
This is due to @tdd_expected_fail tests reducing coverage
Issues #4183 and #4184 are tracking this

However, CONTRIBUTING.md states: "The general minimum is 97%." — 97% is the standard minimum, not a lowered value.

Expected Behavior

The comment should accurately reflect the current state:

If 97% is the correct threshold per CONTRIBUTING.md, the comment should be removed or updated
If the threshold was genuinely lowered from a higher value, the comment should reference the original threshold and a clear timeline for restoration

Acceptance Criteria

The misleading comment is removed or updated to accurately reflect the threshold policy
Issues #4183 and #4184 are checked — if resolved, the comment reference is removed

Supporting Information

noxfile.py line 510: COVERAGE_THRESHOLD = 97 # Temporarily lowered due to many @tdd_expected_fail tests
CONTRIBUTING.md: "The general minimum is 97%"
The htmlcov/index.html (dated 2025-11-22) shows 84.42% coverage — this is a stale report from a partial coverage run (only covers a subset of modules)

Metadata

Commit Message: chore(nox): remove stale coverage threshold comment — 97% is the standard minimum
Branch: chore/fix-coverage-threshold-comment

Subtasks

Check issues #4183 and #4184 status
Remove or update the misleading comment in noxfile.py
Verify coverage threshold is correctly enforced at 97%

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created with the prescribed commit message.
The commit is pushed to the branch and submitted as a pull request to master, reviewed, and merged.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Background and Context The `noxfile.py` contains a misleading comment about the coverage threshold: ```python COVERAGE_THRESHOLD = 97 # Temporarily lowered due to many @tdd_expected_fail tests # see issues #4183 and #4184 ``` This comment is confusing because: 1. The threshold IS 97% — it was not lowered from a higher value 2. The comment implies the threshold should be higher than 97%, but CONTRIBUTING.md specifies 97% as the minimum 3. Issues #4183 and #4184 may no longer be relevant ## Current Behavior `noxfile.py` line 510: ```python COVERAGE_THRESHOLD = 97 # Temporarily lowered due to many @tdd_expected_fail tests # see issues #4183 and #4184 ``` The comment implies: - The threshold was "temporarily lowered" from some higher value - This is due to `@tdd_expected_fail` tests reducing coverage - Issues #4183 and #4184 are tracking this However, CONTRIBUTING.md states: "The general minimum is **97%**." — 97% is the standard minimum, not a lowered value. ## Expected Behavior The comment should accurately reflect the current state: - If 97% is the correct threshold per CONTRIBUTING.md, the comment should be removed or updated - If the threshold was genuinely lowered from a higher value, the comment should reference the original threshold and a clear timeline for restoration ## Acceptance Criteria - [ ] The misleading comment is removed or updated to accurately reflect the threshold policy - [ ] Issues #4183 and #4184 are checked — if resolved, the comment reference is removed ## Supporting Information - `noxfile.py` line 510: `COVERAGE_THRESHOLD = 97 # Temporarily lowered due to many @tdd_expected_fail tests` - CONTRIBUTING.md: "The general minimum is **97%**" - The `htmlcov/index.html` (dated 2025-11-22) shows 84.42% coverage — this is a stale report from a partial coverage run (only covers a subset of modules) ## Metadata - **Commit Message**: `chore(nox): remove stale coverage threshold comment — 97% is the standard minimum` - **Branch**: `chore/fix-coverage-threshold-comment` ## Subtasks - [ ] Check issues #4183 and #4184 status - [ ] Remove or update the misleading comment in `noxfile.py` - [ ] Verify coverage threshold is correctly enforced at 97% ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created with the prescribed commit message. - The commit is pushed to the branch and submitted as a pull request to `master`, reviewed, and merged. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added the

labels

2026-04-09 08:08:22 +00:00

HAL9000 added this to the v3.2.0 milestone

2026-04-09 08:16:15 +00:00

HAL9000 commented

2026-04-09 08:17:45 +00:00

Author

Owner

Label compliance fix applied:

Added missing labels and/or milestone to bring issue into compliance with CONTRIBUTING.md

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: backlog-groomer

Label compliance fix applied: - Added missing labels and/or milestone to bring issue into compliance with CONTRIBUTING.md --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: backlog-groomer

HAL9000 commented

2026-04-09 08:18:23 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Backlog — Stale comment in noxfile.py is a documentation/code quality issue. The misleading "Temporarily lowered" comment could confuse developers about the coverage policy.
Milestone: None (backlog — trivial cleanup)
Story Points: 1 — XS — Removing/updating a comment in noxfile.py, <1 hour.
MoSCoW: MoSCoW/Could have — This is a nice-to-have cleanup. The comment is misleading but doesn't affect functionality. Low priority.
Parent Epic: #5406 (Testing Infrastructure & Quality Hardening Legendary)

Valid but low-priority cleanup. The 97% threshold is correct per CONTRIBUTING.md. The "Temporarily lowered" comment is stale and should be removed.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Backlog — Stale comment in noxfile.py is a documentation/code quality issue. The misleading "Temporarily lowered" comment could confuse developers about the coverage policy. - **Milestone**: None (backlog — trivial cleanup) - **Story Points**: 1 — XS — Removing/updating a comment in noxfile.py, <1 hour. - **MoSCoW**: MoSCoW/Could have — This is a nice-to-have cleanup. The comment is misleading but doesn't affect functionality. Low priority. - **Parent Epic**: #5406 (Testing Infrastructure & Quality Hardening Legendary) Valid but low-priority cleanup. The 97% threshold is correct per CONTRIBUTING.md. The "Temporarily lowered" comment is stale and should be removed. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 added

and removed

labels

2026-04-09 08:19:23 +00:00

HAL9000 added a new dependency