UAT: plan_diff_artifacts.robot test file is missing — helper script exists but Robot test suite was never created #5551

Open
opened 2026-04-09 07:23:36 +00:00 by HAL9000 · 0 comments
Owner

Bug Report

Feature Area: Integration test coverage for the complete workflow (plan use → execute → diff → apply)

Severity: Critical — the plan diff integration tests cannot run because the Robot Framework test file is absent


What Was Tested

Analyzed the robot/ directory for plan diff integration test coverage.

Expected Behavior (from spec)

The v3.6.0 milestone requires integration test coverage for the complete workflow including plan diff. The robot/ directory should contain a plan_diff_artifacts.robot file that exercises the plan diff functionality using the helper script.

Actual Behavior

The robot/ directory contains:

  • robot/helper_plan_diff_artifacts.py — A complete helper script with 8 test commands:

    • diff-output — Tests diff output in rich format
    • artifacts-output — Tests artifacts summary rendering
    • empty-guard — Tests empty changeset guard
    • empty-guard-allow — Tests empty changeset allow
    • apply-summary — Tests apply summary persistence
    • merge-failure — Tests merge failure handling
    • diff-json — Tests diff JSON format
    • diff-yaml — Tests diff YAML format
  • robot/plan_diff_artifacts.robotDOES NOT EXIST

The helper script is fully implemented and ready to use, but the Robot Framework test file that would invoke it was never created. This means the plan diff integration tests are completely absent from the test suite.

Steps to Reproduce

ls robot/ | grep diff
# Output:
# diff_review.robot
# helper_diff_review.py
# helper_plan_diff_artifacts.py
# (no plan_diff_artifacts.robot)

Code Location

  • robot/helper_plan_diff_artifacts.py — exists and is complete
  • robot/plan_diff_artifacts.robotMISSING

Impact

  • The nox -e integration_tests session does not run any plan diff tests
  • The 8 test scenarios in helper_plan_diff_artifacts.py are never executed
  • Plan diff correctness (format, empty guard, merge failure handling) is untested
  • The v3.6.0 integration test coverage requirement for the complete workflow is not met

Suggested Fix

Create robot/plan_diff_artifacts.robot following the pattern of other robot test files:

*** Settings ***
Documentation    Integration tests for plan diff and artifacts
Resource         ${CURDIR}/common.resource
Suite Setup      Setup Test Environment
Suite Teardown   Cleanup Test Environment

*** Variables ***
${HELPER}    ${CURDIR}/helper_plan_diff_artifacts.py

*** Test Cases ***
Diff Output Rich Format
    [Documentation]    Verify plan diff produces rich output with changeset entries
    ${result}=    Run Process    ${PYTHON}    ${HELPER}    diff-output    cwd=${WORKSPACE}
    Should Be Equal As Integers    ${result.rc}    0
    Should Contain    ${result.stdout}    diff-output-ok

Build Artifacts Summary
    [Documentation]    Verify artifacts summary rendering
    ${result}=    Run Process    ${PYTHON}    ${HELPER}    artifacts-output    cwd=${WORKSPACE}
    Should Be Equal As Integers    ${result.rc}    0
    Should Contain    ${result.stdout}    artifacts-output-ok

# ... (remaining 6 test cases)

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area**: Integration test coverage for the complete workflow (plan use → execute → diff → apply) **Severity**: Critical — the plan diff integration tests cannot run because the Robot Framework test file is absent --- ## What Was Tested Analyzed the `robot/` directory for plan diff integration test coverage. ## Expected Behavior (from spec) The v3.6.0 milestone requires integration test coverage for the complete workflow including `plan diff`. The `robot/` directory should contain a `plan_diff_artifacts.robot` file that exercises the plan diff functionality using the helper script. ## Actual Behavior The `robot/` directory contains: - ✅ `robot/helper_plan_diff_artifacts.py` — A complete helper script with 8 test commands: - `diff-output` — Tests diff output in rich format - `artifacts-output` — Tests artifacts summary rendering - `empty-guard` — Tests empty changeset guard - `empty-guard-allow` — Tests empty changeset allow - `apply-summary` — Tests apply summary persistence - `merge-failure` — Tests merge failure handling - `diff-json` — Tests diff JSON format - `diff-yaml` — Tests diff YAML format - ❌ `robot/plan_diff_artifacts.robot` — **DOES NOT EXIST** The helper script is fully implemented and ready to use, but the Robot Framework test file that would invoke it was never created. This means the plan diff integration tests are completely absent from the test suite. ## Steps to Reproduce ```bash ls robot/ | grep diff # Output: # diff_review.robot # helper_diff_review.py # helper_plan_diff_artifacts.py # (no plan_diff_artifacts.robot) ``` ## Code Location - `robot/helper_plan_diff_artifacts.py` — exists and is complete - `robot/plan_diff_artifacts.robot` — **MISSING** ## Impact - The `nox -e integration_tests` session does not run any plan diff tests - The 8 test scenarios in `helper_plan_diff_artifacts.py` are never executed - Plan diff correctness (format, empty guard, merge failure handling) is untested - The v3.6.0 integration test coverage requirement for the complete workflow is not met ## Suggested Fix Create `robot/plan_diff_artifacts.robot` following the pattern of other robot test files: ```robot *** Settings *** Documentation Integration tests for plan diff and artifacts Resource ${CURDIR}/common.resource Suite Setup Setup Test Environment Suite Teardown Cleanup Test Environment *** Variables *** ${HELPER} ${CURDIR}/helper_plan_diff_artifacts.py *** Test Cases *** Diff Output Rich Format [Documentation] Verify plan diff produces rich output with changeset entries ${result}= Run Process ${PYTHON} ${HELPER} diff-output cwd=${WORKSPACE} Should Be Equal As Integers ${result.rc} 0 Should Contain ${result.stdout} diff-output-ok Build Artifacts Summary [Documentation] Verify artifacts summary rendering ${result}= Run Process ${PYTHON} ${HELPER} artifacts-output cwd=${WORKSPACE} Should Be Equal As Integers ${result.rc} 0 Should Contain ${result.stdout} artifacts-output-ok # ... (remaining 6 test cases) ``` --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester
HAL9000 added this to the v3.6.0 milestone 2026-04-09 07:26:52 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
cleveragents/cleveragents-core#5551
No description provided.