cleveragents/cleveragents-core

Fork 3

UAT: `CorrectionService.execute_revert()` does not supersede affected decisions in the database — decision tree not updated after correction #5103

New issue

Open

opened 2026-04-09 01:02:08 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-09 01:02:08 +00:00

Owner

Bug Report

Feature Area: Sandbox and Checkpoint / Correction Model
Tested By: UAT worker (uat-pool-1), feature area: Sandbox and Checkpoint
Severity: High (correction revert does not update decision tree — affected decisions remain active)

What Was Tested

The CorrectionService.execute_revert() method was analyzed to verify it supersedes affected decisions in the decision tree as defined in the specification (§Mid-Execute Correction, lines 28836 and §Mid-Strategize Correction, line 28804).

Expected Behavior (from spec)

The spec defines (§Mid-Strategize Correction, line 28804):

Supersede affected subtree: Mark the target decision and all its descendants as superseded (cascading via ADR-034). Decisions above the target remain active and unchanged.

And (§Mid-Execute Correction, line 28836):

Supersede affected subtree: Cascade superseding through the target and all descendants.

The DecisionService.mark_superseded() method exists in src/cleveragents/application/services/decision_service.py (line 644) and is designed for exactly this purpose.

Actual Behavior (from code)

The CorrectionService.execute_revert() in src/cleveragents/application/services/correction_service.py (lines 468–555):

✓ Computes impact.affected_decisions (BFS traversal of decision tree)
✓ Restores checkpoint
✓ Extracts actor_state_ref
✓ Creates user_intervention decision ID
❌ Does NOT call DecisionService.mark_superseded() for any affected decision
❌ Does NOT update the database — affected decisions remain with is_superseded=False

The CorrectionService has no reference to DecisionService at all — it cannot supersede decisions even if it wanted to.

class CorrectionService:
    def __init__(
        self,
        checkpoint_service: CheckpointService | None = None,
        event_bus: EventBus | None = None,
    ) -> None:
        # ❌ No DecisionService injected
        self._checkpoint_service = checkpoint_service
        self._event_bus = event_bus

Code Location

src/cleveragents/application/services/correction_service.py, execute_revert() method (lines 468–555)
src/cleveragents/application/services/correction_service.py, __init__() method — missing DecisionService injection

Steps to Reproduce

Create and execute a plan to generate several decisions
Run agents plan correct <DECISION_ID> --mode revert --guidance "..." --yes
Run agents plan tree <PLAN_ID> to view the decision tree
Expected: Affected decisions show as superseded (is_superseded=True)
Actual: All decisions remain active (is_superseded=False)

Verification

agents plan tree <PLAN_ID>  # All decisions still show as active
agents plan tree --show-superseded <PLAN_ID>  # No superseded decisions shown

Impact

Data integrity: The decision tree is not updated after correction — affected decisions remain active
Spec violation: The spec's "Supersede affected subtree" step is not implemented
Downstream effects:
- agents plan tree shows stale decisions as active
- agents plan diff --correction cannot compare old vs new decisions
- Re-execution will encounter stale decisions that conflict with new ones

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area**: Sandbox and Checkpoint / Correction Model **Tested By**: UAT worker (uat-pool-1), feature area: Sandbox and Checkpoint **Severity**: High (correction revert does not update decision tree — affected decisions remain active) --- ## What Was Tested The `CorrectionService.execute_revert()` method was analyzed to verify it supersedes affected decisions in the decision tree as defined in the specification (§Mid-Execute Correction, lines 28836 and §Mid-Strategize Correction, line 28804). ## Expected Behavior (from spec) The spec defines (§Mid-Strategize Correction, line 28804): > **Supersede affected subtree**: Mark the target decision and all its descendants as superseded (cascading via ADR-034). Decisions above the target remain active and unchanged. And (§Mid-Execute Correction, line 28836): > **Supersede affected subtree**: Cascade superseding through the target and all descendants. The `DecisionService.mark_superseded()` method exists in `src/cleveragents/application/services/decision_service.py` (line 644) and is designed for exactly this purpose. ## Actual Behavior (from code) The `CorrectionService.execute_revert()` in `src/cleveragents/application/services/correction_service.py` (lines 468–555): 1. ✓ Computes `impact.affected_decisions` (BFS traversal of decision tree) 2. ✓ Restores checkpoint 3. ✓ Extracts `actor_state_ref` 4. ✓ Creates `user_intervention` decision ID 5. ❌ **Does NOT call `DecisionService.mark_superseded()`** for any affected decision 6. ❌ **Does NOT update the database** — affected decisions remain with `is_superseded=False` The `CorrectionService` has no reference to `DecisionService` at all — it cannot supersede decisions even if it wanted to. ```python class CorrectionService: def __init__( self, checkpoint_service: CheckpointService | None = None, event_bus: EventBus | None = None, ) -> None: # ❌ No DecisionService injected self._checkpoint_service = checkpoint_service self._event_bus = event_bus ``` ## Code Location - `src/cleveragents/application/services/correction_service.py`, `execute_revert()` method (lines 468–555) - `src/cleveragents/application/services/correction_service.py`, `__init__()` method — missing `DecisionService` injection ## Steps to Reproduce 1. Create and execute a plan to generate several decisions 2. Run `agents plan correct <DECISION_ID> --mode revert --guidance "..." --yes` 3. Run `agents plan tree <PLAN_ID>` to view the decision tree 4. Expected: Affected decisions show as superseded (`is_superseded=True`) 5. Actual: All decisions remain active (`is_superseded=False`) ## Verification ```bash agents plan tree <PLAN_ID> # All decisions still show as active agents plan tree --show-superseded <PLAN_ID> # No superseded decisions shown ``` ## Impact - **Data integrity**: The decision tree is not updated after correction — affected decisions remain active - **Spec violation**: The spec's "Supersede affected subtree" step is not implemented - **Downstream effects**: - `agents plan tree` shows stale decisions as active - `agents plan diff --correction` cannot compare old vs new decisions - Re-execution will encounter stale decisions that conflict with new ones --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added the

labels

2026-04-09 01:02:13 +00:00

HAL9000 added a new dependency

2026-04-09 01:04:38 +00:00

#4959 EPIC: Correction Engine — Revert & Append Modes with plan.attempt Tracking

~~HAL9000 referenced this issue 2026-04-09 01:06:02 +00:00~~

[AUTO-EPIC] Epic Planning Health Report (Cycle 1) #4985

HAL9000 added

and removed

labels

2026-04-09 01:10:50 +00:00

HAL9000 added this to the v3.2.0 milestone

2026-04-09 01:10:50 +00:00

HAL9000 commented

2026-04-09 01:10:50 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: High — Critical spec compliance bug
Milestone: v3.2.0
Story Points: 3 — M
MoSCoW: Must Have

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: High — Critical spec compliance bug - **Milestone**: v3.2.0 - **Story Points**: 3 — M - **MoSCoW**: Must Have --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 modified the milestone from v3.2.0 to v3.3.0

2026-04-09 01:11:37 +00:00