cleveragents/cleveragents-core

Fork 3

UAT: `agents lsp add/list/remove` JSON output data structure deviates from spec — flat data instead of spec-required nested keys #5098

New issue

Open

opened 2026-04-09 01:01:15 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-09 01:01:15 +00:00

Owner

Bug Report

Feature Area: LSP Registry / agents lsp JSON output
Severity: Medium
Discovered by: UAT Testing (uat-pool-1, worker: Provider Registry and LSP Integration)

What Was Tested

Tested agents lsp add, agents lsp list, and agents lsp remove with --format json against the spec-required JSON envelope structure.

Expected Behavior (from spec)

`agents lsp add --format json` (spec §agents lsp add, line 8692)

{
  "command": "lsp add",
  "status": "ok",
  "exit_code": 0,
  "data": {
    "lsp_server": {
      "name": "local/pyright",
      "languages": ["python"],
      "command": "pyright-langserver --stdio",
      "capabilities": ["diagnostics", "hover", "completions", ...]
    }
  },
  "timing": { "duration_ms": 12 },
  "messages": ["LSP server registered"]
}

`agents lsp list --format json` (spec §agents lsp list, line 8941)

{
  "command": "lsp list",
  "status": "ok",
  "exit_code": 0,
  "data": {
    "lsp_servers": [...],
    "total": 3
  },
  "timing": { "duration_ms": 8 },
  "messages": ["3 LSP servers listed"]
}

`agents lsp remove --format json` (spec §agents lsp remove)

{
  "command": "lsp remove",
  "status": "ok",
  "exit_code": 0,
  "data": {
    "lsp_server_removed": {
      "name": "local/pyright",
      ...
    }
  },
  "messages": ["LSP server removed"]
}

Actual Behavior

`agents lsp add --format json`

{
  "command": "",
  "status": "ok",
  "exit_code": 0,
  "data": {
    "name": "local/pyright",
    "description": "...",
    "languages": ["python"],
    "command": "pyright-langserver",
    "args": ["--stdio"],
    "transport": "stdio",
    "env": {},
    "capabilities": [...],
    "initialization": {...},
    "workspace_settings": {},
    "namespace": "local",
    "short_name": "pyright",
    "registered": true
  },
  "timing": { "duration_ms": 0 },
  "messages": [{"level": "ok", "text": "ok"}]
}

Deviations:

"command" is "" (empty) — should be "lsp add"
"data" is flat — should be nested under "data": {"lsp_server": {...}}
"messages" is [{"level": "ok", "text": "ok"}] — should be ["LSP server registered"]
Extra fields in data: args, transport, env, initialization, workspace_settings, namespace, short_name, registered — spec only shows name, languages, command, capabilities

`agents lsp list --format json`

{
  "command": "",
  "status": "ok",
  "exit_code": 0,
  "data": [
    {"name": "local/pyright", "languages": ["python"], "command": "pyright-langserver", ...}
  ],
  "timing": { "duration_ms": 0 },
  "messages": [{"level": "ok", "text": "ok"}]
}

Deviations:

"command" is "" — should be "lsp list"
"data" is a flat array — should be {"lsp_servers": [...], "total": N}
"messages" wrong format — should be ["N LSP servers listed"]

`agents lsp remove --format json`

{
  "command": "",
  "status": "ok",
  "exit_code": 0,
  "data": {"name": "local/pyright", "removed": true},
  "timing": { "duration_ms": 0 },
  "messages": [{"level": "ok", "text": "ok"}]
}

Deviations:

"command" is "" — should be "lsp remove"
"data" is {"name": ..., "removed": true} — should be {"lsp_server_removed": {...}}
"messages" wrong format

Root Cause

The format_output() calls in src/cleveragents/cli/commands/lsp.py do not pass:

command= parameter (so it defaults to "")
Properly structured data dict (data is passed flat instead of nested under spec-required keys)

This is the same systemic issue as #5015 (which covers actor/action/session) but for LSP commands.

Suggested Fix

Pass command="lsp add" etc. to format_output() calls
Wrap data under spec-required nested keys:
- lsp add: {"lsp_server": config_dict}
- lsp list: {"lsp_servers": [config_dict, ...], "total": N}
- lsp remove: {"lsp_server_removed": {"name": name}}
Pass messages=[{"level": "ok", "text": "LSP server registered"}] etc.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** LSP Registry / `agents lsp` JSON output **Severity:** Medium **Discovered by:** UAT Testing (uat-pool-1, worker: Provider Registry and LSP Integration) --- ## What Was Tested Tested `agents lsp add`, `agents lsp list`, and `agents lsp remove` with `--format json` against the spec-required JSON envelope structure. ## Expected Behavior (from spec) ### `agents lsp add --format json` (spec §agents lsp add, line 8692) ```json { "command": "lsp add", "status": "ok", "exit_code": 0, "data": { "lsp_server": { "name": "local/pyright", "languages": ["python"], "command": "pyright-langserver --stdio", "capabilities": ["diagnostics", "hover", "completions", ...] } }, "timing": { "duration_ms": 12 }, "messages": ["LSP server registered"] } ``` ### `agents lsp list --format json` (spec §agents lsp list, line 8941) ```json { "command": "lsp list", "status": "ok", "exit_code": 0, "data": { "lsp_servers": [...], "total": 3 }, "timing": { "duration_ms": 8 }, "messages": ["3 LSP servers listed"] } ``` ### `agents lsp remove --format json` (spec §agents lsp remove) ```json { "command": "lsp remove", "status": "ok", "exit_code": 0, "data": { "lsp_server_removed": { "name": "local/pyright", ... } }, "messages": ["LSP server removed"] } ``` ## Actual Behavior ### `agents lsp add --format json` ```json { "command": "", "status": "ok", "exit_code": 0, "data": { "name": "local/pyright", "description": "...", "languages": ["python"], "command": "pyright-langserver", "args": ["--stdio"], "transport": "stdio", "env": {}, "capabilities": [...], "initialization": {...}, "workspace_settings": {}, "namespace": "local", "short_name": "pyright", "registered": true }, "timing": { "duration_ms": 0 }, "messages": [{"level": "ok", "text": "ok"}] } ``` **Deviations:** 1. `"command"` is `""` (empty) — should be `"lsp add"` 2. `"data"` is flat — should be nested under `"data": {"lsp_server": {...}}` 3. `"messages"` is `[{"level": "ok", "text": "ok"}]` — should be `["LSP server registered"]` 4. Extra fields in data: `args`, `transport`, `env`, `initialization`, `workspace_settings`, `namespace`, `short_name`, `registered` — spec only shows `name`, `languages`, `command`, `capabilities` ### `agents lsp list --format json` ```json { "command": "", "status": "ok", "exit_code": 0, "data": [ {"name": "local/pyright", "languages": ["python"], "command": "pyright-langserver", ...} ], "timing": { "duration_ms": 0 }, "messages": [{"level": "ok", "text": "ok"}] } ``` **Deviations:** 1. `"command"` is `""` — should be `"lsp list"` 2. `"data"` is a flat array — should be `{"lsp_servers": [...], "total": N}` 3. `"messages"` wrong format — should be `["N LSP servers listed"]` ### `agents lsp remove --format json` ```json { "command": "", "status": "ok", "exit_code": 0, "data": {"name": "local/pyright", "removed": true}, "timing": { "duration_ms": 0 }, "messages": [{"level": "ok", "text": "ok"}] } ``` **Deviations:** 1. `"command"` is `""` — should be `"lsp remove"` 2. `"data"` is `{"name": ..., "removed": true}` — should be `{"lsp_server_removed": {...}}` 3. `"messages"` wrong format ## Root Cause The `format_output()` calls in `src/cleveragents/cli/commands/lsp.py` do not pass: - `command=` parameter (so it defaults to `""`) - Properly structured `data` dict (data is passed flat instead of nested under spec-required keys) This is the same systemic issue as #5015 (which covers actor/action/session) but for LSP commands. ## Suggested Fix 1. Pass `command="lsp add"` etc. to `format_output()` calls 2. Wrap data under spec-required nested keys: - `lsp add`: `{"lsp_server": config_dict}` - `lsp list`: `{"lsp_servers": [config_dict, ...], "total": N}` - `lsp remove`: `{"lsp_server_removed": {"name": name}}` 3. Pass `messages=[{"level": "ok", "text": "LSP server registered"}]` etc. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added the

labels

2026-04-09 01:01:25 +00:00

HAL9000 added this to the v3.2.0 milestone

2026-04-09 01:11:03 +00:00

HAL9000 commented

2026-04-09 01:11:13 +00:00

Author

Owner

Issue triaged by project owner: Verified as valid spec compliance bug. Priority: Medium. Milestone: v3.2.0.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: Verified as valid spec compliance bug. Priority: Medium. Milestone: v3.2.0. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 referenced this issue

2026-04-09 02:56:11 +00:00

[AUTO-UAT-POOL] UAT Testing Report (Cycle 4) #5160

HAL9000 referenced this issue

2026-04-09 03:09:06 +00:00

[AUTO-UAT-POOL] UAT Testing Report (Cycle 5) #5200

HAL9000 referenced this issue

2026-04-23 08:29:05 +00:00

docs(agents): sync pr-merge-pool-supervisor merge criteria with runtime behaviour #8228

HAL9000 referenced this issue

2026-04-23 08:51:59 +00:00

docs(agents): sync pr-merge-pool-supervisor merge criteria with runtime behaviour #8228