feature/m6plus-event-bus #509
Dismiss Review
Are you sure you want to dismiss this review?
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
aditya
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cleveragents/cleveragents-core#509
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "feature/m6plus-event-bus"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
Implements a general-purpose domain event system for CleverAgents as defined in
docs/specification.md§Event-Driven Architecture. AddsEventType,DomainEvent,EventBusProtocol,ReactiveEventBus(RxPY-backed), andLoggingEventBus(structlog-backed) under
src/cleveragents/infrastructure/events/. WiresDecisionServiceandPlanLifecycleServiceto emit domain events on significantstate changes, and registers
ReactiveEventBusas a Singleton in the DI container.Type of Change
Quality Checklist
Anyunless justified —details: dict[str, Any]is justified as an open event payload field per spec)nox -s typecheckpasses with no errorsnox -s lintpasses with no errorsfeatures/)robot/) if applicablenox -s coverage_report) — achieved 100% on all new filesnox -s security_scan)nox -s dead_code)Testing
All tests were written first (TDD) before implementation. The full event bus
surface is covered at 100% branch coverage across all six new source files
(27 scenarios, 75 steps passing).
Test Commands Run
Related Issues
ISSUES CLOSED #473
Implementation Notes
New package:
src/cleveragents/infrastructure/events/types.pyEventTypeStrEnum — 38 dot-separated identifiers across 8 domainsmodels.pyDomainEventfrozen Pydantic model with auto-UTC timestamp and auto-ULIDcorrelation_idprotocol.py@runtime_checkable EventBusProtocol withemit()andsubscribe()reactive.pyReactiveEventBus— RxPYSubject-backed bus; dual-dispatch (stream + callbacks)logging_bus.pyLoggingEventBus— structlog-only bus; drop-in replacement requiring no RxPY__init__.pyDesign decisions
event_busparameter on services — bothDecisionServiceandPlanLifecycleServiceacceptevent_bus: EventBus | None = None. WhenNone,emission is silently skipped. This preserves full backward compatibility with
existing callers and tests that construct services without a bus.
# type: ignorein source —rx.Observableis imported directly fromrx.core.observable.observablerather thanrx.Observable(which pyright flagsas
reportPrivateImportUsage). All source files pass pyright strict mode with0 errors and 0 warnings and without any suppression comments.
ReactiveEventBus— everyemit()call pushes to the RxPYSubjectstream (for advanced operators likefilter,debounce) and invokesregistered callbacks synchronously. Plain callback subscribers work with no RxPY
knowledge; reactive subscribers use
bus.streamdirectly.LoggingEventBusas an alternative — useful for audit-trail-only contexts(e.g., CLI invocations, serverless) where an RxPY dependency is undesirable.
event_bus_steps.pyat 476 lines,compliant with the project's modular design guideline.
Files added
Files modified
Review:
feat(events): add EventBus protocol and ReactiveEventBus implementationPre-PR Checklist
ISSUES CLOSED: #473v3.6.0Anyin production signaturesdetails: dict[str, Any]justified per spec# type: ignoreP1 — Must Fix
P1-1: Spec's
_persist_audit(event)missing fromReactiveEventBus.emit()reactive.py:56-62specification.md:42696-42698showsReactiveEventBus.emit()callingself._persist_audit(event)betweenon_next()and handler dispatch. The implementation omits this. Either implement_persist_audit()(e.g. delegate to structlog), register aLoggingEventBus-style handler automatically, or get a spec amendment documenting the deferral.P1-2: Bare
MagicMock()for known typesevent_bus_steps.py:290,314,366·helper_event_bus.py:126,154Never use bare
MagicMock()for known types. UseMagicMock(spec=Settings)orcreate_autospec(Settings, instance=True). Affects 5 call sites across Behave steps and Robot helper.P2 — Should Fix
P2-1:
correlation_idfield not in specmodels.py:51-54DomainEventaddscorrelation_id: str(auto ULID) which is absent fromspecification.md:42666-42675. Sensible addition for traceability, but the spec divergence should be documented — either update the spec or add an inline comment noting the extension.P2-2: No thread safety on
_subscriptionsreactive.py:35,62-63·logging_bus.py:46,66-67Both buses use
dict.setdefault().append()insubscribe()and iterate_subscriptions.get()inemit()without locking. The DI container registers the bus as a Singleton shared across the process. Ifsubscribe()is called concurrently withemit()from different threads, the list could be mutated during iteration. Consider athreading.Lockor documenting single-threaded-only usage.P2-3: Nested bare
MagicMock()for UoW transaction chainevent_bus_steps.py:283-287,307-311·helper_event_bus.py:120-124Four nested bare mocks. If
UnitOfWork's transaction API changes, these tests pass silently. Usecreate_autospec(UnitOfWork, instance=True)for the top-level mock at minimum.P3 — Nit / Optional
P3-1: CHANGELOG says "40 typed event identifiers" but
EventTypehas 38 members.P3-2:
LoggingEventBuslogs thedetailsdict raw. Ifdetailsever contains sensitive data, it would appear in structured logs. Acceptable if the structlog pipeline has redaction processors.P3-3: Merge conflicts with master (
mergeable: false). Rebase required before merge.Summary
Well-structured PR with clean separation (types / models / protocol / reactive / logging), proper
@runtime_checkableProtocol usage, backward-compatible service wiring via optionalevent_busparameter, and thorough test coverage (27 Behave + 9 Robot + 5 ASV suites). All spec-defined EventType values and DomainEvent fields are implemented correctly.2 P1s and 3 P2s to address. The most significant is P1-1 — the spec explicitly defines
_persist_audit(event)inReactiveEventBus.emit()and it is absent from the implementation.PM Review — Day 25
Status
feature/m6plus-event-busonto currentmaster.Action Items
masterto resolve conflicts.Priority
Low urgency — v3.6.0 is not due until Mar 28. Rebase at convenience.
New commits pushed, approval review dismissed automatically according to repository settings