cleveragents/cleveragents-core

Fork 3

UAT: `ActorService` restricts custom actors to `local/` namespace only — spec allows any `namespace/name` pattern #5083

New issue

Open

opened 2026-04-09 00:56:59 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-09 00:56:59 +00:00

Owner

Bug Report

Feature Area: Actor System — Actor namespacing
Severity: High
Discovered by: UAT Testing (uat-pool-1, worker: Actor System)

What Was Tested

Reviewed the ActorService._normalize_name() method in src/cleveragents/application/services/actor_service.py against the spec's namespace requirements.

Expected Behavior (from spec)

The spec defines the actor namespace format as [[server:]namespace/]name and states:

"Namespaced as [[server:]namespace/]name."
"local/ is reserved for local-only items."
"Non-local/ namespaces with server omitted assume the default configured server."

This means custom actors should be registerable with any namespace, not just local/. For example:

local/my-actor — local namespace (current behavior)
myorg/my-actor — org namespace (should work but doesn't)
myteam/my-actor — team namespace (should work but doesn't)

The spec explicitly says local/ is reserved for local-only items, implying other namespaces are valid for custom actors.

Actual Behavior

ActorService._normalize_name() enforces that custom actors must use local/<id> only:

# src/cleveragents/application/services/actor_service.py
def _normalize_name(self, name: str, *, allow_built_in: bool = False) -> str:
    ...
    prefix, identifier = normalized.split("/", 1)
    if not prefix or not identifier:
        raise ValidationError("Actor names must include both prefix and identifier")
    if prefix != "local" and not allow_built_in:
        raise ValidationError(
            "Custom actors must use the 'local/<id>' naming pattern"
        )
    return normalized

Attempting to register an actor with a non-local/ namespace raises:

ValidationError: Custom actors must use the 'local/<id>' naming pattern

Code Location

src/cleveragents/application/services/actor_service.py — ActorService._normalize_name()
src/cleveragents/actor/registry.py — ActorRegistry.upsert_actor() (also enforces local/ via service)

Impact

Users cannot create actors in their own namespace (e.g., myorg/my-actor)
Team/org-scoped actors cannot be registered
The spec's namespace model is not fully implemented for custom actors
Multi-user/team workflows that rely on namespaced actors are broken

Steps to Reproduce

# Create a YAML file with a non-local namespace
cat > /tmp/my-actor.yaml << 'EOF'
name: myorg/my-actor
type: llm
description: My org actor
model: gpt-4
provider: openai
EOF

# This should work per spec but fails:
agents actor add local/my-actor --config /tmp/my-actor.yaml
# OR (per spec's config-as-source-of-truth):
agents actor add --config /tmp/my-actor.yaml
# ValidationError: Custom actors must use the 'local/<id>' naming pattern

Suggested Fix

Remove the local/ restriction from _normalize_name() for custom actors. The restriction should only apply to server-qualified names (which require a server connection):

def _normalize_name(self, name: str, *, allow_built_in: bool = False) -> str:
    normalized = name.strip()
    if not normalized:
        raise ValidationError("Actor name cannot be empty")
    if "/" not in normalized:
        normalized = f"local/{normalized}"
    
    # Allow server:namespace/name format
    if ":" in normalized:
        server, rest = normalized.split(":", 1)
        if "/" not in rest:
            raise ValidationError("Server-qualified names must include namespace/name")
        return normalized
    
    if normalized.count("/") != 1:
        raise ValidationError("Actor names must include exactly one '/' separator")
    
    prefix, identifier = normalized.split("/", 1)
    if not prefix or not identifier:
        raise ValidationError("Actor names must include both prefix and identifier")
    
    # Allow any namespace for custom actors (not just 'local/')
    # Built-in actors use provider namespaces (openai/, anthropic/, etc.)
    return normalized

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** Actor System — Actor namespacing **Severity:** High **Discovered by:** UAT Testing (uat-pool-1, worker: Actor System) --- ## What Was Tested Reviewed the `ActorService._normalize_name()` method in `src/cleveragents/application/services/actor_service.py` against the spec's namespace requirements. ## Expected Behavior (from spec) The spec defines the actor namespace format as `[[server:]namespace/]name` and states: > "Namespaced as `[[server:]namespace/]name`." > "`local/` is reserved for local-only items." > "Non-`local/` namespaces with server omitted assume the default configured server." This means custom actors should be registerable with any namespace, not just `local/`. For example: - `local/my-actor` — local namespace (current behavior) - `myorg/my-actor` — org namespace (should work but doesn't) - `myteam/my-actor` — team namespace (should work but doesn't) The spec explicitly says `local/` is **reserved** for local-only items, implying other namespaces are valid for custom actors. ## Actual Behavior `ActorService._normalize_name()` enforces that custom actors must use `local/<id>` only: ```python # src/cleveragents/application/services/actor_service.py def _normalize_name(self, name: str, *, allow_built_in: bool = False) -> str: ... prefix, identifier = normalized.split("/", 1) if not prefix or not identifier: raise ValidationError("Actor names must include both prefix and identifier") if prefix != "local" and not allow_built_in: raise ValidationError( "Custom actors must use the 'local/<id>' naming pattern" ) return normalized ``` Attempting to register an actor with a non-`local/` namespace raises: ``` ValidationError: Custom actors must use the 'local/<id>' naming pattern ``` ## Code Location - `src/cleveragents/application/services/actor_service.py` — `ActorService._normalize_name()` - `src/cleveragents/actor/registry.py` — `ActorRegistry.upsert_actor()` (also enforces `local/` via service) ## Impact - Users cannot create actors in their own namespace (e.g., `myorg/my-actor`) - Team/org-scoped actors cannot be registered - The spec's namespace model is not fully implemented for custom actors - Multi-user/team workflows that rely on namespaced actors are broken ## Steps to Reproduce ```bash # Create a YAML file with a non-local namespace cat > /tmp/my-actor.yaml << 'EOF' name: myorg/my-actor type: llm description: My org actor model: gpt-4 provider: openai EOF # This should work per spec but fails: agents actor add local/my-actor --config /tmp/my-actor.yaml # OR (per spec's config-as-source-of-truth): agents actor add --config /tmp/my-actor.yaml # ValidationError: Custom actors must use the 'local/<id>' naming pattern ``` ## Suggested Fix Remove the `local/` restriction from `_normalize_name()` for custom actors. The restriction should only apply to server-qualified names (which require a server connection): ```python def _normalize_name(self, name: str, *, allow_built_in: bool = False) -> str: normalized = name.strip() if not normalized: raise ValidationError("Actor name cannot be empty") if "/" not in normalized: normalized = f"local/{normalized}" # Allow server:namespace/name format if ":" in normalized: server, rest = normalized.split(":", 1) if "/" not in rest: raise ValidationError("Server-qualified names must include namespace/name") return normalized if normalized.count("/") != 1: raise ValidationError("Actor names must include exactly one '/' separator") prefix, identifier = normalized.split("/", 1) if not prefix or not identifier: raise ValidationError("Actor names must include both prefix and identifier") # Allow any namespace for custom actors (not just 'local/') # Built-in actors use provider namespaces (openai/, anthropic/, etc.) return normalized ``` --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added the

labels

2026-04-09 00:57:05 +00:00

HAL9000 added this to the v3.2.0 milestone

2026-04-09 01:01:26 +00:00

HAL9000 commented

2026-04-09 01:01:34 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: High — Spec compliance bug that breaks documented behavior
Milestone: v3.2.0
Story Points: 3 — M
MoSCoW: Must Have — Spec compliance is required

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: High — Spec compliance bug that breaks documented behavior - **Milestone**: v3.2.0 - **Story Points**: 3 — M - **MoSCoW**: Must Have — Spec compliance is required --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 referenced this issue

2026-04-09 01:05:25 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 2) #5115

HAL9000 referenced this issue

2026-04-09 02:56:12 +00:00

[AUTO-UAT-POOL] UAT Testing Report (Cycle 4) #5160

HAL9000 referenced this issue

2026-04-09 03:09:06 +00:00

[AUTO-UAT-POOL] UAT Testing Report (Cycle 5) #5200