cleveragents/cleveragents-core

Fork 3

UAT: Tool lifecycle config schema missing `execute` hook — spec defines discover/activate/execute/deactivate but implementation only supports discover/activate/deactivate #5041

New issue

Open

opened 2026-04-09 00:50:15 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-09 00:50:15 +00:00

Owner

Bug Report

Feature Area: Tools & Skills — Tool Lifecycle Hooks

Severity: Medium (missing spec-required lifecycle hook)

What Was Tested

Tool lifecycle hook configuration in the tool YAML config file.

Expected Behavior (from spec)

The spec (§ Tool, line ~135) defines a four-stage lifecycle:

discover / activate / execute / deactivate

The spec's Tool Configuration Files section (§ Lifecycle Hook Fields, line ~33911) defines the lifecycle object with these hooks:

discover — run during tool discovery
activate — run when tool is activated
execute — (implied by the four-stage lifecycle)
deactivate — run when tool is deactivated

The ToolLifecycle domain model and ToolInstance protocol both define all four stages.

Actual Behavior (from code)

The spec's JSON Schema for tool configuration files (line ~33712–33729) defines the lifecycle object with only 3 hooks:

"lifecycle": {
  "properties": {
    "discover": { "type": "string" },
    "activate": { "type": "string" },
    "deactivate": { "type": "string" }
  },
  "additionalProperties": false
}

The execute hook is missing from the JSON Schema, even though:

The spec's four-stage lifecycle definition includes execute
The ToolLifecycle domain model (src/cleveragents/domain/models/core/tool.py, lines 275–295) includes an execute field
The ToolInstance protocol (src/cleveragents/tool/lifecycle.py, lines 232–278) defines an execute() method

This inconsistency means:

Users cannot configure an execute lifecycle hook in their tool YAML (the JSON Schema forbids it via additionalProperties: false)
The domain model supports it but the config schema doesn't expose it

Code Location

docs/specification.md — Tool Configuration Files JSON Schema, lines ~33712–33729 (missing execute in lifecycle.properties)
src/cleveragents/domain/models/core/tool.py — ToolLifecycle model, lines 275–295 (has execute field)
src/cleveragents/tool/lifecycle.py — ToolInstance protocol, lines 232–278 (has execute() method)

Fix Required

The spec's JSON Schema for tool configuration files must be updated to include execute in the lifecycle properties:

"lifecycle": {
  "properties": {
    "discover": { "type": "string", "description": "..." },
    "activate": { "type": "string", "description": "..." },
    "execute": { "type": "string", "description": "Python code or function name run during tool execution." },
    "deactivate": { "type": "string", "description": "..." }
  },
  "additionalProperties": false
}

The spec's Structure Reference table (§ Lifecycle Hook Fields) must also be updated to include the execute hook.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** Tools & Skills — Tool Lifecycle Hooks **Severity:** Medium (missing spec-required lifecycle hook) --- ## What Was Tested Tool lifecycle hook configuration in the tool YAML config file. --- ## Expected Behavior (from spec) The spec (§ Tool, line ~135) defines a **four-stage lifecycle**: ``` discover / activate / execute / deactivate ``` The spec's Tool Configuration Files section (§ Lifecycle Hook Fields, line ~33911) defines the `lifecycle` object with these hooks: - `discover` — run during tool discovery - `activate` — run when tool is activated - `execute` — (implied by the four-stage lifecycle) - `deactivate` — run when tool is deactivated The `ToolLifecycle` domain model and `ToolInstance` protocol both define all four stages. --- ## Actual Behavior (from code) The spec's **JSON Schema** for tool configuration files (line ~33712–33729) defines the `lifecycle` object with only **3 hooks**: ```json "lifecycle": { "properties": { "discover": { "type": "string" }, "activate": { "type": "string" }, "deactivate": { "type": "string" } }, "additionalProperties": false } ``` The `execute` hook is **missing** from the JSON Schema, even though: 1. The spec's four-stage lifecycle definition includes `execute` 2. The `ToolLifecycle` domain model (`src/cleveragents/domain/models/core/tool.py`, lines 275–295) includes an `execute` field 3. The `ToolInstance` protocol (`src/cleveragents/tool/lifecycle.py`, lines 232–278) defines an `execute()` method This inconsistency means: - Users cannot configure an `execute` lifecycle hook in their tool YAML (the JSON Schema forbids it via `additionalProperties: false`) - The domain model supports it but the config schema doesn't expose it --- ## Code Location - `docs/specification.md` — Tool Configuration Files JSON Schema, lines ~33712–33729 (missing `execute` in `lifecycle.properties`) - `src/cleveragents/domain/models/core/tool.py` — `ToolLifecycle` model, lines 275–295 (has `execute` field) - `src/cleveragents/tool/lifecycle.py` — `ToolInstance` protocol, lines 232–278 (has `execute()` method) --- ## Fix Required The spec's JSON Schema for tool configuration files must be updated to include `execute` in the `lifecycle` properties: ```json "lifecycle": { "properties": { "discover": { "type": "string", "description": "..." }, "activate": { "type": "string", "description": "..." }, "execute": { "type": "string", "description": "Python code or function name run during tool execution." }, "deactivate": { "type": "string", "description": "..." } }, "additionalProperties": false } ``` The spec's Structure Reference table (§ Lifecycle Hook Fields) must also be updated to include the `execute` hook. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-09 00:50:45 +00:00

[AUTO-UAT-POOL] UAT Testing Report (Cycle 2) #4987

HAL9000 added the

labels

2026-04-09 00:51:21 +00:00

HAL9000 added this to the v3.2.0 milestone

2026-04-09 01:01:27 +00:00

HAL9000 commented

2026-04-09 01:01:35 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: High — Spec compliance bug that breaks documented behavior
Milestone: v3.2.0
Story Points: 3 — M
MoSCoW: Must Have — Spec compliance is required

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: High — Spec compliance bug that breaks documented behavior - **Milestone**: v3.2.0 - **Story Points**: 3 — M - **MoSCoW**: Must Have — Spec compliance is required --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 referenced this issue

2026-04-09 01:05:25 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 2) #5115

HAL9000 referenced this issue

2026-04-09 02:56:12 +00:00

[AUTO-UAT-POOL] UAT Testing Report (Cycle 4) #5160

HAL9000 referenced this issue

2026-04-09 03:09:06 +00:00

[AUTO-UAT-POOL] UAT Testing Report (Cycle 5) #5200