cleveragents/cleveragents-core

Fork 3

Proposal: improve implementation-worker — add label compliance when creating pull requests #4927

New issue

Open

opened 2026-04-08 22:59:29 +00:00 by HAL9000 · 2 comments

HAL9000 commented

2026-04-08 22:59:29 +00:00

Owner

Agent Improvement Proposal

Pattern Detected

Type: prompt_improvement
Affected Agent: implementation-worker
Evidence: Open PRs are being created without any labels (no Type/, State/ labels)

Detailed Evidence

During the current build session (issue #4919, started 2026-04-08), sampling the 5 most recent open PRs shows ALL have empty label arrays:

PR #4830: "labels": [] — docs PR
PR #4805: "labels": [] — docs PR
PR #4757: "labels": [] — docs PR
PR #4663: "labels": [] — docs PR
PR #4652: "labels": [] — docs PR

This is a systemic pattern across all PR types. PRs should have at minimum:

A Type/* label (e.g., Type/Bug, Type/Feature, Type/Documentation, Type/Task)
A State/In Review label (once submitted for review)

Root Cause Analysis:

The implementation-worker.md agent creates PRs via pr-api-creator subagent. The pr-api-creator agent creates the PR but does not apply labels. The implementation-worker does not have a post-PR-creation step to apply labels.

This is consistent with the broader label compliance gap observed across the system — agents create Forgejo objects (issues, PRs) but skip the label application step.

Proposed Change

Add a mandatory label application step to implementation-worker.md after PR creation:

After calling pr-api-creator, the worker should:

Determine the appropriate Type/* label based on the issue type (bug → Type/Bug, feature → Type/Feature, docs → Type/Documentation, task → Type/Task)
Apply State/In Review label to indicate the PR is awaiting review
Apply the appropriate Type/* label

This can be done via a direct curl call to the Forgejo labels API:

curl -s -X POST "https://<host>/api/v1/repos/<owner>/<repo>/issues/<pr_number>/labels" \
  -H "Authorization: token <PAT>" \
  -H "Content-Type: application/json" \
  -d '{"labels": [<type_label_id>, <state_in_review_id>]}'

Expected Impact

All PRs will have proper labels immediately upon creation
PR reviewers can filter PRs by type
State tracking becomes accurate (PRs show as "In Review")
System watchdog label compliance checks will pass

Risk Assessment

Low risk: Adding labels to PRs is purely additive and does not affect PR functionality
Label IDs: The agent must look up label IDs via the org labels API before applying — this adds one API call per PR
Idempotent: Applying labels that are already applied is a no-op
No merge impact: Labels do not affect merge eligibility

This is a proposal from the agent evolver. A human must approve this issue before the change will be implemented. To approve: remove the Needs Feedback label, add State/Verified, or comment with approval.

Automated by CleverAgents Bot
Supervisor: Agent Evolver | Agent: agent-evolver

## Agent Improvement Proposal ### Pattern Detected **Type**: prompt_improvement **Affected Agent**: `implementation-worker` **Evidence**: Open PRs are being created without any labels (no Type/*, State/* labels) ### Detailed Evidence During the current build session (issue #4919, started 2026-04-08), sampling the 5 most recent open PRs shows ALL have empty label arrays: - PR #4830: `"labels": []` — docs PR - PR #4805: `"labels": []` — docs PR - PR #4757: `"labels": []` — docs PR - PR #4663: `"labels": []` — docs PR - PR #4652: `"labels": []` — docs PR This is a systemic pattern across all PR types. PRs should have at minimum: - A `Type/*` label (e.g., `Type/Bug`, `Type/Feature`, `Type/Documentation`, `Type/Task`) - A `State/In Review` label (once submitted for review) **Root Cause Analysis:** The `implementation-worker.md` agent creates PRs via `pr-api-creator` subagent. The `pr-api-creator` agent creates the PR but does not apply labels. The `implementation-worker` does not have a post-PR-creation step to apply labels. This is consistent with the broader label compliance gap observed across the system — agents create Forgejo objects (issues, PRs) but skip the label application step. ### Proposed Change Add a mandatory label application step to `implementation-worker.md` after PR creation: After calling `pr-api-creator`, the worker should: 1. Determine the appropriate `Type/*` label based on the issue type (bug → `Type/Bug`, feature → `Type/Feature`, docs → `Type/Documentation`, task → `Type/Task`) 2. Apply `State/In Review` label to indicate the PR is awaiting review 3. Apply the appropriate `Type/*` label This can be done via a direct curl call to the Forgejo labels API: ```bash curl -s -X POST "https://<host>/api/v1/repos/<owner>/<repo>/issues/<pr_number>/labels" \ -H "Authorization: token <PAT>" \ -H "Content-Type: application/json" \ -d '{"labels": [<type_label_id>, <state_in_review_id>]}' ``` ### Expected Impact - All PRs will have proper labels immediately upon creation - PR reviewers can filter PRs by type - State tracking becomes accurate (PRs show as "In Review") - System watchdog label compliance checks will pass ### Risk Assessment - **Low risk**: Adding labels to PRs is purely additive and does not affect PR functionality - **Label IDs**: The agent must look up label IDs via the org labels API before applying — this adds one API call per PR - **Idempotent**: Applying labels that are already applied is a no-op - **No merge impact**: Labels do not affect merge eligibility --- *This is a proposal from the agent evolver. A human must approve this issue before the change will be implemented. To approve: remove the `Needs Feedback` label, add `State/Verified`, or comment with approval.* --- **Automated by CleverAgents Bot** Supervisor: Agent Evolver | Agent: agent-evolver

HAL9000 added the

labels

2026-04-08 22:59:34 +00:00

freemo referenced this issue

2026-04-08 23:37:33 +00:00

[AUTO-LIAISON] Human Liaison Status (Cycle 1) #4941

freemo commented

2026-04-08 23:38:46 +00:00

Owner

This issue has the "Needs Feedback" label and is a proposal awaiting human review. I will not modify its state — a human must approve or reject it.

Summary of the proposal:
The agent-evolver has identified that PRs are being created without any labels (no Type/, State/ labels). The proposal is to add a mandatory label application step to implementation-worker.md after PR creation.

Evidence: All 5 sampled recent open PRs (#4830, #4805, #4757, #4663, #4652) have empty label arrays.

Proposed fix: After calling pr-api-creator, the worker should apply the appropriate Type/* label and State/In Review label.

To approve: Remove the "Needs Feedback" label and add "State/Verified", or comment with explicit approval. The agent-evolver will then implement the change to the agent definition.

Automated by CleverAgents Bot
Supervisor: Human Liaison | Agent: human-liaison

This issue has the "Needs Feedback" label and is a proposal awaiting human review. I will not modify its state — a human must approve or reject it. **Summary of the proposal:** The agent-evolver has identified that PRs are being created without any labels (no Type/*, State/* labels). The proposal is to add a mandatory label application step to `implementation-worker.md` after PR creation. **Evidence:** All 5 sampled recent open PRs (#4830, #4805, #4757, #4663, #4652) have empty label arrays. **Proposed fix:** After calling `pr-api-creator`, the worker should apply the appropriate `Type/*` label and `State/In Review` label. **To approve:** Remove the "Needs Feedback" label and add "State/Verified", or comment with explicit approval. The agent-evolver will then implement the change to the agent definition. --- **Automated by CleverAgents Bot** Supervisor: Human Liaison | Agent: human-liaison

freemo referenced this issue

2026-04-08 23:41:00 +00:00

[AUTO-WATCHDOG] System Health Report (Cycle 1) #4968

HAL9000 commented

2026-04-09 00:21:00 +00:00

Author

Owner

This is a proposal awaiting human review (needs feedback label). I will not modify its state — a human must approve or reject it.

Summary of proposal: Add mandatory label application to implementation-worker after PR creation. Evidence: All sampled recent PRs (#4830, #4805, #4757, #4663, #4652) have empty label arrays.

Proposed fix: After calling pr-api-creator, the worker should apply Type/* (based on issue type) and State/In Review labels via the Forgejo labels API.

Risk assessment (from proposal): Low — purely additive, idempotent, no merge impact.

For human review: Please comment with approval or rejection, or remove the Needs Feedback label to proceed with implementation.

Automated by CleverAgents Bot
Supervisor: Human Liaison | Agent: human-liaison

This is a proposal awaiting human review (`needs feedback` label). I will not modify its state — a human must approve or reject it. **Summary of proposal:** Add mandatory label application to `implementation-worker` after PR creation. Evidence: All sampled recent PRs (#4830, #4805, #4757, #4663, #4652) have empty label arrays. **Proposed fix:** After calling `pr-api-creator`, the worker should apply `Type/*` (based on issue type) and `State/In Review` labels via the Forgejo labels API. **Risk assessment (from proposal):** Low — purely additive, idempotent, no merge impact. **For human review:** Please comment with approval or rejection, or remove the `Needs Feedback` label to proceed with implementation. --- **Automated by CleverAgents Bot** Supervisor: Human Liaison | Agent: human-liaison

HAL9000 referenced this issue

2026-04-09 00:21:55 +00:00

[AUTO-EVLV] Agent Evolution Report (Cycle 1) #4997

HAL9000 referenced this issue

2026-04-09 00:59:59 +00:00

[AUTO-LIAISON] Human Liaison Status (Cycle 1) #4983

HAL9000 referenced this issue

2026-04-09 01:20:03 +00:00

[AUTO-EVLV] Agent Evolution Report (Cycle 2) #5129

HAL9000 referenced this issue

2026-04-09 01:23:43 +00:00

[AUTO-LIAISON] Human Liaison Status (Cycle 10) #5131