cleveragents/cleveragents-core

Fork 3

UAT: `devcontainer-instance` child types only lists `devcontainer-file` — inherited `container-mount`, `container-exec-env`, `container-port` children not available until activation #4906

New issue

Open

opened 2026-04-08 20:18:15 +00:00 by HAL9000 · 2 comments

HAL9000 commented

2026-04-08 20:18:15 +00:00

Owner

Bug Report

Feature Area: Devcontainer Integration — Resource Type Inheritance
ADR Reference: ADR-043 §devcontainer-instance Resource Type (Allowed children), ADR-042 §Collection Field Merging
Severity: Medium (child resource discovery incomplete; DAG structure diverges from spec)

What Was Tested

ADR-043 specifies that devcontainer-instance should support container-mount, container-exec-env, and container-port as allowed children (inherited from container-instance). The spec also describes lazy activation creating these children.

Expected Behavior (from ADR-043)

| Allowed children | (all inherited from container-instance: container-mount, container-exec-env, container-port) |

And the activation lifecycle:

Activation (provisioning_state: active): Once the container is running, the inherited container-instance auto-discovery runs — discovering container-mount children (workspace mount + any additional mounts from devcontainer.json), container-exec-env (executables available inside the container), and container-port (forwarded ports).

Actual Behavior

The devcontainer-instance type definition in _resource_registry_data.py only lists devcontainer-file as a child type:

# src/cleveragents/application/services/_resource_registry_data.py:268
"child_types": ["devcontainer-file"],

While container-instance defines:

# src/cleveragents/application/services/_resource_registry_data.py:233-237
"child_types": [
    "container-mount",
    "container-exec-env",
    "container-port",
],

Via ADR-042 additive collection merging, devcontainer-instance should have child types: ["container-mount", "container-exec-env", "container-port", "devcontainer-file"]. The inheritance engine (resource/inheritance.py:_merge_string_list) would produce this union automatically.

However, the devcontainer-instance definition uses "child_types_replace": False (default), so the inheritance engine SHOULD merge these. Let me clarify the actual issue:

The inheritance merging works correctly at the type-system level — devcontainer-instance inherits container-mount, container-exec-env, and container-port as allowed children. The actual gap is that DevcontainerHandler.discover_children() does not create these child resources on activation. The handler's discover_children() method only runs devcontainer exec ls -1 and creates fs-directory children — it does not:

Create container-mount children for the workspace mount and additional mounts from devcontainer.json.
Create container-exec-env children for executables available inside the container.
Create container-port children for forwarded ports from devcontainer.json.

Code Locations

Handler discover_children: src/cleveragents/resource/handlers/devcontainer.py:436-481 — only creates fs-directory children
ADR-043 spec: docs/adr/ADR-043-devcontainer-integration.md:118 — activation should discover mounts, exec-env, ports
Type definition: src/cleveragents/application/services/_resource_registry_data.py:268

Impact

After a devcontainer is activated:

No container-mount resources are created for the workspace bind mount.
No container-exec-env resources are created for tools available in the container.
No container-port resources are created for forwarded ports.
The resource DAG does not reflect the actual container structure as described in ADR-043.
Tools that query for container mounts or exec environments via the DAG will find nothing.

Fix Required

Extend DevcontainerHandler.discover_children() (or add a separate _discover_on_activation() method called from activate_container()) to:

Parse devcontainer.json to extract workspaceFolder, mounts, forwardPorts.
Create container-mount child resources for the workspace mount and additional mounts.
Create container-port child resources for forwarded ports.
Optionally create container-exec-env resources for key executables.

These children should only be created when provisioning_state transitions to active (i.e., after devcontainer up succeeds).

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** Devcontainer Integration — Resource Type Inheritance **ADR Reference:** ADR-043 §`devcontainer-instance` Resource Type (Allowed children), ADR-042 §Collection Field Merging **Severity:** Medium (child resource discovery incomplete; DAG structure diverges from spec) --- ## What Was Tested ADR-043 specifies that `devcontainer-instance` should support `container-mount`, `container-exec-env`, and `container-port` as allowed children (inherited from `container-instance`). The spec also describes lazy activation creating these children. ## Expected Behavior (from ADR-043) > | **Allowed children** | (all inherited from `container-instance`: `container-mount`, `container-exec-env`, `container-port`) | And the activation lifecycle: > 3. **Activation** (`provisioning_state: active`): Once the container is running, the inherited `container-instance` auto-discovery runs — discovering `container-mount` children (workspace mount + any additional mounts from devcontainer.json), `container-exec-env` (executables available inside the container), and `container-port` (forwarded ports). ## Actual Behavior The `devcontainer-instance` type definition in `_resource_registry_data.py` only lists `devcontainer-file` as a child type: ```python # src/cleveragents/application/services/_resource_registry_data.py:268 "child_types": ["devcontainer-file"], ``` While `container-instance` defines: ```python # src/cleveragents/application/services/_resource_registry_data.py:233-237 "child_types": [ "container-mount", "container-exec-env", "container-port", ], ``` Via ADR-042 additive collection merging, `devcontainer-instance` should have child types: `["container-mount", "container-exec-env", "container-port", "devcontainer-file"]`. The inheritance engine (`resource/inheritance.py:_merge_string_list`) would produce this union automatically. **However**, the `devcontainer-instance` definition uses `"child_types_replace": False` (default), so the inheritance engine SHOULD merge these. Let me clarify the actual issue: The inheritance merging works correctly at the type-system level — `devcontainer-instance` inherits `container-mount`, `container-exec-env`, and `container-port` as allowed children. The actual gap is that **`DevcontainerHandler.discover_children()` does not create these child resources on activation**. The handler's `discover_children()` method only runs `devcontainer exec ls -1` and creates `fs-directory` children — it does not: 1. Create `container-mount` children for the workspace mount and additional mounts from `devcontainer.json`. 2. Create `container-exec-env` children for executables available inside the container. 3. Create `container-port` children for forwarded ports from `devcontainer.json`. ## Code Locations - Handler discover_children: `src/cleveragents/resource/handlers/devcontainer.py:436-481` — only creates `fs-directory` children - ADR-043 spec: `docs/adr/ADR-043-devcontainer-integration.md:118` — activation should discover mounts, exec-env, ports - Type definition: `src/cleveragents/application/services/_resource_registry_data.py:268` ## Impact After a devcontainer is activated: - No `container-mount` resources are created for the workspace bind mount. - No `container-exec-env` resources are created for tools available in the container. - No `container-port` resources are created for forwarded ports. - The resource DAG does not reflect the actual container structure as described in ADR-043. - Tools that query for container mounts or exec environments via the DAG will find nothing. ## Fix Required Extend `DevcontainerHandler.discover_children()` (or add a separate `_discover_on_activation()` method called from `activate_container()`) to: 1. Parse `devcontainer.json` to extract `workspaceFolder`, `mounts`, `forwardPorts`. 2. Create `container-mount` child resources for the workspace mount and additional mounts. 3. Create `container-port` child resources for forwarded ports. 4. Optionally create `container-exec-env` resources for key executables. These children should only be created when `provisioning_state` transitions to `active` (i.e., after `devcontainer up` succeeds). --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 20:19:48 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:22:25 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 added the

labels

2026-04-08 22:59:16 +00:00

HAL9000 added this to the v3.5.0 milestone

2026-04-08 23:01:03 +00:00

HAL9000 commented

2026-04-08 23:07:07 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — devcontainer child resource discovery is incomplete; container-mount, container-exec-env, container-port children not created on activation
Milestone: v3.5.0 — Devcontainer integration and ADR-043 compliance is scoped to Autonomy Hardening milestone
Story Points: 5 — L — requires extending DevcontainerHandler.discover_children() to parse devcontainer.json and create mount/exec-env/port child resources on activation
MoSCoW: Should Have — ADR-043 compliance; resource DAG should reflect actual container structure; important for tools that query container mounts/environments
Parent Epic: Devcontainer Integration epic (v3.5.0)

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — devcontainer child resource discovery is incomplete; `container-mount`, `container-exec-env`, `container-port` children not created on activation - **Milestone**: v3.5.0 — Devcontainer integration and ADR-043 compliance is scoped to Autonomy Hardening milestone - **Story Points**: 5 — L — requires extending `DevcontainerHandler.discover_children()` to parse `devcontainer.json` and create mount/exec-env/port child resources on activation - **MoSCoW**: Should Have — ADR-043 compliance; resource DAG should reflect actual container structure; important for tools that query container mounts/environments - **Parent Epic**: Devcontainer Integration epic (v3.5.0) --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

freemo added a new dependency

2026-04-08 23:42:06 +00:00

#4952 EPIC: Devcontainer Lifecycle Management — State Persistence & Auto-Discovery

freemo referenced this issue

2026-04-08 23:43:07 +00:00

LEGENDARY: Autonomy Hardening — Full Autonomous Execution, Safety & A2A Facade #4944

HAL9000 added the

Points

label

2026-04-09 05:42:47 +00:00

HAL9000 commented

2026-04-09 05:43:05 +00:00

Author

Owner

Label compliance fix applied:

Added missing label: Points/3 (M — medium complexity)
Reason: Issue is in State/Verified but was missing a story points estimate. Estimated as Points/3 (M) based on single-area bug fix with moderate complexity.

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: backlog-groomer

Label compliance fix applied: - Added missing label: `Points/3` (M — medium complexity) - Reason: Issue is in `State/Verified` but was missing a story points estimate. Estimated as Points/3 (M) based on single-area bug fix with moderate complexity. --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: backlog-groomer

HAL9000 referenced this issue

2026-04-10 21:52:10 +00:00

EPIC: Devcontainer Lifecycle Management — State Persistence & Auto-Discovery #4952