cleveragents/cleveragents-core

Fork 3

UAT: `container-instance` resource type definition missing `--clone-into` CLI argument — ADR-043 specifies it as a CLI extension #4902

New issue

Open

opened 2026-04-08 20:17:49 +00:00 by HAL9000 · 2 comments

HAL9000 commented

2026-04-08 20:17:49 +00:00

Owner

Bug Report

Feature Area: Devcontainer Integration — Container-Project Association Patterns
ADR Reference: ADR-043 §Container-Instance CLI Argument Extensions
Severity: Medium (CLI argument not declared in resource type schema; inheritance chain incomplete)

What Was Tested

ADR-043 §Container-Instance CLI Argument Extensions specifies that container-instance gains new CLI arguments --mount and --clone-into. These should be declared in the resource type definition so they are inherited by devcontainer-instance via ADR-042 inheritance.

Expected Behavior (from ADR-043)

The existing container-instance resource type gains new CLI arguments for mount and clone operations:

Argument Type Required Description

--mount string (repeatable) No Mount specification...

--clone-into string (repeatable) No Clone specification...

These arguments are inherited by all subtypes of container-instance (including devcontainer-instance) via the resource type inheritance mechanism (ADR-042).

Argument	Type	Required	Description
`--mount`	string (repeatable)	No	Mount specification...
`--clone-into`	string (repeatable)	No	Clone specification...

Actual Behavior

In _resource_registry_data.py, the container-instance type definition includes mounts as a CLI arg but does not include clone_into:

# src/cleveragents/application/services/_resource_registry_data.py:194-226
"cli_args": [
    {"name": "image", ...},
    {"name": "container_id", ...},
    {"name": "mounts", ...},   # ✓ present
    # "clone_into" is MISSING from the type definition
],

The --clone-into flag is only implemented at the CLI command layer (src/cleveragents/cli/commands/resource.py:625-635) as a Typer option, but it is not declared in the resource type schema. This means:

devcontainer-instance does not inherit clone_into via the ADR-042 inheritance mechanism.
agents resource type show container-instance does not list --clone-into as a supported argument.
The resource type schema validation (ResourceTypeConfigSchema) cannot validate clone_into as a known argument for container-instance subtypes.

Code Locations

Missing from type definition: src/cleveragents/application/services/_resource_registry_data.py:194-226
CLI-only implementation: src/cleveragents/cli/commands/resource.py:625-635
ADR-043 spec: docs/adr/ADR-043-devcontainer-integration.md:374-381

Impact

agents resource type show container-instance does not show --clone-into as a supported argument, misleading users.
devcontainer-instance does not inherit clone_into through the type inheritance system.
Pattern 3 (Container with Remote Repo Clone) from ADR-043 is partially implemented but not properly declared in the type system.

Fix Required

Add clone_into to the container-instance CLI args in _resource_registry_data.py:

{
    "name": "clone_into",
    "type": "string",
    "required": False,
    "description": (
        "Clone specification in format <git-resource>:<container-path>. "
        "On activation, clones the referenced git resource into the container. "
        "Use --clone-into flag on the CLI."
    ),
    "default": None,
},

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** Devcontainer Integration — Container-Project Association Patterns **ADR Reference:** ADR-043 §Container-Instance CLI Argument Extensions **Severity:** Medium (CLI argument not declared in resource type schema; inheritance chain incomplete) --- ## What Was Tested ADR-043 §Container-Instance CLI Argument Extensions specifies that `container-instance` gains new CLI arguments `--mount` and `--clone-into`. These should be declared in the resource type definition so they are inherited by `devcontainer-instance` via ADR-042 inheritance. ## Expected Behavior (from ADR-043) > The existing `container-instance` resource type gains new CLI arguments for mount and clone operations: > > | Argument | Type | Required | Description | > |----------|------|----------|-------------| > | `--mount` | string (repeatable) | No | Mount specification... | > | `--clone-into` | string (repeatable) | No | Clone specification... | > > These arguments are **inherited** by all subtypes of `container-instance` (including `devcontainer-instance`) via the resource type inheritance mechanism (ADR-042). ## Actual Behavior In `_resource_registry_data.py`, the `container-instance` type definition includes `mounts` as a CLI arg but **does not include `clone_into`**: ```python # src/cleveragents/application/services/_resource_registry_data.py:194-226 "cli_args": [ {"name": "image", ...}, {"name": "container_id", ...}, {"name": "mounts", ...}, # ✓ present # "clone_into" is MISSING from the type definition ], ``` The `--clone-into` flag is only implemented at the CLI command layer (`src/cleveragents/cli/commands/resource.py:625-635`) as a Typer option, but it is **not declared in the resource type schema**. This means: 1. `devcontainer-instance` does not inherit `clone_into` via the ADR-042 inheritance mechanism. 2. `agents resource type show container-instance` does not list `--clone-into` as a supported argument. 3. The resource type schema validation (`ResourceTypeConfigSchema`) cannot validate `clone_into` as a known argument for `container-instance` subtypes. ## Code Locations - Missing from type definition: `src/cleveragents/application/services/_resource_registry_data.py:194-226` - CLI-only implementation: `src/cleveragents/cli/commands/resource.py:625-635` - ADR-043 spec: `docs/adr/ADR-043-devcontainer-integration.md:374-381` ## Impact - `agents resource type show container-instance` does not show `--clone-into` as a supported argument, misleading users. - `devcontainer-instance` does not inherit `clone_into` through the type inheritance system. - Pattern 3 (Container with Remote Repo Clone) from ADR-043 is partially implemented but not properly declared in the type system. ## Fix Required Add `clone_into` to the `container-instance` CLI args in `_resource_registry_data.py`: ```python { "name": "clone_into", "type": "string", "required": False, "description": ( "Clone specification in format <git-resource>:<container-path>. " "On activation, clones the referenced git resource into the container. " "Use --clone-into flag on the CLI." ), "default": None, }, ``` --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 20:19:48 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:22:25 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 added the

labels

2026-04-08 22:59:17 +00:00

freemo added

and removed

labels

2026-04-08 23:39:40 +00:00

freemo added this to the v3.5.0 milestone

2026-04-08 23:39:53 +00:00

freemo commented

2026-04-08 23:40:03 +00:00

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — container-instance resource type missing --clone-into CLI arg
Milestone: v3.5.0 — Container resource types are M6 scope
Story Points: 3 — M — Adding missing CLI argument to container-instance resource type
MoSCoW: Should Have — Container resource type completeness is important but not blocking core workflow
Parent Epic: #360 (Autonomy Hardening + Stubs M6)

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — container-instance resource type missing `--clone-into` CLI arg - **Milestone**: v3.5.0 — Container resource types are M6 scope - **Story Points**: 3 — M — Adding missing CLI argument to container-instance resource type - **MoSCoW**: Should Have — Container resource type completeness is important but not blocking core workflow - **Parent Epic**: #360 (Autonomy Hardening + Stubs M6) --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

freemo commented

2026-04-08 23:42:44 +00:00

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — Missing --clone-into CLI argument for container-instance; ADR-043 specifies it as a CLI extension
Milestone: v3.5.0 (Autonomy Hardening — devcontainer integration)
Story Points: 2 — S — Adding a CLI argument to an existing command is a small task
MoSCoW: Should Have — Complete CLI per ADR-043 is important for devcontainer workflows
Parent Epic: #4944 (Autonomy Hardening Legendary)

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — Missing `--clone-into` CLI argument for container-instance; ADR-043 specifies it as a CLI extension - **Milestone**: v3.5.0 (Autonomy Hardening — devcontainer integration) - **Story Points**: 2 — S — Adding a CLI argument to an existing command is a small task - **MoSCoW**: Should Have — Complete CLI per ADR-043 is important for devcontainer workflows - **Parent Epic**: #4944 (Autonomy Hardening Legendary) --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

freemo added

Points

and removed

Points

labels

2026-04-08 23:42:59 +00:00

freemo added a new dependency

2026-04-08 23:43:11 +00:00

#4944 LEGENDARY: Autonomy Hardening — Full Autonomous Execution, Safety & A2A Facade