cleveragents/cleveragents-core

Fork 3

UAT: `agents plan diff --correction` is a stub — returns placeholder text instead of actual correction diff #4898

New issue

Open

opened 2026-04-08 20:17:21 +00:00 by HAL9000 · 2 comments

HAL9000 commented

2026-04-08 20:17:21 +00:00

Owner

Bug Report

Feature Area: Correction Model — agents plan diff --correction
Severity: High (core correction workflow feature is non-functional)
Found by: UAT tester, code analysis
Spec reference: docs/specification.md §CLI Commands for Correction (line ~15525), §agents plan diff command

What Was Tested

The agents plan diff --correction <CORRECTION_ATTEMPT_ID> command was compared against the specification.

Expected Behavior (from spec)

The spec defines agents plan diff (--correction <CORRECTION_ATTEMPT_ID>|<PLAN_ID>) as:

Show diffs for a plan or a correction attempt.

--correction CORRECTION_ATTEMPT_ID: Show diff for a correction attempt instead.

The spec shows a full "Correction Diff" output panel:

$ agents plan diff --correction 01HXM9B7Z3Q1Q8K2E9H7K3W2M8

╭─ Correction Diff ───────────────────────────────╮
│ Correction: 01HXM9B7Z3Q1Q8K2E9H7K3W2M8          │
│ Plan: 01HXM8C2ZK4Q7C2B3F2R4VYV6J                │
│ Mode: revert                                     │
│ Target Decision: 01HXM9A1C2Q7W3R5G8Z0P4Q1X9     │
│ ...                                              │
╰──────────────────────────────────────────────────╯
✓ OK Correction diff generated

The JSON output should include a correction_diff object with the correction ID, plan, mode, target decision, and before/after comparison.

Actual Behavior

The implementation at src/cleveragents/cli/commands/plan.py lines 2949–2960 is a stub:

if correction:
    # Show correction-specific diff (stub: shows info panel)
    console.print(
        Panel(
            f"[bold]Correction Attempt:[/bold] {correction}\n"
            f"[bold]Plan:[/bold] {plan_id}\n\n"
            "[dim]Correction diff will be available after M4.2.[/dim]",
            title="Correction Diff",
            expand=False,
        )
    )
    return

The command outputs a placeholder message "Correction diff will be available after M4.2." and returns without computing any actual diff.

Code Location

src/cleveragents/cli/commands/plan.py, lines 2948–2960 (plan_diff function, if correction: branch)

Steps to Reproduce

agents plan diff --correction 01HXM9B7Z3Q1Q8K2E9H7K3W2M8 <PLAN_ID>

Expected: Actual diff showing what changed between original and corrected execution.
Actual: "Correction diff will be available after M4.2."

Impact

Users cannot compare before/after state of a correction
The agents plan diff --correction command is documented in the spec as a key correction workflow tool
The spec's "History" panel in agents plan correct output references agents plan diff --correction as the follow-up command

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** Correction Model — `agents plan diff --correction` **Severity:** High (core correction workflow feature is non-functional) **Found by:** UAT tester, code analysis **Spec reference:** `docs/specification.md` §CLI Commands for Correction (line ~15525), §`agents plan diff` command --- ### What Was Tested The `agents plan diff --correction <CORRECTION_ATTEMPT_ID>` command was compared against the specification. ### Expected Behavior (from spec) The spec defines `agents plan diff (--correction <CORRECTION_ATTEMPT_ID>|<PLAN_ID>)` as: > Show diffs for a plan or a correction attempt. > - `--correction CORRECTION_ATTEMPT_ID`: Show diff for a correction attempt instead. The spec shows a full "Correction Diff" output panel: ``` $ agents plan diff --correction 01HXM9B7Z3Q1Q8K2E9H7K3W2M8 ╭─ Correction Diff ───────────────────────────────╮ │ Correction: 01HXM9B7Z3Q1Q8K2E9H7K3W2M8 │ │ Plan: 01HXM8C2ZK4Q7C2B3F2R4VYV6J │ │ Mode: revert │ │ Target Decision: 01HXM9A1C2Q7W3R5G8Z0P4Q1X9 │ │ ... │ ╰──────────────────────────────────────────────────╯ ✓ OK Correction diff generated ``` The JSON output should include a `correction_diff` object with the correction ID, plan, mode, target decision, and before/after comparison. ### Actual Behavior The implementation at `src/cleveragents/cli/commands/plan.py` lines 2949–2960 is a stub: ```python if correction: # Show correction-specific diff (stub: shows info panel) console.print( Panel( f"[bold]Correction Attempt:[/bold] {correction}\n" f"[bold]Plan:[/bold] {plan_id}\n\n" "[dim]Correction diff will be available after M4.2.[/dim]", title="Correction Diff", expand=False, ) ) return ``` The command outputs a placeholder message "Correction diff will be available after M4.2." and returns without computing any actual diff. ### Code Location - `src/cleveragents/cli/commands/plan.py`, lines 2948–2960 (`plan_diff` function, `if correction:` branch) ### Steps to Reproduce ```bash agents plan diff --correction 01HXM9B7Z3Q1Q8K2E9H7K3W2M8 <PLAN_ID> ``` Expected: Actual diff showing what changed between original and corrected execution. Actual: "Correction diff will be available after M4.2." ### Impact - Users cannot compare before/after state of a correction - The `agents plan diff --correction` command is documented in the spec as a key correction workflow tool - The spec's "History" panel in `agents plan correct` output references `agents plan diff --correction` as the follow-up command --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 20:20:23 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:22:25 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 added this to the v3.4.0 milestone

2026-04-08 20:25:48 +00:00

HAL9000 added the

labels

2026-04-08 22:59:22 +00:00

freemo added

and removed

labels

2026-04-08 23:40:16 +00:00

freemo commented

2026-04-08 23:40:39 +00:00

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — agents plan diff --correction is a stub returning placeholder text
Milestone: v3.4.0 — Plan diff with correction is M5 scope (already assigned)
Story Points: 3 — M — Implementing real correction diff output
MoSCoW: Should Have — Correction diff is useful but not blocking core plan execution
Parent Epic: #359 (ACMS v1 + Context Scaling M5)

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — `agents plan diff --correction` is a stub returning placeholder text - **Milestone**: v3.4.0 — Plan diff with correction is M5 scope (already assigned) - **Story Points**: 3 — M — Implementing real correction diff output - **MoSCoW**: Should Have — Correction diff is useful but not blocking core plan execution - **Parent Epic**: #359 (ACMS v1 + Context Scaling M5) --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

freemo commented

2026-04-08 23:41:24 +00:00

Owner

Issue triaged by project owner:

State: Verified
Priority: High — agents plan diff --correction is a stub returning placeholder text; core correction workflow feature non-functional
Milestone: v3.4.0 (already assigned correctly — ACMS v1 + Context Scaling)
Story Points: 5 — L — Implementing actual correction diff generation requires integrating with CorrectionService
MoSCoW: Must Have — Correction diff is a core feature of the correction model per spec
Parent Epic: #4942 (Decision Intelligence Legendary)

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: High — `agents plan diff --correction` is a stub returning placeholder text; core correction workflow feature non-functional - **Milestone**: v3.4.0 (already assigned correctly — ACMS v1 + Context Scaling) - **Story Points**: 5 — L — Implementing actual correction diff generation requires integrating with CorrectionService - **MoSCoW**: Must Have — Correction diff is a core feature of the correction model per spec - **Parent Epic**: #4942 (Decision Intelligence Legendary) --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

freemo added

and removed

labels

2026-04-08 23:41:48 +00:00