cleveragents/cleveragents-core

Fork 3

UAT: `sandbox.checkpoint.auto-create-on` config key registered under wrong path `core.checkpoints.auto_create_on` in ConfigService #4890

New issue

Open

opened 2026-04-08 20:16:11 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-08 20:16:11 +00:00

Owner

Bug Report

Feature Area: Configuration System — Global Configuration Keys
Severity: Medium — agents config set sandbox.checkpoint.auto-create-on fails with "Unknown configuration key"
Found by: UAT tester, code analysis

What Was Tested

The sandbox.checkpoint.auto-create-on global configuration key was compared against the spec and the ConfigService._build_catalog() implementation.

Expected Behavior (from spec)

Per docs/specification.md §Global Configuration Keys, sandbox.* section (line 30722):

| `sandbox.checkpoint.auto-create-on` | list | `["on_tool_write", "on_tool_write_complete", "on_subplan_spawn", "on_error"]` | `CLEVERAGENTS_CHECKPOINT_AUTO_CREATE_ON` | List of automatic checkpoint triggers. ...

The key should be registered as sandbox.checkpoint.auto-create-on under the sandbox section.

Also referenced at line 19449:

The execution engine supports four automatic checkpoint triggers, configurable via `core.checkpoints.auto_create_on`...

(Note: line 19449 uses an older internal name; the canonical spec key at line 30722 is sandbox.checkpoint.auto-create-on.)

Actual Behavior

In src/cleveragents/application/services/config_service.py, _build_catalog() (lines 481–493), the key is registered under the wrong section and with a non-spec-compliant name:

_register(
    "core",                          # ← Wrong section: should be "sandbox"
    "checkpoints.auto_create_on",    # ← Wrong name: should be "checkpoint.auto-create-on"
    str,
    "before_tool_execute,after_tool_execute,on_subplan_spawn,on_error",
    project_scopable=True,
    env_var="CLEVERAGENTS_CHECKPOINT_AUTO_CREATE_ON",
    ...
)

This registers the key as core.checkpoints.auto_create_on instead of sandbox.checkpoint.auto-create-on.

Additionally, the default value uses different trigger names:

Registered: "before_tool_execute,after_tool_execute,on_subplan_spawn,on_error"
Spec: ["on_tool_write", "on_tool_write_complete", "on_subplan_spawn", "on_error"]

Code Location

src/cleveragents/application/services/config_service.py, lines 481–493 (_build_catalog())

Steps to Reproduce

# This fails with "Unknown configuration key"
agents config set sandbox.checkpoint.auto-create-on '["on_tool_write", "on_subplan_spawn"]'

# This incorrectly succeeds (wrong key path)
agents config set core.checkpoints.auto_create_on "on_tool_write,on_subplan_spawn"

Impact

agents config set sandbox.checkpoint.auto-create-on fails for users following the spec
agents config list sandbox.* does not include the auto-create-on key
Default trigger names differ from spec (before_tool_execute vs on_tool_write, after_tool_execute vs on_tool_write_complete)
The key is also incorrectly placed in the core.* group instead of sandbox.*

Definition of Done

Key registered as sandbox.checkpoint.auto-create-on (section: sandbox, name: checkpoint.auto-create-on)
Default value matches spec: ["on_tool_write", "on_tool_write_complete", "on_subplan_spawn", "on_error"]
agents config set sandbox.checkpoint.auto-create-on works correctly
agents config list sandbox.* includes the key

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** Configuration System — Global Configuration Keys **Severity:** Medium — `agents config set sandbox.checkpoint.auto-create-on` fails with "Unknown configuration key" **Found by:** UAT tester, code analysis --- ### What Was Tested The `sandbox.checkpoint.auto-create-on` global configuration key was compared against the spec and the `ConfigService._build_catalog()` implementation. ### Expected Behavior (from spec) Per `docs/specification.md` §Global Configuration Keys, `sandbox.*` section (line 30722): ``` | `sandbox.checkpoint.auto-create-on` | list | `["on_tool_write", "on_tool_write_complete", "on_subplan_spawn", "on_error"]` | `CLEVERAGENTS_CHECKPOINT_AUTO_CREATE_ON` | List of automatic checkpoint triggers. ... ``` The key should be registered as `sandbox.checkpoint.auto-create-on` under the `sandbox` section. Also referenced at line 19449: ``` The execution engine supports four automatic checkpoint triggers, configurable via `core.checkpoints.auto_create_on`... ``` (Note: line 19449 uses an older internal name; the canonical spec key at line 30722 is `sandbox.checkpoint.auto-create-on`.) ### Actual Behavior In `src/cleveragents/application/services/config_service.py`, `_build_catalog()` (lines 481–493), the key is registered under the wrong section and with a non-spec-compliant name: ```python _register( "core", # ← Wrong section: should be "sandbox" "checkpoints.auto_create_on", # ← Wrong name: should be "checkpoint.auto-create-on" str, "before_tool_execute,after_tool_execute,on_subplan_spawn,on_error", project_scopable=True, env_var="CLEVERAGENTS_CHECKPOINT_AUTO_CREATE_ON", ... ) ``` This registers the key as `core.checkpoints.auto_create_on` instead of `sandbox.checkpoint.auto-create-on`. Additionally, the default value uses different trigger names: - **Registered**: `"before_tool_execute,after_tool_execute,on_subplan_spawn,on_error"` - **Spec**: `["on_tool_write", "on_tool_write_complete", "on_subplan_spawn", "on_error"]` ### Code Location `src/cleveragents/application/services/config_service.py`, lines 481–493 (`_build_catalog()`) ### Steps to Reproduce ```bash # This fails with "Unknown configuration key" agents config set sandbox.checkpoint.auto-create-on '["on_tool_write", "on_subplan_spawn"]' # This incorrectly succeeds (wrong key path) agents config set core.checkpoints.auto_create_on "on_tool_write,on_subplan_spawn" ``` ### Impact - `agents config set sandbox.checkpoint.auto-create-on` fails for users following the spec - `agents config list sandbox.*` does not include the auto-create-on key - Default trigger names differ from spec (`before_tool_execute` vs `on_tool_write`, `after_tool_execute` vs `on_tool_write_complete`) - The key is also incorrectly placed in the `core.*` group instead of `sandbox.*` ### Definition of Done - [ ] Key registered as `sandbox.checkpoint.auto-create-on` (section: `sandbox`, name: `checkpoint.auto-create-on`) - [ ] Default value matches spec: `["on_tool_write", "on_tool_write_complete", "on_subplan_spawn", "on_error"]` - [ ] `agents config set sandbox.checkpoint.auto-create-on` works correctly - [ ] `agents config list sandbox.*` includes the key --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 20:17:10 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:19:44 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:22:25 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 added the

labels

2026-04-08 22:59:23 +00:00

freemo added

and removed

labels

2026-04-08 23:41:59 +00:00

freemo added this to the v3.5.0 milestone

2026-04-08 23:42:15 +00:00

freemo commented

2026-04-08 23:42:57 +00:00

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — sandbox.checkpoint.auto-create-on config key registered under wrong path
Milestone: v3.5.0 — Sandbox checkpoint config is M6 scope
Story Points: 3 — M — Fixing config key registration path
MoSCoW: Should Have — Config key correctness is important for proper configuration
Parent Epic: #360 (Autonomy Hardening + Stubs M6)

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — `sandbox.checkpoint.auto-create-on` config key registered under wrong path - **Milestone**: v3.5.0 — Sandbox checkpoint config is M6 scope - **Story Points**: 3 — M — Fixing config key registration path - **MoSCoW**: Should Have — Config key correctness is important for proper configuration - **Parent Epic**: #360 (Autonomy Hardening + Stubs M6) --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 referenced this issue

2026-04-09 00:46:17 +00:00

Proposal: update specification — checkpoint trigger names and config key path inconsistency #5009

HAL9000 referenced this issue

2026-04-09 00:47:14 +00:00

[AUTO-SPEC] Specification Update Report (Cycle 1) #5010