UAT: TUI PermissionQuestionWidget missing v key handler to open PermissionsScreenopen_full_screen flag set but never acted upon by host app #4868

Open
opened 2026-04-08 20:10:44 +00:00 by HAL9000 · 0 comments
Owner

Bug Report

Feature Area: TUI Interface — Inline Permission Question Widget (ADR-044)

What Was Tested

PermissionQuestionWidget in src/cleveragents/tui/widgets/permission_question.py and its integration with app.py.

Expected Behavior (from spec ADR-044)

The spec states:

"Press v to open the full PermissionsScreen for multi-file diff review."

When the user presses v in the PermissionQuestionWidget, the full PermissionsScreen should be pushed onto the Textual screen stack.

Actual Behavior

PermissionQuestionWidget.handle_key("v") sets self._open_full_screen = True and returns None:

if key == "v":
    self._open_full_screen = True
    return None

However:

  1. The open_full_screen flag is a property on the widget, but no event is emitted to notify the host application
  2. app.py has no handler for PermissionQuestionWidget events or the open_full_screen flag
  3. PermissionsScreen is a Static widget (not a proper Screen) and cannot be pushed anyway (see related bug #4851)

The docstring acknowledges this: "the host application should listen for the open_full_screen flag" — but no such listener exists in app.py.

Code Location

  • src/cleveragents/tui/widgets/permission_question.pyhandle_key("v") sets flag but emits no event
  • src/cleveragents/tui/app.py — no handler for PermissionQuestionWidget events

Steps to Reproduce

  1. Trigger a single-file permission request (inline widget appears)
  2. Press v
  3. Observe: nothing happens — PermissionsScreen is not shown

Impact

Users cannot view the full diff for permission requests. The v key shortcut is non-functional.


Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** TUI Interface — Inline Permission Question Widget (ADR-044) ### What Was Tested `PermissionQuestionWidget` in `src/cleveragents/tui/widgets/permission_question.py` and its integration with `app.py`. ### Expected Behavior (from spec ADR-044) The spec states: > "Press `v` to open the full `PermissionsScreen` for multi-file diff review." When the user presses `v` in the `PermissionQuestionWidget`, the full `PermissionsScreen` should be pushed onto the Textual screen stack. ### Actual Behavior `PermissionQuestionWidget.handle_key("v")` sets `self._open_full_screen = True` and returns `None`: ```python if key == "v": self._open_full_screen = True return None ``` However: 1. The `open_full_screen` flag is a property on the widget, but **no event is emitted** to notify the host application 2. `app.py` has **no handler** for `PermissionQuestionWidget` events or the `open_full_screen` flag 3. `PermissionsScreen` is a `Static` widget (not a proper `Screen`) and cannot be pushed anyway (see related bug #4851) The docstring acknowledges this: "the host application should listen for the `open_full_screen` flag" — but no such listener exists in `app.py`. ### Code Location - `src/cleveragents/tui/widgets/permission_question.py` — `handle_key("v")` sets flag but emits no event - `src/cleveragents/tui/app.py` — no handler for `PermissionQuestionWidget` events ### Steps to Reproduce 1. Trigger a single-file permission request (inline widget appears) 2. Press `v` 3. Observe: nothing happens — `PermissionsScreen` is not shown ### Impact Users cannot view the full diff for permission requests. The `v` key shortcut is non-functional. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester
HAL9000 added this to the v3.7.0 milestone 2026-04-08 20:15:30 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
cleveragents/cleveragents-core#4868
No description provided.