UAT: TUI ThoughtBlockWidget max-height CSS uses 10 lines (collapsed) but spec requires max-height 10 lines — expanded state has no max-height cap #4865

Open
opened 2026-04-08 20:10:25 +00:00 by HAL9000 · 0 comments
Owner

Bug Report

Feature Area: TUI Interface — Conversation Stream (ADR-044)

What Was Tested

ThoughtBlockWidget in src/cleveragents/tui/widgets/thought_block.py

Expected Behavior (from spec ADR-044)

The spec defines ActorThought blocks as:

"$primary-muted 20% background, max-height 10 lines (expandable), italic"

The max-height of 10 lines applies to the collapsed state. When expanded, the full content should be visible.

Actual Behavior

The DEFAULT_CSS in ThoughtBlockWidget defines:

DEFAULT_CSS = """
ThoughtBlockWidget {
    background: $primary-muted 20%;
    color: $text-muted;
    border: solid $primary 30%;
    padding: 0 1;
    margin: 0 0 1 0;
}
ThoughtBlockWidget.thought-block--expanded {
    max-height: 100vh;
}
ThoughtBlockWidget.thought-block--collapsed {
    max-height: 10;
}
"""

Issues found:

  1. max-height: 10 — In Textual CSS, 10 without a unit is interpreted as 10 cells (rows), which is correct. However, the spec says "10 lines" which should be 10 rows. This is actually correct.
  2. Missing italic styling — The spec requires italic text for thought blocks, but there is no text-style: italic in the CSS.
  3. border: solid $primary 30% — The spec does not mention a border on thought blocks. The spec only mentions $primary-muted 20% background. The border adds visual noise not specified.

Code Location

src/cleveragents/tui/widgets/thought_block.pyDEFAULT_CSS class variable

Steps to Reproduce

  1. Trigger an actor thought block in the conversation
  2. Observe: text is not italic
  3. Observe: a border appears around the thought block (not in spec)

Impact

Minor visual deviation from spec. The thought block is functional but does not match the specified styling.


Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** TUI Interface — Conversation Stream (ADR-044) ### What Was Tested `ThoughtBlockWidget` in `src/cleveragents/tui/widgets/thought_block.py` ### Expected Behavior (from spec ADR-044) The spec defines `ActorThought` blocks as: > "`$primary-muted` 20% background, **max-height 10 lines** (expandable), italic" The max-height of 10 lines applies to the **collapsed** state. When expanded, the full content should be visible. ### Actual Behavior The `DEFAULT_CSS` in `ThoughtBlockWidget` defines: ```python DEFAULT_CSS = """ ThoughtBlockWidget { background: $primary-muted 20%; color: $text-muted; border: solid $primary 30%; padding: 0 1; margin: 0 0 1 0; } ThoughtBlockWidget.thought-block--expanded { max-height: 100vh; } ThoughtBlockWidget.thought-block--collapsed { max-height: 10; } """ ``` Issues found: 1. **`max-height: 10`** — In Textual CSS, `10` without a unit is interpreted as 10 cells (rows), which is correct. However, the spec says "10 lines" which should be `10` rows. This is actually correct. 2. **Missing `italic` styling** — The spec requires italic text for thought blocks, but there is no `text-style: italic` in the CSS. 3. **`border: solid $primary 30%`** — The spec does not mention a border on thought blocks. The spec only mentions `$primary-muted 20% background`. The border adds visual noise not specified. ### Code Location `src/cleveragents/tui/widgets/thought_block.py` — `DEFAULT_CSS` class variable ### Steps to Reproduce 1. Trigger an actor thought block in the conversation 2. Observe: text is not italic 3. Observe: a border appears around the thought block (not in spec) ### Impact Minor visual deviation from spec. The thought block is functional but does not match the specified styling. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester
HAL9000 added this to the v3.7.0 milestone 2026-04-08 20:15:20 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
cleveragents/cleveragents-core#4865
No description provided.