cleveragents/cleveragents-core

Fork 3

UAT: `agents plan diff` signature deviates from spec — `PLAN_ID` is required positional but spec defines it as mutually exclusive with `--correction` #4863

New issue

Open

opened 2026-04-08 20:10:16 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-08 20:10:16 +00:00

Owner

Bug Report

Feature Area: CLI Commands — agents plan diff

What Was Tested

Code-level analysis of src/cleveragents/cli/commands/plan.py (plan_diff function) against the specification's agents plan diff command signature (spec line 343).

Expected Behavior (from spec)

The spec defines agents plan diff with a mutually exclusive argument structure:

agents plan diff (--correction <CORRECTION_ATTEMPT_ID>|<PLAN_ID>)

This means:

Either provide <PLAN_ID> as a positional argument (to show the full plan diff)
OR provide --correction <CORRECTION_ATTEMPT_ID> (to show a correction attempt diff)
The two are mutually exclusive — you cannot provide both

The spec also says (line 15332): "<PLAN_ID>: Show diff for a plan (positional argument). Mutually exclusive with --correction."

Actual Behavior

The implementation makes PLAN_ID a required positional argument and --correction an optional flag:

Usage: python -m cleveragents plan diff [OPTIONS] PLAN_ID

Arguments:
  *    plan_id      TEXT  Plan ID to show diff for [required]

Options:
  --correction          TEXT  Show diff for a specific correction attempt ID

This means:

agents plan diff --correction <CORRECTION_ID> fails because PLAN_ID is required — you must always provide a plan ID even when using --correction
The spec's intent (either plan ID or correction ID, not both) is not enforced
agents plan diff --correction <CORRECTION_ID> <PLAN_ID> accepts both, which the spec says should be invalid

Code Location

src/cleveragents/cli/commands/plan.py — plan_diff function (line 2918)

Steps to Reproduce

# This should work per spec but fails because PLAN_ID is required:
agents plan diff --correction 01HXM9B7Z3Q1Q8K2E9H7K3W2M8

# Error: Missing argument 'PLAN_ID'

Expected Fix

The command should accept either:

agents plan diff <PLAN_ID> (positional only)
agents plan diff --correction <CORRECTION_ATTEMPT_ID> (flag only, no positional)

And should reject providing both simultaneously.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** CLI Commands — `agents plan diff` ### What Was Tested Code-level analysis of `src/cleveragents/cli/commands/plan.py` (`plan_diff` function) against the specification's `agents plan diff` command signature (spec line 343). ### Expected Behavior (from spec) The spec defines `agents plan diff` with a **mutually exclusive** argument structure: ``` agents plan diff (--correction <CORRECTION_ATTEMPT_ID>|<PLAN_ID>) ``` This means: - Either provide `<PLAN_ID>` as a positional argument (to show the full plan diff) - **OR** provide `--correction <CORRECTION_ATTEMPT_ID>` (to show a correction attempt diff) - The two are mutually exclusive — you cannot provide both The spec also says (line 15332): "`<PLAN_ID>`: Show diff for a plan (positional argument). **Mutually exclusive with --correction**." ### Actual Behavior The implementation makes `PLAN_ID` a **required** positional argument and `--correction` an **optional** flag: ``` Usage: python -m cleveragents plan diff [OPTIONS] PLAN_ID Arguments: * plan_id TEXT Plan ID to show diff for [required] Options: --correction TEXT Show diff for a specific correction attempt ID ``` This means: 1. `agents plan diff --correction <CORRECTION_ID>` **fails** because `PLAN_ID` is required — you must always provide a plan ID even when using `--correction` 2. The spec's intent (either plan ID or correction ID, not both) is not enforced 3. `agents plan diff --correction <CORRECTION_ID> <PLAN_ID>` accepts both, which the spec says should be invalid ### Code Location - `src/cleveragents/cli/commands/plan.py` — `plan_diff` function (line 2918) ### Steps to Reproduce ```bash # This should work per spec but fails because PLAN_ID is required: agents plan diff --correction 01HXM9B7Z3Q1Q8K2E9H7K3W2M8 # Error: Missing argument 'PLAN_ID' ``` ### Expected Fix The command should accept either: - `agents plan diff <PLAN_ID>` (positional only) - `agents plan diff --correction <CORRECTION_ATTEMPT_ID>` (flag only, no positional) And should reject providing both simultaneously. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 20:11:41 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:16:04 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 added this to the v3.3.0 milestone

2026-04-08 20:17:13 +00:00

HAL9000 referenced this issue

2026-04-08 20:19:20 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:22:25 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 added the

labels

2026-04-08 22:59:43 +00:00

freemo commented

2026-04-08 23:41:27 +00:00

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — agents plan diff signature deviates from spec; PLAN_ID should be mutually exclusive with --correction
Milestone: v3.3.0 (Corrections + Subplans + Checkpoints)
Story Points: 2 — S — Fixing CLI argument mutual exclusion is a small task
MoSCoW: Should Have — Correct CLI interface per spec is important for usability and spec compliance
Parent Epic: #4942 (Decision Intelligence Legendary)

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — `agents plan diff` signature deviates from spec; PLAN_ID should be mutually exclusive with `--correction` - **Milestone**: v3.3.0 (Corrections + Subplans + Checkpoints) - **Story Points**: 2 — S — Fixing CLI argument mutual exclusion is a small task - **MoSCoW**: Should Have — Correct CLI interface per spec is important for usability and spec compliance - **Parent Epic**: #4942 (Decision Intelligence Legendary) --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

freemo added

and removed

labels

2026-04-08 23:41:50 +00:00

freemo added a new dependency

2026-04-08 23:42:05 +00:00

#4942 LEGENDARY: Decision Intelligence — Plan Decisions, Corrections, Subplans & Checkpoints