UAT: `AutomationProfileService._DEFAULT_PROFILE` hardcoded as `manual` — spec requires `supervised` (ADR-017) or `review` (reference docs) #4853

New issue

Open

opened 2026-04-08 20:09:09 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-08 20:09:09 +00:00

Owner

Summary

AutomationProfileService._DEFAULT_PROFILE is hardcoded as "manual" in src/cleveragents/application/services/automation_profile_service.py, but the specification documents disagree on what the default should be — and neither says manual.

What Was Tested

Code-level analysis of AutomationProfileService against ADR-017 and docs/reference/automation_profiles.md.

Expected Behavior (from spec)

ADR-017 (docs/adr/ADR-017-automation-profiles.md) states:

"The default global profile is supervised (configurable via core.automation-profile)."

Reference docs (docs/reference/automation_profiles.md) state:

"4. System default — Falls back to the review built-in profile."

Both spec documents agree that the default is NOT manual.

Actual Behavior (from code)

# src/cleveragents/application/services/automation_profile_service.py
_DEFAULT_PROFILE = "manual"

The effective_global_default property falls back to "manual" when no explicit config or env var is set:

@property
def effective_global_default(self) -> str:
    if self._global_default:
        return self._global_default
    env_val = os.environ.get(_ENV_VAR)
    if env_val:
        return env_val
    return _DEFAULT_PROFILE  # returns "manual"

Impact

This is a critical behavioral discrepancy. The manual profile requires human approval for every single action (all thresholds = 1.0). Using it as the default means new installations are maximally restrictive by default, which is inconsistent with the spec's intent.

ADR-017 says supervised (human reviews strategy and execution, auto for decompose)
Reference docs say review (auto-strategize, human reviews before execute and apply)
Code says manual (human approves everything)

Additionally, there is an internal inconsistency between the two spec documents (ADR-017 says supervised, reference docs say review). This inconsistency should also be resolved.

Code Location

src/cleveragents/application/services/automation_profile_service.py, line with _DEFAULT_PROFILE = "manual"

Steps to Reproduce

Instantiate AutomationProfileService() with no arguments
Call service.effective_global_default
Observe it returns "manual" instead of "supervised" or "review"

Definition of Done

_DEFAULT_PROFILE is updated to match the spec (either supervised per ADR-017 or review per reference docs — the spec documents must first be reconciled)
The inconsistency between ADR-017 and reference docs is resolved (one document updated to match the other)
Tests verify the correct default is used when no config or env var is set

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Summary `AutomationProfileService._DEFAULT_PROFILE` is hardcoded as `"manual"` in `src/cleveragents/application/services/automation_profile_service.py`, but the specification documents disagree on what the default should be — and neither says `manual`. ## What Was Tested Code-level analysis of `AutomationProfileService` against ADR-017 and `docs/reference/automation_profiles.md`. ## Expected Behavior (from spec) **ADR-017** (`docs/adr/ADR-017-automation-profiles.md`) states: > "The default global profile is `supervised` (configurable via `core.automation-profile`)." **Reference docs** (`docs/reference/automation_profiles.md`) state: > "4. **System default** — Falls back to the `review` built-in profile." Both spec documents agree that the default is NOT `manual`. ## Actual Behavior (from code) ```python # src/cleveragents/application/services/automation_profile_service.py _DEFAULT_PROFILE = "manual" ``` The `effective_global_default` property falls back to `"manual"` when no explicit config or env var is set: ```python @property def effective_global_default(self) -> str: if self._global_default: return self._global_default env_val = os.environ.get(_ENV_VAR) if env_val: return env_val return _DEFAULT_PROFILE # returns "manual" ``` ## Impact This is a **critical behavioral discrepancy**. The `manual` profile requires human approval for every single action (all thresholds = 1.0). Using it as the default means new installations are maximally restrictive by default, which is inconsistent with the spec's intent. - ADR-017 says `supervised` (human reviews strategy and execution, auto for decompose) - Reference docs say `review` (auto-strategize, human reviews before execute and apply) - Code says `manual` (human approves everything) Additionally, there is an internal inconsistency between the two spec documents (ADR-017 says `supervised`, reference docs say `review`). This inconsistency should also be resolved. ## Code Location - `src/cleveragents/application/services/automation_profile_service.py`, line with `_DEFAULT_PROFILE = "manual"` ## Steps to Reproduce 1. Instantiate `AutomationProfileService()` with no arguments 2. Call `service.effective_global_default` 3. Observe it returns `"manual"` instead of `"supervised"` or `"review"` ## Definition of Done - [ ] `_DEFAULT_PROFILE` is updated to match the spec (either `supervised` per ADR-017 or `review` per reference docs — the spec documents must first be reconciled) - [ ] The inconsistency between ADR-017 and reference docs is resolved (one document updated to match the other) - [ ] Tests verify the correct default is used when no config or env var is set --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 20:10:40 +00:00

UAT: docs/reference/automation_profiles.md resolution precedence omits "action" level — inconsistent with ADR-017 and code #4867

HAL9000 referenced this issue

2026-04-08 20:11:32 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:12:39 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:16:04 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799