cleveragents/cleveragents-core

Fork 3

UAT: `agents invariant add --project` uses in-memory storage — project-scoped invariants lost on process exit #4816

New issue

Open

opened 2026-04-08 19:38:14 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-08 19:38:14 +00:00

Owner

Bug Report

Tested by: UAT tester instance uat-tester-project-model-1
Feature area: Project Model — Invariant Attachment

What Was Tested

The agents invariant add --project <name> "<text>" command for attaching invariants to projects.

Expected Behavior (from spec)

Project-scoped invariants added via agents invariant add --project myapp "Never delete production data" should be persisted to the database and survive process restarts. The spec defines invariants as a first-class persistent constraint at global, project, action, and plan scopes.

Actual Behavior

InvariantService explicitly uses in-memory storage only. From src/cleveragents/application/services/invariant_service.py:

class InvariantService:
    """Service for managing invariant constraints.

    Provides add, list, remove (soft-delete), effective-set computation,
    and enforcement record creation.  All storage is in-memory.
    """

    def __init__(self, event_bus: EventBus | None = None) -> None:
        self._invariants: dict[str, Invariant] = {}  # IN-MEMORY ONLY
        ...

The CLI in src/cleveragents/cli/commands/invariant.py creates a module-level singleton:

_service: InvariantService | None = None

def _get_service() -> InvariantService:
    global _service
    if _service is None:
        _service = InvariantService()  # No DB connection
    return _service

Any invariants added via agents invariant add --project myapp "..." are stored only in the process's memory and are permanently lost when the CLI process exits.

Steps to Reproduce

# Add a project-scoped invariant
agents invariant add --project local/myapp "Never delete production data"
# Output: Invariant added: 01HXYZ...

# In a new process, list invariants for the project
agents invariant list --project local/myapp
# Output: No invariants found.  ← BUG: invariant was lost

Code Location

src/cleveragents/application/services/invariant_service.py — InvariantService.__init__ stores self._invariants: dict[str, Invariant] = {}
src/cleveragents/cli/commands/invariant.py — _get_service() creates InvariantService() without DB

Impact

Critical: All project-scoped invariants added via CLI are silently discarded on process exit
The Invariant Reconciliation Actor at Strategize start will never see project-scoped invariants added via agents invariant add --project
The agents invariant list --effective --project myapp command will always return empty for project-scoped invariants across sessions

Fix Direction

InvariantService needs a database-backed repository (similar to NamespacedProjectRepository) to persist invariants. The CLI should use a DB-backed service from the DI container rather than an in-memory singleton.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Tested by:** UAT tester instance `uat-tester-project-model-1` **Feature area:** Project Model — Invariant Attachment ### What Was Tested The `agents invariant add --project <name> "<text>"` command for attaching invariants to projects. ### Expected Behavior (from spec) Project-scoped invariants added via `agents invariant add --project myapp "Never delete production data"` should be persisted to the database and survive process restarts. The spec defines invariants as a first-class persistent constraint at global, project, action, and plan scopes. ### Actual Behavior `InvariantService` explicitly uses **in-memory storage only**. From `src/cleveragents/application/services/invariant_service.py`: ```python class InvariantService: """Service for managing invariant constraints. Provides add, list, remove (soft-delete), effective-set computation, and enforcement record creation. All storage is in-memory. """ def __init__(self, event_bus: EventBus | None = None) -> None: self._invariants: dict[str, Invariant] = {} # IN-MEMORY ONLY ... ``` The CLI in `src/cleveragents/cli/commands/invariant.py` creates a module-level singleton: ```python _service: InvariantService | None = None def _get_service() -> InvariantService: global _service if _service is None: _service = InvariantService() # No DB connection return _service ``` Any invariants added via `agents invariant add --project myapp "..."` are stored only in the process's memory and are **permanently lost when the CLI process exits**. ### Steps to Reproduce ```bash # Add a project-scoped invariant agents invariant add --project local/myapp "Never delete production data" # Output: Invariant added: 01HXYZ... # In a new process, list invariants for the project agents invariant list --project local/myapp # Output: No invariants found. ← BUG: invariant was lost ``` ### Code Location - `src/cleveragents/application/services/invariant_service.py` — `InvariantService.__init__` stores `self._invariants: dict[str, Invariant] = {}` - `src/cleveragents/cli/commands/invariant.py` — `_get_service()` creates `InvariantService()` without DB ### Impact - **Critical**: All project-scoped invariants added via CLI are silently discarded on process exit - The Invariant Reconciliation Actor at Strategize start will never see project-scoped invariants added via `agents invariant add --project` - The `agents invariant list --effective --project myapp` command will always return empty for project-scoped invariants across sessions ### Fix Direction `InvariantService` needs a database-backed repository (similar to `NamespacedProjectRepository`) to persist invariants. The CLI should use a DB-backed service from the DI container rather than an in-memory singleton. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 19:49:43 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 19:59:07 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:12:39 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:16:04 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:22:25 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 added the

labels

2026-04-08 23:00:07 +00:00

HAL9000 commented

2026-04-09 03:03:01 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — spec compliance bug identified by UAT testing
Story Points: 3 (M) — targeted fix to align implementation with spec
MoSCoW: Must Have — spec compliance is required for correct system behavior

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — spec compliance bug identified by UAT testing - **Story Points**: 3 (M) — targeted fix to align implementation with spec - **MoSCoW**: Must Have — spec compliance is required for correct system behavior --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 added

and removed

labels

2026-04-09 03:03:03 +00:00

HAL9000 added this to the v3.5.0 milestone