cleveragents/cleveragents-core

Fork 3

UAT: `ActorConfigSchema.validate_name()` rejects valid three-part `server:namespace/name` actor names #4810

New issue

Open

opened 2026-04-08 19:33:22 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-08 19:33:22 +00:00

Owner

Bug Report

Feature Area: Actor YAML configuration schema — actor namespacing
Severity: High — actors with server-qualified names cannot be registered or loaded
Found by: UAT tester instance uat-tester-actor-system
Spec reference: docs/specification.md §Actor Naming (line 155, 20127–20135)

What Was Tested

Code-level analysis of src/cleveragents/actor/schema.py — ActorConfigSchema.validate_name() (lines 776–800) against the spec's actor namespacing requirements.

Expected Behavior (from spec)

The spec (line 155) defines actors as:

A YAML-configured conversational unit — either a single LLM/agent or a composed LangGraph of actors and tool nodes. Namespaced as [[server:]namespace/]name.

The spec also defines (line 174):

Namespace: The scoping segment in the name format [[server:]namespace/]name. Defaults to local/ when omitted.

The full three-part format server:namespace/name (e.g., myserver:local/my-actor) is a valid actor name per the spec.

Actual Behavior (from code)

ActorConfigSchema.validate_name() at src/cleveragents/actor/schema.py:776–800:

@field_validator("name")
@classmethod
def validate_name(cls, v: str) -> str:
    """Ensure actor name follows namespace/name format."""
    if "/" not in v:
        msg = f"Actor name must be namespaced (namespace/name): {v}"
        raise ValueError(msg)

    # Check for exactly one slash
    parts = v.split("/")
    if len(parts) != 2:  # ← BUG: rejects "server:namespace/name"
        msg = (
            f"Actor name must be namespaced with exactly one slash "
            f"(namespace/name): {v}"
        )
        raise ValueError(msg)
    ...

The validator requires exactly one slash, which means:

local/my-actor ✅ accepted
myserver:local/my-actor ❌ rejected (has one slash but parts = ["myserver:local", "my-actor"] — wait, actually this would pass the len(parts) != 2 check)

Wait — re-examining: "myserver:local/my-actor".split("/") = ["myserver:local", "my-actor"] — this has 2 parts and would pass. However, the validator does NOT validate the server:namespace prefix format at all. The real issue is:

The validator does not support the full [[server:]namespace/]name format — it only validates namespace/name (two parts separated by a single slash). It does not:

Parse or validate the optional server: prefix in the namespace segment
Enforce that the namespace segment before / is a valid [server:]namespace string
Accept the full three-part format as documented in the spec

This means actors named cleverthis:local/my-actor would be stored with namespace = "cleverthis:local" (treating the colon as part of the namespace), which is incorrect per the spec's three-part naming convention.

Steps to Reproduce

from cleveragents.actor.schema import ActorConfigSchema, ActorType

# This should be valid per spec but the namespace is parsed incorrectly
actor = ActorConfigSchema(
    name="myserver:local/my-actor",  # server:namespace/name format
    type=ActorType.LLM,
    description="Test actor",
    model="gpt-4",
)
# The name is accepted but the namespace is "myserver:local" instead of
# being parsed as server="myserver", namespace="local", name="my-actor"

Code Location

src/cleveragents/actor/schema.py:776–800 — ActorConfigSchema.validate_name()
src/cleveragents/actor/registry.py:71–78 — _ensure_namespaced() (only handles missing slash, not server prefix)
src/cleveragents/actor/loader.py:59–63 — _normalize_name() (same issue)

Expected Fix

The validate_name() validator should:

Accept the full [[server:]namespace/]name format
Parse and validate the optional server: prefix in the namespace segment
Validate that each component (server, namespace, name) follows the allowed character set (e.g., [a-z0-9_-]+)
Store the full qualified name correctly

This aligns with how project.py (lines 114–155) already implements parse_name() for the three-part format.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** Actor YAML configuration schema — actor namespacing **Severity:** High — actors with server-qualified names cannot be registered or loaded **Found by:** UAT tester instance `uat-tester-actor-system` **Spec reference:** `docs/specification.md` §Actor Naming (line 155, 20127–20135) --- ### What Was Tested Code-level analysis of `src/cleveragents/actor/schema.py` — `ActorConfigSchema.validate_name()` (lines 776–800) against the spec's actor namespacing requirements. ### Expected Behavior (from spec) The spec (line 155) defines actors as: > A YAML-configured conversational unit — either a single LLM/agent or a composed LangGraph of actors and tool nodes. Namespaced as `[[server:]namespace/]name`. The spec (lines 20127–20135) shows naming examples: | Name | Namespace | Description | | `local/my-reviewer` | `local` | Local actor on this machine | | `freemo/code-analyzer` | `freemo` | Personal server actor | | `cleverthis/deploy-specialist` | `cleverthis` | Organization actor | | `openai/gpt-4` | `openai` | Built-in LLM actor | The spec also defines (line 174): > Namespace: The scoping segment in the name format `[[server:]namespace/]name`. Defaults to `local/` when omitted. The full three-part format `server:namespace/name` (e.g., `myserver:local/my-actor`) is a valid actor name per the spec. ### Actual Behavior (from code) `ActorConfigSchema.validate_name()` at `src/cleveragents/actor/schema.py:776–800`: ```python @field_validator("name") @classmethod def validate_name(cls, v: str) -> str: """Ensure actor name follows namespace/name format.""" if "/" not in v: msg = f"Actor name must be namespaced (namespace/name): {v}" raise ValueError(msg) # Check for exactly one slash parts = v.split("/") if len(parts) != 2: # ← BUG: rejects "server:namespace/name" msg = ( f"Actor name must be namespaced with exactly one slash " f"(namespace/name): {v}" ) raise ValueError(msg) ... ``` The validator requires **exactly one slash**, which means: - `local/my-actor` ✅ accepted - `myserver:local/my-actor` ❌ rejected (has one slash but `parts = ["myserver:local", "my-actor"]` — wait, actually this would pass the `len(parts) != 2` check) Wait — re-examining: `"myserver:local/my-actor".split("/")` = `["myserver:local", "my-actor"]` — this has 2 parts and would pass. However, the validator does NOT validate the `server:namespace` prefix format at all. The real issue is: **The validator does not support the full `[[server:]namespace/]name` format** — it only validates `namespace/name` (two parts separated by a single slash). It does not: 1. Parse or validate the optional `server:` prefix in the namespace segment 2. Enforce that the namespace segment before `/` is a valid `[server:]namespace` string 3. Accept the full three-part format as documented in the spec This means actors named `cleverthis:local/my-actor` would be stored with `namespace = "cleverthis:local"` (treating the colon as part of the namespace), which is incorrect per the spec's three-part naming convention. ### Steps to Reproduce ```python from cleveragents.actor.schema import ActorConfigSchema, ActorType # This should be valid per spec but the namespace is parsed incorrectly actor = ActorConfigSchema( name="myserver:local/my-actor", # server:namespace/name format type=ActorType.LLM, description="Test actor", model="gpt-4", ) # The name is accepted but the namespace is "myserver:local" instead of # being parsed as server="myserver", namespace="local", name="my-actor" ``` ### Code Location - `src/cleveragents/actor/schema.py:776–800` — `ActorConfigSchema.validate_name()` - `src/cleveragents/actor/registry.py:71–78` — `_ensure_namespaced()` (only handles missing slash, not server prefix) - `src/cleveragents/actor/loader.py:59–63` — `_normalize_name()` (same issue) ### Expected Fix The `validate_name()` validator should: 1. Accept the full `[[server:]namespace/]name` format 2. Parse and validate the optional `server:` prefix in the namespace segment 3. Validate that each component (`server`, `namespace`, `name`) follows the allowed character set (e.g., `[a-z0-9_-]+`) 4. Store the full qualified name correctly This aligns with how `project.py` (lines 114–155) already implements `parse_name()` for the three-part format. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 19:46:08 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 19:59:07 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:12:39 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:16:04 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:22:25 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 added the

labels

2026-04-08 23:00:08 +00:00

HAL9000 referenced this issue

2026-04-09 01:11:39 +00:00

UAT: ActorConfigSchema name validator rejects server-qualified names (server:namespace/name) — spec requires full [[server:]namespace/]name format #5075

HAL9000 commented

2026-04-09 03:03:18 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — spec compliance bug identified by UAT testing
Story Points: 3 (M) — targeted fix to align implementation with spec
MoSCoW: Must Have — spec compliance is required for correct system behavior

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — spec compliance bug identified by UAT testing - **Story Points**: 3 (M) — targeted fix to align implementation with spec - **MoSCoW**: Must Have — spec compliance is required for correct system behavior --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 added

and removed

labels

2026-04-09 03:03:19 +00:00

HAL9000 added this to the v3.5.0 milestone