cleveragents/cleveragents-core

Fork 3

UAT: `agents resource tree --type` uses exact type matching instead of spec-required polymorphic subtype matching (ADR-042) #4797

New issue

Open

opened 2026-04-08 19:00:19 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-08 19:00:19 +00:00

Owner

Bug Report

Feature Area: Resource registry — agents resource tree, ADR-042 polymorphic type matching
Severity: Medium
Found by: UAT tester instance uat-worker-resource-registry
Spec reference: docs/specification.md §agents resource tree (lines ~11676–11859), ADR-042

What Was Tested

Code-level analysis of src/cleveragents/application/services/_resource_registry_dag.py — _build_tree_node() function (lines ~285–327).

Expected Behavior (from spec)

The spec (line 11676) defines agents resource tree --type TYPE to filter children by resource type. Per ADR-042 (Resource Type Inheritance), type filtering should use polymorphic subtype matching — if you filter by container-instance, results should include devcontainer-instance resources (which inherit from container-instance).

This is consistent with the spec's description of ADR-042 polymorphic matching (line 112):

Tools bound to a parent type automatically work with all subtypes (polymorphic matching). Auto-discovery child type matching and DAG queries are also polymorphic.

The list_resources() method already implements polymorphic matching correctly (lines ~200–213 in _resource_registry_ops.py):

# Correct polymorphic implementation in list_resources()
registry = self._load_type_registry()
subtypes = find_subtypes(type_name, registry)
all_types = [type_name, *subtypes]
query = query.filter(ResourceModel.type_name.in_(all_types))

Actual Behavior

The _build_tree_node() function in _resource_registry_dag.py (line ~314) uses exact type matching:

# _resource_registry_dag.py line ~314
if type_filter and child_res.resource_type_name != type_filter:
    continue

This is a simple string equality check, not polymorphic. If you run agents resource tree local/my-repo --type container-instance, it will NOT include devcontainer-instance children even though devcontainer-instance inherits from container-instance.

Spec vs Implementation Comparison

Behavior	Spec (ADR-042)	Implementation
`--type` filter	Polymorphic (includes subtypes)	Exact match only
`devcontainer-instance` when filtering `container-instance`	Included	Excluded
Consistency with `resource list --type`	Polymorphic	Exact match (inconsistent)

Code Location

src/cleveragents/application/services/_resource_registry_dag.py — _build_tree_node() (line ~314)
Fix: Replace child_res.resource_type_name != type_filter with polymorphic is_subtype_of() check
Reference: _resource_registry_ops.py lines ~200–213 (correct polymorphic implementation in list_resources)

Impact

agents resource tree --type container-instance silently excludes devcontainer-instance children
Inconsistent behavior between resource list --type (polymorphic) and resource tree --type (exact)
Violates ADR-042's requirement that "DAG queries are also polymorphic"

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** Resource registry — `agents resource tree`, ADR-042 polymorphic type matching **Severity:** Medium **Found by:** UAT tester instance `uat-worker-resource-registry` **Spec reference:** `docs/specification.md` §`agents resource tree` (lines ~11676–11859), ADR-042 --- ### What Was Tested Code-level analysis of `src/cleveragents/application/services/_resource_registry_dag.py` — `_build_tree_node()` function (lines ~285–327). ### Expected Behavior (from spec) The spec (line 11676) defines `agents resource tree --type TYPE` to filter children by resource type. Per ADR-042 (Resource Type Inheritance), type filtering should use **polymorphic subtype matching** — if you filter by `container-instance`, results should include `devcontainer-instance` resources (which inherit from `container-instance`). This is consistent with the spec's description of ADR-042 polymorphic matching (line 112): > Tools bound to a parent type automatically work with all subtypes (polymorphic matching). Auto-discovery child type matching and DAG queries are also polymorphic. The `list_resources()` method already implements polymorphic matching correctly (lines ~200–213 in `_resource_registry_ops.py`): ```python # Correct polymorphic implementation in list_resources() registry = self._load_type_registry() subtypes = find_subtypes(type_name, registry) all_types = [type_name, *subtypes] query = query.filter(ResourceModel.type_name.in_(all_types)) ``` ### Actual Behavior The `_build_tree_node()` function in `_resource_registry_dag.py` (line ~314) uses **exact type matching**: ```python # _resource_registry_dag.py line ~314 if type_filter and child_res.resource_type_name != type_filter: continue ``` This is a simple string equality check, not polymorphic. If you run `agents resource tree local/my-repo --type container-instance`, it will NOT include `devcontainer-instance` children even though `devcontainer-instance` inherits from `container-instance`. ### Spec vs Implementation Comparison | Behavior | Spec (ADR-042) | Implementation | |----------|----------------|----------------| | `--type` filter | Polymorphic (includes subtypes) | Exact match only | | `devcontainer-instance` when filtering `container-instance` | Included | Excluded | | Consistency with `resource list --type` | Polymorphic | Exact match (inconsistent) | ### Code Location - `src/cleveragents/application/services/_resource_registry_dag.py` — `_build_tree_node()` (line ~314) - Fix: Replace `child_res.resource_type_name != type_filter` with polymorphic `is_subtype_of()` check - Reference: `_resource_registry_ops.py` lines ~200–213 (correct polymorphic implementation in `list_resources`) ### Impact - `agents resource tree --type container-instance` silently excludes `devcontainer-instance` children - Inconsistent behavior between `resource list --type` (polymorphic) and `resource tree --type` (exact) - Violates ADR-042's requirement that "DAG queries are also polymorphic" --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 19:46:19 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:08:52 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 added the

labels

2026-04-08 23:00:09 +00:00

HAL9000 commented

2026-04-09 03:03:19 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — spec compliance bug identified by UAT testing
Story Points: 3 (M) — targeted fix to align implementation with spec
MoSCoW: Must Have — spec compliance is required for correct system behavior

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — spec compliance bug identified by UAT testing - **Story Points**: 3 (M) — targeted fix to align implementation with spec - **MoSCoW**: Must Have — spec compliance is required for correct system behavior --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 added

and removed

labels

2026-04-09 03:03:20 +00:00

HAL9000 added this to the v3.5.0 milestone