cleveragents/cleveragents-core

Fork 3

UAT: `automation-profile list` and `automation-profile show` JSON/YAML output missing spec-required envelope fields (`command`, `status`, `exit_code`, `timing`, `messages`) #4790

New issue

Open

opened 2026-04-08 18:58:51 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-08 18:58:51 +00:00

Owner

Bug Report

Feature area: Sandbox and checkpoint safety model — Automation Profile CLI commands
Severity: Medium
Discovered by: UAT Testing (uat-worker-sandbox-checkpoint)
Spec reference: docs/specification.md lines 17090–17109 (automation-profile list), lines 17264–17300 (automation-profile show)

Expected Behavior (from spec)

The spec requires all CLI commands to return a structured JSON envelope with command, status, exit_code, data, timing, and messages fields.

For agents automation-profile list --format json (spec lines 17090–17109):

{
  "command": "automation-profile list",
  "status": "ok",
  "exit_code": 0,
  "data": {
    "profiles": [...],
    "summary": { "built_in": 8, "custom": 0, "total": 8 }
  },
  "timing": { "started": "2026-02-08T14:31:00Z", "duration_ms": 50 },
  "messages": ["8 profiles listed"]
}

For agents automation-profile show <NAME> --format json (spec lines 17264–17300):

{
  "command": "automation-profile show",
  "status": "ok",
  "exit_code": 0,
  "data": { ... profile fields ... },
  "timing": { "started": "2026-02-08T14:31:00Z", "duration_ms": 55 },
  "messages": ["Profile loaded"]
}

Actual Behavior

The automation-profile list command in src/cleveragents/cli/commands/automation_profile.py (lines 390–410) outputs:

{
  "profiles": [...],
  "summary": { "built_in": 8, "custom": 0, "total": 8 }
}

The automation-profile show command (lines 128–130) outputs:

{
  "name": "trusted",
  "source": "built-in",
  "description": "...",
  "phase_transitions": {...},
  ...
}

Both commands are missing the outer envelope fields:

command — the command name
status — "ok" or "error"
exit_code — 0 for success
timing — { "started": "...", "duration_ms": N }
messages — list of status messages

Code Locations

src/cleveragents/cli/commands/automation_profile.py
- list_profiles() function (lines 390–410): builds data dict without envelope
- _print_profile() function (lines 128–130): calls format_output(data, fmt) without envelope

Steps to Reproduce

agents automation-profile list --format json
# Output: {"profiles": [...], "summary": {...}}
# Missing: command, status, exit_code, timing, messages

agents automation-profile show trusted --format json
# Output: {"name": "trusted", "source": "built-in", ...}
# Missing: command, status, exit_code, timing, messages

Impact

Scripts and CI/CD pipelines consuming --format json output will fail to find command, status, or exit_code fields
Inconsistent with all other CLI commands that do include the envelope
The spec's structured output contract is violated

Fix Required

Wrap the data dict in the spec-required envelope before calling format_output():

# In list_profiles():
envelope = {
    "command": "automation-profile list",
    "status": "ok",
    "exit_code": 0,
    "data": {
        "profiles": profile_entries,
        "summary": {"built_in": built_in_count, "custom": custom_count, "total": total_count},
    },
    "timing": {"duration_ms": 0},
    "messages": [f"{total_count} profiles listed"],
}
console.print(format_output(envelope, fmt))

# In _print_profile():
envelope = {
    "command": "automation-profile show",
    "status": "ok",
    "exit_code": 0,
    "data": _profile_spec_dict(profile),
    "timing": {"duration_ms": 0},
    "messages": ["Profile loaded"],
}
console.print(format_output(envelope, fmt))

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature area:** Sandbox and checkpoint safety model — Automation Profile CLI commands **Severity:** Medium **Discovered by:** UAT Testing (uat-worker-sandbox-checkpoint) **Spec reference:** `docs/specification.md` lines 17090–17109 (`automation-profile list`), lines 17264–17300 (`automation-profile show`) --- ## Expected Behavior (from spec) The spec requires all CLI commands to return a structured JSON envelope with `command`, `status`, `exit_code`, `data`, `timing`, and `messages` fields. For `agents automation-profile list --format json` (spec lines 17090–17109): ```json { "command": "automation-profile list", "status": "ok", "exit_code": 0, "data": { "profiles": [...], "summary": { "built_in": 8, "custom": 0, "total": 8 } }, "timing": { "started": "2026-02-08T14:31:00Z", "duration_ms": 50 }, "messages": ["8 profiles listed"] } ``` For `agents automation-profile show <NAME> --format json` (spec lines 17264–17300): ```json { "command": "automation-profile show", "status": "ok", "exit_code": 0, "data": { ... profile fields ... }, "timing": { "started": "2026-02-08T14:31:00Z", "duration_ms": 55 }, "messages": ["Profile loaded"] } ``` ## Actual Behavior The `automation-profile list` command in `src/cleveragents/cli/commands/automation_profile.py` (lines 390–410) outputs: ```json { "profiles": [...], "summary": { "built_in": 8, "custom": 0, "total": 8 } } ``` The `automation-profile show` command (lines 128–130) outputs: ```json { "name": "trusted", "source": "built-in", "description": "...", "phase_transitions": {...}, ... } ``` Both commands are **missing** the outer envelope fields: - `command` — the command name - `status` — `"ok"` or `"error"` - `exit_code` — `0` for success - `timing` — `{ "started": "...", "duration_ms": N }` - `messages` — list of status messages ## Code Locations - `src/cleveragents/cli/commands/automation_profile.py` - `list_profiles()` function (lines 390–410): builds `data` dict without envelope - `_print_profile()` function (lines 128–130): calls `format_output(data, fmt)` without envelope ## Steps to Reproduce ```bash agents automation-profile list --format json # Output: {"profiles": [...], "summary": {...}} # Missing: command, status, exit_code, timing, messages agents automation-profile show trusted --format json # Output: {"name": "trusted", "source": "built-in", ...} # Missing: command, status, exit_code, timing, messages ``` ## Impact - Scripts and CI/CD pipelines consuming `--format json` output will fail to find `command`, `status`, or `exit_code` fields - Inconsistent with all other CLI commands that do include the envelope - The spec's structured output contract is violated ## Fix Required Wrap the data dict in the spec-required envelope before calling `format_output()`: ```python # In list_profiles(): envelope = { "command": "automation-profile list", "status": "ok", "exit_code": 0, "data": { "profiles": profile_entries, "summary": {"built_in": built_in_count, "custom": custom_count, "total": total_count}, }, "timing": {"duration_ms": 0}, "messages": [f"{total_count} profiles listed"], } console.print(format_output(envelope, fmt)) # In _print_profile(): envelope = { "command": "automation-profile show", "status": "ok", "exit_code": 0, "data": _profile_spec_dict(profile), "timing": {"duration_ms": 0}, "messages": ["Profile loaded"], } console.print(format_output(envelope, fmt)) ``` --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 19:00:24 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4743

HAL9000 added the

labels

2026-04-08 23:00:10 +00:00

HAL9000 commented

2026-04-09 03:03:46 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — spec compliance bug identified by UAT testing
Story Points: 3 (M) — targeted fix to align implementation with spec
MoSCoW: Must Have — spec compliance is required for correct system behavior

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — spec compliance bug identified by UAT testing - **Story Points**: 3 (M) — targeted fix to align implementation with spec - **MoSCoW**: Must Have — spec compliance is required for correct system behavior --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 added

and removed

labels

2026-04-09 03:03:59 +00:00

HAL9000 added this to the v3.5.0 milestone