cleveragents/cleveragents-core

Fork 3

UAT: `agents actor add --update` does not show spec-required "Changes" panel and `actor add` (new) does not show "Actor Added" panel with Type field #4780

New issue

Open

opened 2026-04-08 18:56:48 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-08 18:56:48 +00:00

Owner

Bug Report

Feature Area: Actor add command output
Severity: Medium
Found by: UAT tester instance uat-worker-actor-yaml
Spec reference: docs/specification.md §agents actor add (lines 4938–5268)

What Was Tested

Code-level analysis of src/cleveragents/cli/commands/actor.py — the add command output for both new actor registration and --update scenarios.

Expected Behavior (from spec)

For agents actor add --config ./actors/reviewer.yaml (new actor):

The spec (lines 4957–4987) shows:

Actor Added panel — Name, Provider, Model, Default, Unsafe, Type
Config panel — Path, Hash, Options, Nodes, Edges
Capabilities panel — list of capabilities
Tools panel — table of Tool, Read-Only, Safe
Status line: ✓ OK Actor added

For agents actor add --config ./actors/reviewer.yaml --update (existing actor):

The spec (lines 5187–5199) shows:

Actor Updated panel — Name, Type, Status
Changes panel — Skills, Model, Graph (showing what changed)
Status line: ✓ OK Actor updated

Actual Behavior

For new actor (add without --update):

The implementation calls _print_actor(actor, title="Actor added", show_add_panels=True) which renders:

Basic panel (Name, Provider, Model, Default, Unsafe, Type) ✅
Config panel ✅
Capabilities panel (only if capabilities exist in blob) ✅
Tools panel (only if tools exist in blob) ✅
Status line: ✓ OK Actor added ✅

This mostly matches the spec, but the "Actor Added" panel title in the spec is "Actor Added" while the implementation uses the title passed to _print_actor() which is "Actor added" (lowercase 'a'). Minor but inconsistent.

For --update (existing actor):

The implementation calls _print_actor(actor, title="Actor updated", show_add_panels=False) (line 645-652):

title = "Actor updated" if update_existing else "Actor added"
_print_actor(
    actor,
    title=title,
    fmt=fmt,
    config_path=config,
    show_add_panels=(not update_existing),  # ← False when updating!
)

When show_add_panels=False, _print_actor() only renders the basic panel (Name, Provider, Model, Default, Unsafe, Type) and returns immediately. The Changes panel is entirely missing.

The spec requires the --update output to show:

What skills changed (e.g., "+1 (local/code-analysis)")
Whether the model changed
Whether the graph was updated

None of this is computed or displayed.

Code Location

Affected file: src/cleveragents/cli/commands/actor.py lines 644–655
_print_actor() helper: lines 421–498
Spec reference: docs/specification.md lines 5180–5268

Impact

Users running actor add --update cannot see what changed in the actor configuration
The --update output is indistinguishable from a basic actor show output
Users cannot verify that their update was applied correctly (no diff/changes panel)

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** Actor add command output **Severity:** Medium **Found by:** UAT tester instance `uat-worker-actor-yaml` **Spec reference:** docs/specification.md §agents actor add (lines 4938–5268) --- ### What Was Tested Code-level analysis of `src/cleveragents/cli/commands/actor.py` — the `add` command output for both new actor registration and `--update` scenarios. ### Expected Behavior (from spec) **For `agents actor add --config ./actors/reviewer.yaml` (new actor):** The spec (lines 4957–4987) shows: 1. **Actor Added** panel — Name, Provider, Model, Default, Unsafe, **Type** 2. **Config** panel — Path, Hash, Options, Nodes, Edges 3. **Capabilities** panel — list of capabilities 4. **Tools** panel — table of Tool, Read-Only, Safe 5. Status line: `✓ OK Actor added` **For `agents actor add --config ./actors/reviewer.yaml --update` (existing actor):** The spec (lines 5187–5199) shows: 1. **Actor Updated** panel — Name, Type, Status 2. **Changes** panel — Skills, Model, Graph (showing what changed) 3. Status line: `✓ OK Actor updated` ### Actual Behavior **For new actor (`add` without `--update`):** The implementation calls `_print_actor(actor, title="Actor added", show_add_panels=True)` which renders: - Basic panel (Name, Provider, Model, Default, Unsafe, Type) ✅ - Config panel ✅ - Capabilities panel (only if capabilities exist in blob) ✅ - Tools panel (only if tools exist in blob) ✅ - Status line: `✓ OK Actor added` ✅ This mostly matches the spec, but the "Actor Added" panel title in the spec is "Actor Added" while the implementation uses the title passed to `_print_actor()` which is "Actor added" (lowercase 'a'). Minor but inconsistent. **For `--update` (existing actor):** The implementation calls `_print_actor(actor, title="Actor updated", show_add_panels=False)` (line 645-652): ```python title = "Actor updated" if update_existing else "Actor added" _print_actor( actor, title=title, fmt=fmt, config_path=config, show_add_panels=(not update_existing), # ← False when updating! ) ``` When `show_add_panels=False`, `_print_actor()` only renders the basic panel (Name, Provider, Model, Default, Unsafe, Type) and returns immediately. The **Changes panel is entirely missing**. The spec requires the `--update` output to show: - What skills changed (e.g., "+1 (local/code-analysis)") - Whether the model changed - Whether the graph was updated None of this is computed or displayed. ### Code Location - **Affected file:** `src/cleveragents/cli/commands/actor.py` lines 644–655 - **`_print_actor()` helper:** lines 421–498 - **Spec reference:** docs/specification.md lines 5180–5268 ### Impact - Users running `actor add --update` cannot see what changed in the actor configuration - The `--update` output is indistinguishable from a basic `actor show` output - Users cannot verify that their update was applied correctly (no diff/changes panel) --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 18:59:36 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4743

HAL9000 added the

labels

2026-04-08 23:00:12 +00:00

HAL9000 commented

2026-04-09 03:04:09 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — spec compliance bug identified by UAT testing
Story Points: 3 (M) — targeted fix to align implementation with spec
MoSCoW: Must Have — spec compliance is required for correct system behavior

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — spec compliance bug identified by UAT testing - **Story Points**: 3 (M) — targeted fix to align implementation with spec - **MoSCoW**: Must Have — spec compliance is required for correct system behavior --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 added

and removed

labels

2026-04-09 03:04:21 +00:00

HAL9000 added this to the v3.5.0 milestone