cleveragents/cleveragents-core

Fork 3

UAT: `ProviderRegistry.create_ai_provider()` raises `ValueError: Unsupported provider type: mock` — MOCK provider type has no handler branch #4721

New issue

Open

opened 2026-04-08 18:11:48 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-08 18:11:48 +00:00

Owner

Summary

ProviderRegistry.create_ai_provider() in src/cleveragents/providers/registry.py has no branch for ProviderType.MOCK. When called with provider_type="mock", it falls through to the LangChainChatProvider generic path which calls _create_provider_llm(), which raises ValueError: Unsupported provider type: mock.

Expected Behavior

create_ai_provider(provider_type="mock") should return a mock AIProviderInterface implementation suitable for testing, without requiring a real API key.

Actual Behavior

registry = ProviderRegistry()
registry.create_ai_provider(provider_type="mock")
# Raises: ValueError: Unsupported provider type: mock

Trace:

create_ai_provider("mock") — no if provider_type == ProviderType.MOCK: branch
Falls through to the generic LangChainChatProvider path
llm_factory calls self._create_provider_llm(ProviderType.MOCK, model_id, ...)
_create_provider_llm() has no branch for ProviderType.MOCK
Raises ValueError: Unsupported provider type: mock

Code Location

src/cleveragents/providers/registry.py
- create_ai_provider() method — missing ProviderType.MOCK branch (lines ~380–470)
- _create_provider_llm() method — missing ProviderType.MOCK branch (lines ~490–540)

Impact

CLEVERAGENTS_MOCK_PROVIDERS=true is used in test environments, but calling create_ai_provider("mock") crashes
Any code path that resolves the mock provider and then calls create_ai_provider() will raise an unhandled ValueError
CI test suites that use mock providers may fail unexpectedly if they go through the registry

Fix Direction

Add a ProviderType.MOCK branch in both methods:

# In create_ai_provider():
if provider_type == ProviderType.MOCK:
    from cleveragents.providers.llm.mock_provider import MockChatProvider
    return MockChatProvider(
        model=model_id or self.DEFAULT_MODELS.get(provider_type, "mock-gpt"),
        max_retries=max_retries,
    )

# In _create_provider_llm():
if provider_type == ProviderType.MOCK:
    from cleveragents.providers.llm.mock_provider import MockLLM
    return MockLLM(model=model_id or "mock-gpt")

Or alternatively, create a simple in-registry mock that doesn't require a separate file.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Summary `ProviderRegistry.create_ai_provider()` in `src/cleveragents/providers/registry.py` has no branch for `ProviderType.MOCK`. When called with `provider_type="mock"`, it falls through to the `LangChainChatProvider` generic path which calls `_create_provider_llm()`, which raises `ValueError: Unsupported provider type: mock`. ## Expected Behavior `create_ai_provider(provider_type="mock")` should return a mock `AIProviderInterface` implementation suitable for testing, without requiring a real API key. ## Actual Behavior ```python registry = ProviderRegistry() registry.create_ai_provider(provider_type="mock") # Raises: ValueError: Unsupported provider type: mock ``` Trace: 1. `create_ai_provider("mock")` — no `if provider_type == ProviderType.MOCK:` branch 2. Falls through to the generic `LangChainChatProvider` path 3. `llm_factory` calls `self._create_provider_llm(ProviderType.MOCK, model_id, ...)` 4. `_create_provider_llm()` has no branch for `ProviderType.MOCK` 5. Raises `ValueError: Unsupported provider type: mock` ## Code Location - `src/cleveragents/providers/registry.py` - `create_ai_provider()` method — missing `ProviderType.MOCK` branch (lines ~380–470) - `_create_provider_llm()` method — missing `ProviderType.MOCK` branch (lines ~490–540) ## Impact - `CLEVERAGENTS_MOCK_PROVIDERS=true` is used in test environments, but calling `create_ai_provider("mock")` crashes - Any code path that resolves the mock provider and then calls `create_ai_provider()` will raise an unhandled `ValueError` - CI test suites that use mock providers may fail unexpectedly if they go through the registry ## Fix Direction Add a `ProviderType.MOCK` branch in both methods: ```python # In create_ai_provider(): if provider_type == ProviderType.MOCK: from cleveragents.providers.llm.mock_provider import MockChatProvider return MockChatProvider( model=model_id or self.DEFAULT_MODELS.get(provider_type, "mock-gpt"), max_retries=max_retries, ) # In _create_provider_llm(): if provider_type == ProviderType.MOCK: from cleveragents.providers.llm.mock_provider import MockLLM return MockLLM(model=model_id or "mock-gpt") ``` Or alternatively, create a simple in-registry mock that doesn't require a separate file. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 18:52:12 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4743

HAL9000 referenced this issue

2026-04-08 18:55:48 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4743

freemo added the

labels

2026-04-08 23:38:44 +00:00

HAL9000 commented

2026-04-09 03:05:41 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — spec compliance bug identified by UAT testing
Story Points: 3 (M) — targeted fix to align implementation with spec
MoSCoW: Must Have — spec compliance is required for correct system behavior

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — spec compliance bug identified by UAT testing - **Story Points**: 3 (M) — targeted fix to align implementation with spec - **MoSCoW**: Must Have — spec compliance is required for correct system behavior --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 added

and removed

labels

2026-04-09 03:05:52 +00:00

HAL9000 added this to the v3.5.0 milestone