cleveragents/cleveragents-core

Fork 3

UAT: `ProviderType.MOCK` missing from `PROVIDER_KEY_ATTRS` — mock provider never discovered by `ProviderRegistry._discover_providers()` #4719

New issue

Open

opened 2026-04-08 18:11:34 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-08 18:11:34 +00:00

Owner

Summary

ProviderType.MOCK is defined in the ProviderType enum but is absent from ProviderRegistry.PROVIDER_KEY_ATTRS. As a result, _discover_providers() never creates a ProviderInfo entry for the mock provider, so get_all_providers() never returns it and get_provider_info("mock") always returns None.

Expected Behavior

The mock provider should be discoverable via ProviderRegistry.get_all_providers() and get_provider_info("mock"). When CLEVERAGENTS_MOCK_PROVIDERS=true is set, the mock provider should be returned as configured.

Actual Behavior

# src/cleveragents/providers/registry.py

class ProviderType(StrEnum):
    MOCK = "mock"  # ✓ defined

PROVIDER_KEY_ATTRS: ClassVar[dict[ProviderType, str]] = {
    ProviderType.OPENAI: "openai_api_key",
    ProviderType.ANTHROPIC: "anthropic_api_key",
    ProviderType.GOOGLE: "google_api_key",
    ProviderType.GEMINI: "gemini_api_key",
    ProviderType.AZURE: "azure_api_key",
    ProviderType.OPENROUTER: "openrouter_api_key",
    ProviderType.COHERE: "cohere_api_key",
    ProviderType.GROQ: "groq_api_key",
    ProviderType.TOGETHER: "together_api_key",
    # ProviderType.MOCK is MISSING ← bug
}

_discover_providers() iterates over PROVIDER_KEY_ATTRS, so MOCK is never added to self._providers. Consequently:

registry = ProviderRegistry()
registry.get_provider_info("mock")  # Returns None — should return ProviderInfo
registry.get_all_providers()  # Never includes mock — should include it

Impact

ProviderRegistry.get_all_providers() returns an incomplete list — the mock provider is missing
get_provider_info("mock") returns None instead of a ProviderInfo object
Tests and development environments that rely on mock providers cannot discover the mock provider through the registry API
The DEFAULT_CAPABILITIES and DEFAULT_MODELS already have entries for MOCK, making the omission from PROVIDER_KEY_ATTRS inconsistent

Code Location

src/cleveragents/providers/registry.py — PROVIDER_KEY_ATTRS class variable (lines ~155–165) and _discover_providers() method (lines ~185–200)

Fix Direction

Add ProviderType.MOCK to PROVIDER_KEY_ATTRS with a sentinel attribute name (e.g., "mock_providers" which maps to Settings.mock_providers), or handle mock specially in _discover_providers():

# Option A: Add to PROVIDER_KEY_ATTRS with a mock-specific sentinel
PROVIDER_KEY_ATTRS: ClassVar[dict[ProviderType, str]] = {
    ...
    ProviderType.MOCK: "mock_providers",  # Settings.mock_providers bool flag
}

# Option B: Handle mock separately in _discover_providers()
def _discover_providers(self) -> None:
    ...
    # Always register mock provider; configured when mock_providers=True
    mock_info = ProviderInfo(
        provider_type=ProviderType.MOCK,
        name="Mock",
        api_key_env_var="CLEVERAGENTS_MOCK_PROVIDERS",
        default_model=self.DEFAULT_MODELS[ProviderType.MOCK],
        capabilities=self.DEFAULT_CAPABILITIES[ProviderType.MOCK],
        is_configured=self._settings.mock_providers,
    )
    self._providers[ProviderType.MOCK] = mock_info

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Summary `ProviderType.MOCK` is defined in the `ProviderType` enum but is absent from `ProviderRegistry.PROVIDER_KEY_ATTRS`. As a result, `_discover_providers()` never creates a `ProviderInfo` entry for the mock provider, so `get_all_providers()` never returns it and `get_provider_info("mock")` always returns `None`. ## Expected Behavior The mock provider should be discoverable via `ProviderRegistry.get_all_providers()` and `get_provider_info("mock")`. When `CLEVERAGENTS_MOCK_PROVIDERS=true` is set, the mock provider should be returned as configured. ## Actual Behavior ```python # src/cleveragents/providers/registry.py class ProviderType(StrEnum): MOCK = "mock" # ✓ defined PROVIDER_KEY_ATTRS: ClassVar[dict[ProviderType, str]] = { ProviderType.OPENAI: "openai_api_key", ProviderType.ANTHROPIC: "anthropic_api_key", ProviderType.GOOGLE: "google_api_key", ProviderType.GEMINI: "gemini_api_key", ProviderType.AZURE: "azure_api_key", ProviderType.OPENROUTER: "openrouter_api_key", ProviderType.COHERE: "cohere_api_key", ProviderType.GROQ: "groq_api_key", ProviderType.TOGETHER: "together_api_key", # ProviderType.MOCK is MISSING ← bug } ``` `_discover_providers()` iterates over `PROVIDER_KEY_ATTRS`, so `MOCK` is never added to `self._providers`. Consequently: ```python registry = ProviderRegistry() registry.get_provider_info("mock") # Returns None — should return ProviderInfo registry.get_all_providers() # Never includes mock — should include it ``` ## Impact - `ProviderRegistry.get_all_providers()` returns an incomplete list — the mock provider is missing - `get_provider_info("mock")` returns `None` instead of a `ProviderInfo` object - Tests and development environments that rely on mock providers cannot discover the mock provider through the registry API - The `DEFAULT_CAPABILITIES` and `DEFAULT_MODELS` already have entries for `MOCK`, making the omission from `PROVIDER_KEY_ATTRS` inconsistent ## Code Location - `src/cleveragents/providers/registry.py` — `PROVIDER_KEY_ATTRS` class variable (lines ~155–165) and `_discover_providers()` method (lines ~185–200) ## Fix Direction Add `ProviderType.MOCK` to `PROVIDER_KEY_ATTRS` with a sentinel attribute name (e.g., `"mock_providers"` which maps to `Settings.mock_providers`), or handle mock specially in `_discover_providers()`: ```python # Option A: Add to PROVIDER_KEY_ATTRS with a mock-specific sentinel PROVIDER_KEY_ATTRS: ClassVar[dict[ProviderType, str]] = { ... ProviderType.MOCK: "mock_providers", # Settings.mock_providers bool flag } # Option B: Handle mock separately in _discover_providers() def _discover_providers(self) -> None: ... # Always register mock provider; configured when mock_providers=True mock_info = ProviderInfo( provider_type=ProviderType.MOCK, name="Mock", api_key_env_var="CLEVERAGENTS_MOCK_PROVIDERS", default_model=self.DEFAULT_MODELS[ProviderType.MOCK], capabilities=self.DEFAULT_CAPABILITIES[ProviderType.MOCK], is_configured=self._settings.mock_providers, ) self._providers[ProviderType.MOCK] = mock_info ``` --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 18:52:12 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4743

HAL9000 referenced this issue

2026-04-08 18:55:48 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4743

freemo added the

labels

2026-04-08 23:38:46 +00:00

HAL9000 commented

2026-04-09 03:06:00 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — spec compliance bug identified by UAT testing
Story Points: 3 (M) — targeted fix to align implementation with spec
MoSCoW: Must Have — spec compliance is required for correct system behavior

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — spec compliance bug identified by UAT testing - **Story Points**: 3 (M) — targeted fix to align implementation with spec - **MoSCoW**: Must Have — spec compliance is required for correct system behavior --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 added

and removed

labels

2026-04-09 03:06:12 +00:00

HAL9000 added this to the v3.5.0 milestone