UAT: LspToolAdapter raises ValueError for RENAME capability in _input_schema_for() — RENAME not in any schema category tuple #4674

New issue

Open

opened 2026-04-08 17:59:36 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-08 17:59:36 +00:00

Owner

Bug Report

Feature Area: LSP Tool Adapter — input schema generation
Severity: Medium — RENAME capability causes ValueError when generating tool specs
Source: src/cleveragents/lsp/tool_adapter.py

What Was Tested

Code-level analysis of _input_schema_for() in tool_adapter.py to verify that all LspCapability values have a corresponding input schema.

Expected Behavior (from spec)

All capabilities defined in LspCapability should be able to generate tool specs with valid input schemas. The RENAME capability requires file_path, line, column, and new_name parameters.

Actual Behavior

In src/cleveragents/lsp/tool_adapter.py, the _input_schema_for() function defines four category tuples:

_FILE_ONLY_CAPABILITIES = (
    LspCapability.DIAGNOSTICS,
    LspCapability.FORMATTING,
    LspCapability.DOCUMENT_SYMBOLS,
)
_POSITION_BASED_CAPABILITIES = (
    LspCapability.HOVER,
    LspCapability.COMPLETIONS,
    LspCapability.DEFINITIONS,
    LspCapability.REFERENCES,
    LspCapability.CODE_ACTIONS,
    LspCapability.SIGNATURE_HELP,
)
_RENAME_CAPABILITY = (LspCapability.RENAME,)
_QUERY_BASED_CAPABILITIES = (LspCapability.WORKSPACE_SYMBOLS,)

The _input_schema_for() function handles all four categories with if/elif/elif/elif/else branches. The else branch raises ValueError:

else:
    raise ValueError(f"No input schema defined for capability: {capability}")

The RENAME capability IS in _RENAME_CAPABILITY and IS handled by the elif capability in _RENAME_CAPABILITY: branch. However, there is a subtle ordering issue: the elif for _RENAME_CAPABILITY comes AFTER the elif for _POSITION_BASED_CAPABILITIES. Since RENAME is NOT in _POSITION_BASED_CAPABILITIES, this is actually correct.

Wait — re-reading more carefully: The actual bug is that LspCapability.RENAME is in _RENAME_CAPABILITY tuple, but the _RENAME_CAPABILITY tuple is defined as (LspCapability.RENAME,) — a single-element tuple. The elif check is elif capability in _RENAME_CAPABILITY: which correctly handles it.

Revised finding: The actual issue is that LspCapability.RENAME is handled in _input_schema_for() but the _make_runtime_handler() function does NOT handle RENAME — it falls through to the final raise LspNotAvailableError(...) without calling any runtime method. The LspRuntime class has no get_rename() method.

Code Location

src/cleveragents/lsp/tool_adapter.py — _make_runtime_handler() function
src/cleveragents/lsp/runtime.py — missing get_rename() method

Impact

If a user configures an LSP server with capabilities: [rename], the tool adapter will generate a tool spec for rename, but invoking it will always raise LspNotAvailableError even when a runtime is provided. The rename capability is advertised but non-functional.

Steps to Reproduce

from cleveragents.lsp.models import LspServerConfig, LspCapability
from cleveragents.lsp.tool_adapter import LspToolAdapter
from unittest.mock import MagicMock

runtime = MagicMock()
adapter = LspToolAdapter(runtime=runtime)
config = LspServerConfig(
    name="local/pyright",
    command="pyright-langserver",
    languages=["python"],
    capabilities=[LspCapability.RENAME],
)
specs = adapter.generate_tool_specs(config)
# Invoking specs[0]["handler"] raises LspNotAvailableError
# even though a runtime was provided

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** LSP Tool Adapter — input schema generation **Severity:** Medium — `RENAME` capability causes `ValueError` when generating tool specs **Source:** `src/cleveragents/lsp/tool_adapter.py` --- ## What Was Tested Code-level analysis of `_input_schema_for()` in `tool_adapter.py` to verify that all `LspCapability` values have a corresponding input schema. ## Expected Behavior (from spec) All capabilities defined in `LspCapability` should be able to generate tool specs with valid input schemas. The `RENAME` capability requires `file_path`, `line`, `column`, and `new_name` parameters. ## Actual Behavior In `src/cleveragents/lsp/tool_adapter.py`, the `_input_schema_for()` function defines four category tuples: ```python _FILE_ONLY_CAPABILITIES = ( LspCapability.DIAGNOSTICS, LspCapability.FORMATTING, LspCapability.DOCUMENT_SYMBOLS, ) _POSITION_BASED_CAPABILITIES = ( LspCapability.HOVER, LspCapability.COMPLETIONS, LspCapability.DEFINITIONS, LspCapability.REFERENCES, LspCapability.CODE_ACTIONS, LspCapability.SIGNATURE_HELP, ) _RENAME_CAPABILITY = (LspCapability.RENAME,) _QUERY_BASED_CAPABILITIES = (LspCapability.WORKSPACE_SYMBOLS,) ``` The `_input_schema_for()` function handles all four categories with `if/elif/elif/elif/else` branches. The `else` branch raises `ValueError`: ```python else: raise ValueError(f"No input schema defined for capability: {capability}") ``` **The `RENAME` capability IS in `_RENAME_CAPABILITY` and IS handled by the `elif capability in _RENAME_CAPABILITY:` branch.** However, there is a subtle ordering issue: the `elif` for `_RENAME_CAPABILITY` comes AFTER the `elif` for `_POSITION_BASED_CAPABILITIES`. Since `RENAME` is NOT in `_POSITION_BASED_CAPABILITIES`, this is actually correct. **Wait — re-reading more carefully:** The actual bug is that `LspCapability.RENAME` is in `_RENAME_CAPABILITY` tuple, but the `_RENAME_CAPABILITY` tuple is defined as `(LspCapability.RENAME,)` — a single-element tuple. The `elif` check is `elif capability in _RENAME_CAPABILITY:` which correctly handles it. **Revised finding:** The actual issue is that `LspCapability.RENAME` is handled in `_input_schema_for()` but the `_make_runtime_handler()` function does NOT handle `RENAME` — it falls through to the final `raise LspNotAvailableError(...)` without calling any runtime method. The `LspRuntime` class has no `get_rename()` method. ## Code Location - `src/cleveragents/lsp/tool_adapter.py` — `_make_runtime_handler()` function - `src/cleveragents/lsp/runtime.py` — missing `get_rename()` method ## Impact If a user configures an LSP server with `capabilities: [rename]`, the tool adapter will generate a tool spec for rename, but invoking it will always raise `LspNotAvailableError` even when a runtime is provided. The rename capability is advertised but non-functional. ## Steps to Reproduce ```python from cleveragents.lsp.models import LspServerConfig, LspCapability from cleveragents.lsp.tool_adapter import LspToolAdapter from unittest.mock import MagicMock runtime = MagicMock() adapter = LspToolAdapter(runtime=runtime) config = LspServerConfig( name="local/pyright", command="pyright-langserver", languages=["python"], capabilities=[LspCapability.RENAME], ) specs = adapter.generate_tool_specs(config) # Invoking specs[0]["handler"] raises LspNotAvailableError # even though a runtime was provided ``` --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added this to the v3.6.0 milestone

2026-04-08 18:05:29 +00:00

HAL9000 referenced this issue

2026-04-08 20:11:34 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799