cleveragents/cleveragents-core

Fork 3

UAT: `agents skill add` rich output "Tool Sources" table missing spec-required "Details" column; JSON output uses wrong data structure #4614

New issue

Closed

opened 2026-04-08 16:39:31 +00:00 by HAL9000 · 3 comments

HAL9000 commented

2026-04-08 16:39:31 +00:00

Owner

Bug Report

Tested by: UAT tester worker uat-worker-skill-management-001
Feature area: Skill management — agents skill add output format
Severity: Medium — output format mismatch

Summary

The agents skill add command has two output format issues:

The rich output "Tool Sources" table is missing the spec-required "Details" column
The JSON output uses a flat data structure instead of the spec-required nested structure with data.skill, data.includes, data.tool_sources, etc.

Issue 1: Missing "Details" Column in Rich Output

Expected (from spec, lines 6395–6404):

╭─ Tool Sources ────────────────────────────────╮
│ Source         Count  Details                 │
│ ─────────────  ─────  ───────────────────     │
│ builtin        14     file, dir, git, shell   │
│ mcp            6      github (4), linear (2)  │
│ agent_skill    2      deploy, code-review     │
│ custom         1      run_migrations          │
│ ─────────────  ─────  ───────────────────     │
│ Total:         23                             │
╰───────────────────────────────────────────────╯

Actual:

╭─ Tool Sources ──╮
│ Source  ┃ Count │
│ ━━━━━━━━╇━━━━━━ │
│ builtin │     3 │
│ Total   │     3 │
╰─────────────────╯

The "Details" column (showing tool names/descriptions per source) is completely missing.

Issue 2: JSON Output Structure Mismatch

Expected (from spec, lines 6449–6479):

{
  "command": "skill add --config ./skills/devops-toolkit.yaml",
  "status": "ok",
  "exit_code": 0,
  "data": {
    "skill": {
      "name": "local/devops-toolkit",
      "description": "Full-stack development tools",
      "config": "./skills/devops-toolkit.yaml",
      "created": "2026-02-08T13:10:00Z"
    },
    "includes": [
      { "name": "local/file-ops", "status": "registered" }
    ],
    "tool_sources": [
      { "source": "builtin", "count": 14, "details": "file, dir, git, shell" },
      { "source": "mcp", "count": 6, "details": "github (4), linear (2)" }
    ],
    "total_tools": 23,
    "mcp_servers": [
      { "name": "linear", "status": "validated", "tools": 2 }
    ]
  },
  "timing": { "duration_ms": 150 },
  "messages": [
    { "level": "ok", "text": "Skill registered with 23 tools" }
  ]
}

Actual:

{
  "command": "",
  "status": "ok",
  "exit_code": 0,
  "data": {
    "name": "local/file-reader",
    "namespace": "local",
    "short_name": "file-reader",
    "description": "Basic file reading operations",
    "config_path": "/path/to/single-tool.yaml",
    "tool_refs": ["builtin/read_file", ...],
    "includes": [],
    "mcp_servers": [],
    "agent_skills": [],
    "sources": ["builtin"],
    "created": "...",
    "updated": "...",
    "is_new": true
  },
  "timing": { "duration_ms": 0 },
  "messages": [{ "level": "ok", "text": "ok" }]
}

Key Differences:

Spec	Implementation	Issue
`data.skill.name`	`data.name`	Skill data not nested under `skill` key
`data.skill.config`	`data.config_path`	Wrong field name
`data.tool_sources` (array with details)	`data.sources` (array of strings)	Missing `tool_sources` with count/details
`data.total_tools`	Missing	Total tool count not in JSON output
`data.includes[].status`	`data.includes` (empty array)	Include status not shown
`messages[].text` = "Skill registered with N tools"	`messages[].text` = "ok"	Wrong message text
`command` = actual command string	`command` = ""	Empty command field

Steps to Reproduce

from typer.testing import CliRunner
from cleveragents.cli.commands.skill import app, _reset_skill_service
from cleveragents.application.services.skill_service import SkillService
import json

runner = CliRunner()
_reset_skill_service(SkillService())
result = runner.invoke(app, ['add', '--config', './examples/skills/single-tool.yaml', '--format', 'json'])
data = json.loads(result.output)
# data['data']['skill']  # KeyError - no 'skill' key
# data['data']['tool_sources']  # KeyError - no 'tool_sources' key

Code Location

src/cleveragents/cli/commands/skill.py:

_print_skill_registered() — missing Details column in Tool Sources table
add() command — _skill_spec_dict() returns flat structure instead of nested spec structure

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Tested by:** UAT tester worker `uat-worker-skill-management-001` **Feature area:** Skill management — `agents skill add` output format **Severity:** Medium — output format mismatch --- ## Summary The `agents skill add` command has two output format issues: 1. The rich output "Tool Sources" table is missing the spec-required "Details" column 2. The JSON output uses a flat data structure instead of the spec-required nested structure with `data.skill`, `data.includes`, `data.tool_sources`, etc. --- ## Issue 1: Missing "Details" Column in Rich Output ### Expected (from spec, lines 6395–6404): ``` ╭─ Tool Sources ────────────────────────────────╮ │ Source Count Details │ │ ───────────── ───── ─────────────────── │ │ builtin 14 file, dir, git, shell │ │ mcp 6 github (4), linear (2) │ │ agent_skill 2 deploy, code-review │ │ custom 1 run_migrations │ │ ───────────── ───── ─────────────────── │ │ Total: 23 │ ╰───────────────────────────────────────────────╯ ``` ### Actual: ``` ╭─ Tool Sources ──╮ │ Source ┃ Count │ │ ━━━━━━━━╇━━━━━━ │ │ builtin │ 3 │ │ Total │ 3 │ ╰─────────────────╯ ``` The "Details" column (showing tool names/descriptions per source) is completely missing. --- ## Issue 2: JSON Output Structure Mismatch ### Expected (from spec, lines 6449–6479): ```json { "command": "skill add --config ./skills/devops-toolkit.yaml", "status": "ok", "exit_code": 0, "data": { "skill": { "name": "local/devops-toolkit", "description": "Full-stack development tools", "config": "./skills/devops-toolkit.yaml", "created": "2026-02-08T13:10:00Z" }, "includes": [ { "name": "local/file-ops", "status": "registered" } ], "tool_sources": [ { "source": "builtin", "count": 14, "details": "file, dir, git, shell" }, { "source": "mcp", "count": 6, "details": "github (4), linear (2)" } ], "total_tools": 23, "mcp_servers": [ { "name": "linear", "status": "validated", "tools": 2 } ] }, "timing": { "duration_ms": 150 }, "messages": [ { "level": "ok", "text": "Skill registered with 23 tools" } ] } ``` ### Actual: ```json { "command": "", "status": "ok", "exit_code": 0, "data": { "name": "local/file-reader", "namespace": "local", "short_name": "file-reader", "description": "Basic file reading operations", "config_path": "/path/to/single-tool.yaml", "tool_refs": ["builtin/read_file", ...], "includes": [], "mcp_servers": [], "agent_skills": [], "sources": ["builtin"], "created": "...", "updated": "...", "is_new": true }, "timing": { "duration_ms": 0 }, "messages": [{ "level": "ok", "text": "ok" }] } ``` ### Key Differences: | Spec | Implementation | Issue | |---|---|---| | `data.skill.name` | `data.name` | Skill data not nested under `skill` key | | `data.skill.config` | `data.config_path` | Wrong field name | | `data.tool_sources` (array with details) | `data.sources` (array of strings) | Missing `tool_sources` with count/details | | `data.total_tools` | Missing | Total tool count not in JSON output | | `data.includes[].status` | `data.includes` (empty array) | Include status not shown | | `messages[].text` = "Skill registered with N tools" | `messages[].text` = "ok" | Wrong message text | | `command` = actual command string | `command` = "" | Empty command field | ## Steps to Reproduce ```python from typer.testing import CliRunner from cleveragents.cli.commands.skill import app, _reset_skill_service from cleveragents.application.services.skill_service import SkillService import json runner = CliRunner() _reset_skill_service(SkillService()) result = runner.invoke(app, ['add', '--config', './examples/skills/single-tool.yaml', '--format', 'json']) data = json.loads(result.output) # data['data']['skill'] # KeyError - no 'skill' key # data['data']['tool_sources'] # KeyError - no 'tool_sources' key ``` ## Code Location `src/cleveragents/cli/commands/skill.py`: - `_print_skill_registered()` — missing Details column in Tool Sources table - `add()` command — `_skill_spec_dict()` returns flat structure instead of nested spec structure --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 commented

2026-04-08 17:37:10 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified — Well-documented UAT bug report with clear spec references, code locations, and reproduction steps. Valid and actionable.
Priority: Medium — Output format mismatch affects machine-readable consumers but does not block core functionality. Keeping existing Priority/Medium.
Milestone: v3.7.0 — Skill management CLI is part of the v3.7.0 feature-complete target. Output format compliance is needed for the milestone.
Story Points: 3 — S/M — Two distinct fixes needed (rich output Details column + JSON structure), both in the same file. Moderate scope.
MoSCoW: Should Have — Spec compliance for CLI output formats is important for downstream tooling and CI/CD integration, but the skill itself functions correctly.
Parent Epic: #4182 (Epic: Legacy CLI command removal and full verification of CLI interface and workflows)

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified — Well-documented UAT bug report with clear spec references, code locations, and reproduction steps. Valid and actionable. - **Priority**: Medium — Output format mismatch affects machine-readable consumers but does not block core functionality. Keeping existing Priority/Medium. - **Milestone**: v3.7.0 — Skill management CLI is part of the v3.7.0 feature-complete target. Output format compliance is needed for the milestone. - **Story Points**: 3 — S/M — Two distinct fixes needed (rich output Details column + JSON structure), both in the same file. Moderate scope. - **MoSCoW**: Should Have — Spec compliance for CLI output formats is important for downstream tooling and CI/CD integration, but the skill itself functions correctly. - **Parent Epic**: #4182 (Epic: Legacy CLI command removal and full verification of CLI interface and workflows) --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 commented

2026-04-08 17:37:42 +00:00

Author

Owner

🔁 Duplicate Detection

This issue partially duplicates #4531 ("UAT: agents skill add Tool Sources panel missing Details column"), which was filed earlier (2026-04-08T14:18).

Overlap: Both issues report the missing Details column in the agents skill add Tool Sources rich output panel.

Unique content in this issue: The JSON output structure mismatch (data.skill nesting, data.tool_sources vs data.sources, etc.) is NOT covered by #4531.

Action: Closing this issue as a duplicate of #4531. The JSON output structure issue has been noted in a comment on #4531 for tracking.

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: backlog-groomer

## 🔁 Duplicate Detection This issue partially duplicates #4531 ("UAT: `agents skill add` Tool Sources panel missing `Details` column"), which was filed earlier (2026-04-08T14:18). **Overlap:** Both issues report the missing `Details` column in the `agents skill add` Tool Sources rich output panel. **Unique content in this issue:** The JSON output structure mismatch (`data.skill` nesting, `data.tool_sources` vs `data.sources`, etc.) is NOT covered by #4531. **Action:** Closing this issue as a duplicate of #4531. The JSON output structure issue has been noted in a comment on #4531 for tracking. --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: backlog-groomer

HAL9000 referenced this issue

2026-04-08 17:37:47 +00:00

UAT: agents skill add Tool Sources panel missing Details column #4531

HAL9000

2026-04-08 17:38:02 +00:00

closed this issue
added the
Points
3
label

HAL9000 added this to the v3.7.0 milestone

2026-04-08 17:39:30 +00:00

HAL9000 added a new dependency

2026-04-08 17:39:38 +00:00

#4182 Epic: Legacy CLI command removal and full verification of CLI interface and workflows

HAL9000 added

Points

and removed

Points

labels

2026-04-08 20:11:01 +00:00

HAL9000 commented

2026-04-08 20:11:13 +00:00

Author

Owner

State label reconciliation:

Previous state: State/Verified
Corrected to: State/Completed
Reason: Issue is closed but had a non-terminal state label. CONTRIBUTING.md requires closed issues to have State/Completed or State/Wont Do.

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: backlog-groomer

State label reconciliation: - Previous state: `State/Verified` - Corrected to: `State/Completed` - Reason: Issue is closed but had a non-terminal state label. CONTRIBUTING.md requires closed issues to have `State/Completed` or `State/Wont Do`. --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: backlog-groomer

HAL9000 referenced this issue

2026-04-08 20:11:34 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799