UAT: `agents skill show` capability summary missing `Requires Approval` field #4542

New issue

Open

opened 2026-04-08 14:21:50 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-08 14:21:50 +00:00

Owner

Bug Report

Feature Area: Skills CLI — agents skill show capability summary

Expected Behavior (from spec)

The spec (Section "agents skill show", lines 7033-7040) shows the Capability Summary panel with six fields including Requires Approval:

╭─ Capability Summary ──────────╮
│ Total Tools: 23               │
│ Read-Only: 10                 │
│ Writes: 13                    │
│ Checkpointable: 10            │
│ Has Side Effects: 3           │
│ Requires Approval: 1          │
╰───────────────────────────────╯

The Requires Approval field indicates how many tools in the skill require human approval before execution (based on the automation profile).

Actual Behavior (from code)

In src/cleveragents/cli/commands/skill.py, _print_skill_detail function (lines ~340-360):

cap_text = (
    f"[blue]Total Tools:[/blue] {summary.total_tools}\n"
    f"[green]Read-Only:[/green] {summary.read_only_tools}\n"
    f"[yellow]Writes:[/yellow] {summary.write_tools}\n"
    f"[green]Checkpointable:[/green] {summary.checkpointable_tools}\n"
    f"[yellow]Has Side Effects:[/yellow] {summary.has_side_effects}"
)

The Requires Approval field is completely absent from both the rich output and the SkillCapabilitySummary domain model.

Root Cause

The SkillCapabilitySummary model in src/cleveragents/domain/models/core/skill.py does not have a requires_approval field:

class SkillCapabilitySummary(BaseModel):
    total_tools: int
    read_only_tools: int
    write_tools: int
    checkpointable_tools: int
    has_side_effects: bool
    mcp_sources: int
    agent_skill_sources: int
    # ← missing: requires_approval: int

Impact

agents skill show rich output is missing the Requires Approval line
agents skill show --format json capability_summary is missing requires_approval
agents skill tools summary panel is also missing this field

Code Location

src/cleveragents/domain/models/core/skill.py, SkillCapabilitySummary class
src/cleveragents/cli/commands/skill.py, _print_skill_detail and _print_skill_tools

Fix Suggestion

Add requires_approval: int to SkillCapabilitySummary
Compute it in SkillResolver.compute_capability_summary (count tools with requires_approval=True in their capability metadata)
Display it in the CLI output

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** Skills CLI — `agents skill show` capability summary ### Expected Behavior (from spec) The spec (Section "agents skill show", lines 7033-7040) shows the Capability Summary panel with **six fields** including `Requires Approval`: ``` ╭─ Capability Summary ──────────╮ │ Total Tools: 23 │ │ Read-Only: 10 │ │ Writes: 13 │ │ Checkpointable: 10 │ │ Has Side Effects: 3 │ │ Requires Approval: 1 │ ╰───────────────────────────────╯ ``` The `Requires Approval` field indicates how many tools in the skill require human approval before execution (based on the automation profile). ### Actual Behavior (from code) In `src/cleveragents/cli/commands/skill.py`, `_print_skill_detail` function (lines ~340-360): ```python cap_text = ( f"[blue]Total Tools:[/blue] {summary.total_tools}\n" f"[green]Read-Only:[/green] {summary.read_only_tools}\n" f"[yellow]Writes:[/yellow] {summary.write_tools}\n" f"[green]Checkpointable:[/green] {summary.checkpointable_tools}\n" f"[yellow]Has Side Effects:[/yellow] {summary.has_side_effects}" ) ``` The `Requires Approval` field is **completely absent** from both the rich output and the `SkillCapabilitySummary` domain model. ### Root Cause The `SkillCapabilitySummary` model in `src/cleveragents/domain/models/core/skill.py` does not have a `requires_approval` field: ```python class SkillCapabilitySummary(BaseModel): total_tools: int read_only_tools: int write_tools: int checkpointable_tools: int has_side_effects: bool mcp_sources: int agent_skill_sources: int # ← missing: requires_approval: int ``` ### Impact - `agents skill show` rich output is missing the `Requires Approval` line - `agents skill show --format json` capability_summary is missing `requires_approval` - `agents skill tools` summary panel is also missing this field ### Code Location - `src/cleveragents/domain/models/core/skill.py`, `SkillCapabilitySummary` class - `src/cleveragents/cli/commands/skill.py`, `_print_skill_detail` and `_print_skill_tools` ### Fix Suggestion 1. Add `requires_approval: int` to `SkillCapabilitySummary` 2. Compute it in `SkillResolver.compute_capability_summary` (count tools with `requires_approval=True` in their capability metadata) 3. Display it in the CLI output --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added this to the v3.5.0 milestone

2026-04-08 17:41:44 +00:00

HAL9000 added the