feat(security): add permission system #448

Merged

CoreRasurae merged 1 commit from feature/m7-post-permissions into master 2026-02-28 21:07:22 +00:00

Conversation 2 Commits 1 Files changed 14 +2172

CoreRasurae commented 2026-02-25 23:47:03 +00:00

Member

Copy link

Description

Add a namespace/project/plan/skill permission system with role-based access control. Implements four role levels (owner, admin, editor, viewer) with default-deny semantics and configurable allow overrides. Enforcement hooks are applied at CLI/service boundaries and are server-only; local mode returns permissive defaults via CLEVERAGENTS_SERVER_MODE environment variable.

Domain model (permission.py): PermissionRole, PermissionScope, and PermissionAction enums; RoleBinding, PermissionCheck, and PermissionPolicy Pydantic models; ROLE_PERMISSIONS matrix mapping roles to allowed actions per scope; DEFAULT_LOCAL_ROLE_MAPPING for local-mode fallback.

Service (permission_service.py): PermissionService class with check_permission, get_role_bindings, add_binding, remove_binding, and is_local_mode methods; enforce_permission decorator for declarative enforcement at service boundaries; module-level default service pattern with get_default_permission_service().

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactoring (no functional changes)
• Documentation update
• Test improvements
• CI/CD changes

Quality Checklist

• Code follows the project's coding standards (see CONTRIBUTING.md)
• All public/protected methods have argument validation
• Static typing is complete (no Any unless justified)
• nox -s typecheck passes with no errors
• nox -s lint passes with no errors
• Unit tests written/updated (Behave scenarios in features/)
• Integration tests written/updated (Robot suites in robot/) if applicable
• Coverage remains above 85% (nox -s coverage_report)
• No security issues introduced (nox -s security_scan)
• No dead code introduced (nox -s dead_code)
• Documentation updated if behavior changed

Testing

43 BDD scenarios in features/permission_system.feature covering allow/deny decisions, missing roles, server-disabled local mode, role binding CRUD, scope/action matrix, and decorator enforcement. 18 Robot Framework integration tests in robot/permission_system.robot with stubbed server client. Reference documentation in docs/reference/permissions.md.

Test Commands Run

nox -s unit_tests        # Behave tests
nox -s typecheck         # Type checking
nox -s lint              # Linting
nox -s coverage_report   # Coverage

Related Issues

Closes #344

Implementation Notes

• Server mode is toggled by the CLEVERAGENTS_SERVER_MODE environment variable. When unset or falsy, all permission checks return allow (local mode).
• The enforce_permission decorator extracts scope and action from function arguments and raises PermissionError when access is denied in server mode.
• Role hierarchy is flat (no inheritance); each role has an explicit set of allowed actions per scope defined in ROLE_PERMISSIONS.
• DEFAULT_LOCAL_ROLE_MAPPING provides a sensible owner-level binding for local-mode operations so that code paths requiring a role binding still function without a server.

## Description Add a namespace/project/plan/skill permission system with role-based access control. Implements four role levels (owner, admin, editor, viewer) with default-deny semantics and configurable allow overrides. Enforcement hooks are applied at CLI/service boundaries and are server-only; local mode returns permissive defaults via `CLEVERAGENTS_SERVER_MODE` environment variable. **Domain model** (`permission.py`): `PermissionRole`, `PermissionScope`, and `PermissionAction` enums; `RoleBinding`, `PermissionCheck`, and `PermissionPolicy` Pydantic models; `ROLE_PERMISSIONS` matrix mapping roles to allowed actions per scope; `DEFAULT_LOCAL_ROLE_MAPPING` for local-mode fallback. **Service** (`permission_service.py`): `PermissionService` class with `check_permission`, `get_role_bindings`, `add_binding`, `remove_binding`, and `is_local_mode` methods; `enforce_permission` decorator for declarative enforcement at service boundaries; module-level default service pattern with `get_default_permission_service()`. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactoring (no functional changes) - [ ] Documentation update - [ ] Test improvements - [ ] CI/CD changes ## Quality Checklist - [x] Code follows the project's coding standards (see CONTRIBUTING.md) - [x] All public/protected methods have argument validation - [x] Static typing is complete (no `Any` unless justified) - [x] `nox -s typecheck` passes with no errors - [x] `nox -s lint` passes with no errors - [x] Unit tests written/updated (Behave scenarios in `features/`) - [x] Integration tests written/updated (Robot suites in `robot/`) if applicable - [x] Coverage remains above 85% (`nox -s coverage_report`) - [x] No security issues introduced (`nox -s security_scan`) - [x] No dead code introduced (`nox -s dead_code`) - [x] Documentation updated if behavior changed ## Testing 43 BDD scenarios in `features/permission_system.feature` covering allow/deny decisions, missing roles, server-disabled local mode, role binding CRUD, scope/action matrix, and decorator enforcement. 18 Robot Framework integration tests in `robot/permission_system.robot` with stubbed server client. Reference documentation in `docs/reference/permissions.md`. ### Test Commands Run ```bash nox -s unit_tests # Behave tests nox -s typecheck # Type checking nox -s lint # Linting nox -s coverage_report # Coverage ``` ## Related Issues Closes #344 ## Implementation Notes - Server mode is toggled by the `CLEVERAGENTS_SERVER_MODE` environment variable. When unset or falsy, all permission checks return allow (local mode). - The `enforce_permission` decorator extracts scope and action from function arguments and raises `PermissionError` when access is denied in server mode. - Role hierarchy is flat (no inheritance); each role has an explicit set of allowed actions per scope defined in `ROLE_PERMISSIONS`. - `DEFAULT_LOCAL_ROLE_MAPPING` provides a sensible owner-level binding for local-mode operations so that code paths requiring a role binding still function without a server.

CoreRasurae added this to the v3.6.0 milestone 2026-02-25 23:47:10 +00:00

CoreRasurae added the

Type

Feature

label 2026-02-25 23:47:10 +00:00

CoreRasurae referenced this pull request 2026-02-25 23:47:29 +00:00

feat(security): add permission system #344

CoreRasurae force-pushed feature/m7-post-permissions from e907ffa473 to 44ed1208e4 2026-02-26 22:03:24 +00:00 Compare

CoreRasurae requested review from brent.edwards 2026-02-26 22:29:14 +00:00

brent.edwards reviewed 2026-02-26 22:34:49 +00:00

brent.edwards left a comment

Copy link

Review Summary

Scope: new permission system domain models + PermissionService + tests/bench/docs. Security-sensitive area reviewed per playbook.

CI status isn’t visible via the API on my side. Please confirm required checks per docs/development/ci-cd.md are green (lint, typecheck, security, quality, unit_tests, integration_tests, coverage, build, docker).

Findings

P2:should-fix — PermissionService.check_permission() does not validate/normalize principal or scope_id. RoleBinding trims/validates, but checks accept raw strings, so whitespace or empty values can silently miss bindings. Recommend stripping + empty checks (raise ValueError) or normalizing via a small helper before key lookup.

• Code: src/cleveragents/application/services/permission_service.py (check_permission)

P2:should-fix — Docs and docstrings imply “server-side enforcement deferred” and “hooks at CLI/service boundaries”, but there are no call sites wiring enforce_permission into CLI or services yet. Please align docs with current behavior or add a minimal integration point.

• Doc: docs/reference/permissions.md
• Code: src/cleveragents/application/services/permission_service.py (module docstring)

P3:nit — docs/reference/permissions.md isn’t listed in the reference nav. Add it to docs/gen_ref_pages.py so it shows in the Reference sidebar.

Positive Notes

• Domain model + service API shape is clean and matches existing patterns.
• Behave + Robot coverage is comprehensive for local/server mode behavior.
• Benchmarks are clear and use the same env toggles as tests.

## Review Summary Scope: new permission system domain models + PermissionService + tests/bench/docs. Security-sensitive area reviewed per playbook. CI status isn’t visible via the API on my side. Please confirm required checks per `docs/development/ci-cd.md` are green (lint, typecheck, security, quality, unit_tests, integration_tests, coverage, build, docker). ## Findings **P2:should-fix** — `PermissionService.check_permission()` does not validate/normalize `principal` or `scope_id`. RoleBinding trims/validates, but checks accept raw strings, so whitespace or empty values can silently miss bindings. Recommend stripping + empty checks (raise ValueError) or normalizing via a small helper before key lookup. - Code: `src/cleveragents/application/services/permission_service.py` (`check_permission`) **P2:should-fix** — Docs and docstrings imply “server-side enforcement deferred” and “hooks at CLI/service boundaries”, but there are no call sites wiring `enforce_permission` into CLI or services yet. Please align docs with current behavior or add a minimal integration point. - Doc: `docs/reference/permissions.md` - Code: `src/cleveragents/application/services/permission_service.py` (module docstring) **P3:nit** — `docs/reference/permissions.md` isn’t listed in the reference nav. Add it to `docs/gen_ref_pages.py` so it shows in the Reference sidebar. ## Positive Notes - Domain model + service API shape is clean and matches existing patterns. - Behave + Robot coverage is comprehensive for local/server mode behavior. - Benchmarks are clear and use the same env toggles as tests.

CoreRasurae force-pushed feature/m7-post-permissions from 44ed1208e4 to 30eee519ca 2026-02-27 17:13:18 +00:00 Compare

brent.edwards approved these changes 2026-02-27 20:25:20 +00:00

Dismissed

brent.edwards left a comment

Copy link

Approved!

Approved!

CoreRasurae force-pushed feature/m7-post-permissions from 30eee519ca to 64af753aab 2026-02-28 20:21:31 +00:00 Compare

CoreRasurae dismissed brent.edwards's review 2026-02-28 20:21:31 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

CoreRasurae scheduled this pull request to auto merge when all checks succeed 2026-02-28 20:33:14 +00:00

CoreRasurae merged commit 64af753aab into master 2026-02-28 21:07:22 +00:00

CoreRasurae deleted branch feature/m7-post-permissions 2026-02-28 21:07:22 +00:00

freemo added the

State

Completed

label 2026-03-04 00:58:39 +00:00

HAL9000 referenced this pull request 2026-04-18 17:13:50 +00:00

[AUTO-UAT-POOL] Status: v3.6.0 & v3.7.0 Feature Validation (Cycle 1) #10557

HAL9000 referenced this pull request 2026-04-18 18:47:52 +00:00

[AUTO-UAT-POOL] Status: v3.6.0 & v3.7.0 Feature Validation (Cycle 1) #10557

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v3.6.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveragents-core!448

No description provided.