UAT: `tdd_checkpoint_real_rollback.feature` still marked `@skip` despite `CheckpointService.rollback_to_checkpoint()` now executing real `git reset --hard` — stale TDD test needs to be re-enabled #4443

New issue

Open

opened 2026-04-08 12:42:23 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-08 12:42:23 +00:00

Owner

Metadata

Milestone: (none — backlog)
Parent Epic: (sandbox and checkpoint safety)

Bug Report

What Was Tested

The features/tdd_checkpoint_real_rollback.feature file was analyzed against the current CheckpointService implementation.

Expected Behavior

The TDD test file features/tdd_checkpoint_real_rollback.feature was created to capture bug #822 where rollback_to_checkpoint() was simulated rather than executing real git operations. Once the bug is fixed, the @skip tags should be removed and the tests should pass.

Actual Behavior

The feature file is still marked @skip:

# @tdd_issue @tdd_issue_822 @tdd_expected_fail @tdd_issue_4178 @skip
@skip
Feature: TDD Issue #822 — checkpoint rollback is simulated, does not execute real git reset

However, examining the current CheckpointService.rollback_to_checkpoint() implementation in src/cleveragents/application/services/checkpoint_service.py, the method now does execute real git operations:

# Execute real git reset --hard to restore sandbox to checkpoint
self._git_reset_hard(sandbox_path, sandbox_ref)

# Remove untracked files that were added after the checkpoint
self._git_clean(sandbox_path)

The _git_reset_hard() and _git_clean() methods call subprocess.run(["git", "reset", "--hard", ...]) and subprocess.run(["git", "clean", "-fd"]) respectively.

Furthermore, the checkpoint_rollback.feature file now includes new scenarios that test real git rollback behavior (e.g., "Rollback reverts modified file content to checkpoint state", "Rollback removes files added after the checkpoint"), suggesting the fix was implemented.

Code Locations

TDD test file: features/tdd_checkpoint_real_rollback.feature
Implementation: src/cleveragents/application/services/checkpoint_service.py (rollback_to_checkpoint, _git_reset_hard, _git_clean)
New real-rollback tests: features/checkpoint_rollback.feature (last ~20 scenarios)

Fix Required

Remove the @skip tag from features/tdd_checkpoint_real_rollback.feature
Update the feature file description to reflect that the bug has been fixed
Verify the scenarios pass with the current implementation
Close issue #4276 once the tests pass

Note: This is related to open issue #4276 ("fix(unit-test): tdd_checkpoint_real_rollback — 2 scenario(s) failing").

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Metadata - **Milestone**: *(none — backlog)* - **Parent Epic**: *(sandbox and checkpoint safety)* ## Bug Report ### What Was Tested The `features/tdd_checkpoint_real_rollback.feature` file was analyzed against the current `CheckpointService` implementation. ### Expected Behavior The TDD test file `features/tdd_checkpoint_real_rollback.feature` was created to capture bug #822 where `rollback_to_checkpoint()` was simulated rather than executing real git operations. Once the bug is fixed, the `@skip` tags should be removed and the tests should pass. ### Actual Behavior The feature file is still marked `@skip`: ``` # @tdd_issue @tdd_issue_822 @tdd_expected_fail @tdd_issue_4178 @skip @skip Feature: TDD Issue #822 — checkpoint rollback is simulated, does not execute real git reset ``` However, examining the current `CheckpointService.rollback_to_checkpoint()` implementation in `src/cleveragents/application/services/checkpoint_service.py`, the method now **does** execute real git operations: ```python # Execute real git reset --hard to restore sandbox to checkpoint self._git_reset_hard(sandbox_path, sandbox_ref) # Remove untracked files that were added after the checkpoint self._git_clean(sandbox_path) ``` The `_git_reset_hard()` and `_git_clean()` methods call `subprocess.run(["git", "reset", "--hard", ...])` and `subprocess.run(["git", "clean", "-fd"])` respectively. Furthermore, the `checkpoint_rollback.feature` file now includes new scenarios that test real git rollback behavior (e.g., "Rollback reverts modified file content to checkpoint state", "Rollback removes files added after the checkpoint"), suggesting the fix was implemented. ### Code Locations - TDD test file: `features/tdd_checkpoint_real_rollback.feature` - Implementation: `src/cleveragents/application/services/checkpoint_service.py` (`rollback_to_checkpoint`, `_git_reset_hard`, `_git_clean`) - New real-rollback tests: `features/checkpoint_rollback.feature` (last ~20 scenarios) ### Fix Required 1. Remove the `@skip` tag from `features/tdd_checkpoint_real_rollback.feature` 2. Update the feature file description to reflect that the bug has been fixed 3. Verify the scenarios pass with the current implementation 4. Close issue #4276 once the tests pass Note: This is related to open issue #4276 ("fix(unit-test): tdd_checkpoint_real_rollback — 2 scenario(s) failing"). --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added this to the v3.5.0 milestone

2026-04-08 17:42:26 +00:00

HAL9000 added the