UAT: `agents lsp add` duplicate server error message says "already registered" instead of spec-required "already exists" #4404

New issue

Open

opened 2026-04-08 12:14:44 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-08 12:14:44 +00:00

Owner

Summary

The agents lsp add command produces a different error message when a duplicate server is registered than what the specification requires.

Expected Behavior (from spec, lines 8749-8751)

$ agents lsp add --config lsp/pyright.yaml

✗ ERROR LSP server 'local/pyright' already exists
Hint: Use --update to overwrite: agents lsp add --update --config lsp/pyright.yaml

The spec requires the error message: LSP server 'local/pyright' already exists

Actual Behavior

From src/cleveragents/lsp/registry.py (line 64):

raise ValueError(f"LSP server '{config.name}' is already registered")

The implementation raises: LSP server 'local/pyright' is already registered

Additionally, the hint format in the CLI (src/cleveragents/cli/commands/lsp.py, lines 188-191) is:

To overwrite, re-run with --update:
  agents lsp add --config lsp/pyright.yaml --update

But the spec shows:

Hint: Use --update to overwrite: agents lsp add --update --config lsp/pyright.yaml

Differences:

Error message: "already registered" vs spec's "already exists"
Hint prefix: "To overwrite, re-run with --update:" vs spec's "Hint: Use --update to overwrite:"
Hint command order: --config ... --update vs spec's --update --config ...

Code Locations

src/cleveragents/lsp/registry.py, line 64: error message
src/cleveragents/cli/commands/lsp.py, lines 186-192: hint formatting

Steps to Reproduce

Register an LSP server: agents lsp add --config lsp/pyright.yaml
Try to register the same server again: agents lsp add --config lsp/pyright.yaml
Observe the error message says "already registered" instead of "already exists"

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Summary The `agents lsp add` command produces a different error message when a duplicate server is registered than what the specification requires. ## Expected Behavior (from spec, lines 8749-8751) ``` $ agents lsp add --config lsp/pyright.yaml ✗ ERROR LSP server 'local/pyright' already exists Hint: Use --update to overwrite: agents lsp add --update --config lsp/pyright.yaml ``` The spec requires the error message: `LSP server 'local/pyright' already exists` ## Actual Behavior From `src/cleveragents/lsp/registry.py` (line 64): ```python raise ValueError(f"LSP server '{config.name}' is already registered") ``` The implementation raises: `LSP server 'local/pyright' is already registered` Additionally, the hint format in the CLI (`src/cleveragents/cli/commands/lsp.py`, lines 188-191) is: ``` To overwrite, re-run with --update: agents lsp add --config lsp/pyright.yaml --update ``` But the spec shows: ``` Hint: Use --update to overwrite: agents lsp add --update --config lsp/pyright.yaml ``` Differences: 1. Error message: `"already registered"` vs spec's `"already exists"` 2. Hint prefix: `"To overwrite, re-run with --update:"` vs spec's `"Hint: Use --update to overwrite:"` 3. Hint command order: `--config ... --update` vs spec's `--update --config ...` ## Code Locations - `src/cleveragents/lsp/registry.py`, line 64: error message - `src/cleveragents/cli/commands/lsp.py`, lines 186-192: hint formatting ## Steps to Reproduce 1. Register an LSP server: `agents lsp add --config lsp/pyright.yaml` 2. Try to register the same server again: `agents lsp add --config lsp/pyright.yaml` 3. Observe the error message says "already registered" instead of "already exists" --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added this to the v3.5.0 milestone

2026-04-08 17:42:54 +00:00

HAL9000 added the