Fix CLI extensions action show JSON format test failure #4361

Open
opened 2026-04-08 05:08:38 +00:00 by freemo · 0 comments
Owner

Metadata

  • Commit Message: fix(cli): action show JSON format contains all required keys
  • Branch: fix/cli-action-show-json-format

Background and Context

The CLI extensions test "Action show in JSON format contains all required keys" (features/cli_extensions.feature:321) is failing. This test verifies that the agents action show --format json command output contains the required keys: "estimation_actor", "strategy_actor", "execution_actor", and "description".

Current Behavior

The test is failing, indicating that the JSON output from agents action show --format json is either:

  • Not valid JSON
  • Missing one or more required keys
  • Has incorrect key names or structure

Expected Behavior

The agents action show --format json command should output valid JSON containing at minimum:

  • estimation_actor key
  • strategy_actor key
  • execution_actor key
  • description key

Acceptance Criteria

  • The CLI extensions test "Action show in JSON format contains all required keys" passes
  • agents action show --format json outputs valid JSON
  • The JSON output contains all required keys with appropriate values
  • No regression in other CLI format functionality

Subtasks

  • Investigate the current JSON output structure from agents action show --format json
  • Identify which required keys are missing or incorrectly named
  • Fix the JSON serialization to include all required keys
  • Verify the test passes after the fix
  • Run full test suite to ensure no regressions
  • Verify coverage ≥97% via nox -s coverage_report

Definition of Done

This issue is complete when:

  • All subtasks above are completed and checked off
  • The failing test now passes
  • A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly
  • The commit is pushed to the remote on the branch matching the Branch in Metadata exactly
  • The commit is submitted as a pull request to master, reviewed, and merged
## Metadata - **Commit Message**: `fix(cli): action show JSON format contains all required keys` - **Branch**: `fix/cli-action-show-json-format` ## Background and Context The CLI extensions test "Action show in JSON format contains all required keys" (features/cli_extensions.feature:321) is failing. This test verifies that the `agents action show --format json` command output contains the required keys: "estimation_actor", "strategy_actor", "execution_actor", and "description". ## Current Behavior The test is failing, indicating that the JSON output from `agents action show --format json` is either: - Not valid JSON - Missing one or more required keys - Has incorrect key names or structure ## Expected Behavior The `agents action show --format json` command should output valid JSON containing at minimum: - `estimation_actor` key - `strategy_actor` key - `execution_actor` key - `description` key ## Acceptance Criteria - The CLI extensions test "Action show in JSON format contains all required keys" passes - `agents action show --format json` outputs valid JSON - The JSON output contains all required keys with appropriate values - No regression in other CLI format functionality ## Subtasks - [ ] Investigate the current JSON output structure from `agents action show --format json` - [ ] Identify which required keys are missing or incorrectly named - [ ] Fix the JSON serialization to include all required keys - [ ] Verify the test passes after the fix - [ ] Run full test suite to ensure no regressions - [ ] Verify coverage ≥97% via `nox -s coverage_report` ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off - The failing test now passes - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly - The commit is submitted as a **pull request** to `master`, reviewed, and **merged**
HAL9000 self-assigned this 2026-04-08 11:41:31 +00:00
HAL9000 added this to the v3.5.0 milestone 2026-04-08 11:41:31 +00:00
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#4361