Fix skill add cross-process persistence test failure #4193

New issue

Closed

opened 2026-04-06 23:14:47 +00:00 by freemo · 0 comments

freemo commented

2026-04-06 23:14:47 +00:00

Owner

Problem

The skill add regression test in features/tdd_skill_add_regression.feature is currently failing and has been tagged with @tdd_expected_fail to allow CI to pass.

Tests Affected

The feature-level test in features/tdd_skill_add_regression.feature marked with @tdd_issue @tdd_issue_980:

skill add in one process is visible to skill list in another
skill add persists config path across processes

Root Cause

Bug #980 reports that skills registered via agents skill add in one CLI process are not visible when agents skill list is run in a separate CLI process. The file comment indicates:

"Originally tagged @tdd_expected_fail while the bug was unfixed; tag removed after fix in #980."

However, since we're re-adding the @tdd_expected_fail tag, it appears the fix may not be complete or there's been a regression.

Context

The test verifies cross-process persistence by using real subprocess invocations — the skill is added via one CLI invocation and listed via an independent CLI invocation, both sharing the same on-disk SQLite database. This is different from existing persistence tests that verify round-trip within the same Python process.

Definition of Done

Investigate why the cross-process persistence is failing
Fix the underlying persistence issue
Ensure skills added in one CLI process are visible in another
Remove @tdd_expected_fail tag from the feature
Verify all tests pass without the expected fail tags
CI shows all tests passing

Priority

Medium - Skill persistence is important for workflow continuity but not blocking core functionality.

Labels

Type/Bug
Priority/Medium
Component/Skills
Component/Persistence
TDD/Expected-Fail

## Problem The skill add regression test in `features/tdd_skill_add_regression.feature` is currently failing and has been tagged with `@tdd_expected_fail` to allow CI to pass. ## Tests Affected The feature-level test in `features/tdd_skill_add_regression.feature` marked with `@tdd_issue @tdd_issue_980`: - skill add in one process is visible to skill list in another - skill add persists config path across processes ## Root Cause Bug #980 reports that skills registered via `agents skill add` in one CLI process are not visible when `agents skill list` is run in a separate CLI process. The file comment indicates: "Originally tagged @tdd_expected_fail while the bug was unfixed; tag removed after fix in #980." However, since we're re-adding the @tdd_expected_fail tag, it appears the fix may not be complete or there's been a regression. ## Context The test verifies cross-process persistence by using real subprocess invocations — the skill is added via one CLI invocation and listed via an independent CLI invocation, both sharing the same on-disk SQLite database. This is different from existing persistence tests that verify round-trip within the same Python process. ## Definition of Done 1. [ ] Investigate why the cross-process persistence is failing 2. [ ] Fix the underlying persistence issue 3. [ ] Ensure skills added in one CLI process are visible in another 4. [ ] Remove `@tdd_expected_fail` tag from the feature 5. [ ] Verify all tests pass without the expected fail tags 6. [ ] CI shows all tests passing ## Priority Medium - Skill persistence is important for workflow continuity but not blocking core functionality. ## Labels - Type/Bug - Priority/Medium - Component/Skills - Component/Persistence - TDD/Expected-Fail

freemo referenced this issue

2026-04-06 23:15:15 +00:00

fix: restore CI quality tests to passing state #4175

freemo referenced this issue

2026-04-07 00:09:41 +00:00

fix: restore CI quality tests to passing state #4175

freemo referenced this issue

2026-04-07 00:45:14 +00:00

Restore test coverage threshold to 97% after TDD test fixes #4195

freemo closed this issue

2026-04-07 18:14:38 +00:00