Fix subplan spawn orchestration test failures #4192

New issue

Open

opened 2026-04-06 23:14:28 +00:00 by freemo · 0 comments

freemo commented

2026-04-06 23:14:28 +00:00

Owner

Problem

The subplan spawn orchestration tests in features/tdd_subplan_spawn_orchestration.feature are currently failing and have been tagged with @tdd_expected_fail to allow CI to pass.

Tests Affected

All 3 scenarios in features/tdd_subplan_spawn_orchestration.feature that are marked with @tdd_issue @tdd_issue_823:

Spawn result contains child Plan domain objects
Child plans enter the strategize phase after spawn
Parent plan tracks child plan lifecycle status

Root Cause

Bug #823 reports that SubplanService.spawn() creates metadata but does not orchestrate child plan execution. The feature file states:

"SubplanService.spawn() currently creates SubplanStatus records and SpawnMetadata but does NOT create actual child Plan domain objects, trigger the strategize phase on child plans, set up inter-plan communication, merge results, or handle child plan failures."

This is a significant architectural issue where the subplan spawning mechanism is incomplete.

Definition of Done

Implement creation of actual child Plan domain objects in SubplanService.spawn()
Implement triggering of strategize phase on child plans
Set up inter-plan communication mechanisms
Implement result merging from child plans
Add failure handling for child plans
Remove @tdd_expected_fail tags from all scenarios
Verify all tests pass without the expected fail tags
CI shows all tests passing

Priority

High - Subplan orchestration is a critical feature for complex agent workflows.

Labels

Type/Bug
Priority/High
Component/Planning
Component/Orchestration
TDD/Expected-Fail

## Problem The subplan spawn orchestration tests in `features/tdd_subplan_spawn_orchestration.feature` are currently failing and have been tagged with `@tdd_expected_fail` to allow CI to pass. ## Tests Affected All 3 scenarios in `features/tdd_subplan_spawn_orchestration.feature` that are marked with `@tdd_issue @tdd_issue_823`: - Spawn result contains child Plan domain objects - Child plans enter the strategize phase after spawn - Parent plan tracks child plan lifecycle status ## Root Cause Bug #823 reports that SubplanService.spawn() creates metadata but does not orchestrate child plan execution. The feature file states: "SubplanService.spawn() currently creates SubplanStatus records and SpawnMetadata but does NOT create actual child Plan domain objects, trigger the strategize phase on child plans, set up inter-plan communication, merge results, or handle child plan failures." This is a significant architectural issue where the subplan spawning mechanism is incomplete. ## Definition of Done 1. [ ] Implement creation of actual child Plan domain objects in SubplanService.spawn() 2. [ ] Implement triggering of strategize phase on child plans 3. [ ] Set up inter-plan communication mechanisms 4. [ ] Implement result merging from child plans 5. [ ] Add failure handling for child plans 6. [ ] Remove `@tdd_expected_fail` tags from all scenarios 7. [ ] Verify all tests pass without the expected fail tags 8. [ ] CI shows all tests passing ## Priority High - Subplan orchestration is a critical feature for complex agent workflows. ## Labels - Type/Bug - Priority/High - Component/Planning - Component/Orchestration - TDD/Expected-Fail

Rows
Columns