Fix session create error test failures (DI container issue) #4191

New issue

Open

opened 2026-04-06 23:14:13 +00:00 by freemo · 0 comments

freemo commented

2026-04-06 23:14:13 +00:00

Owner

Problem

The session create error tests in features/session_create_error.feature are currently failing and have been tagged with @tdd_expected_fail to allow CI to pass.

Tests Affected

All 4 scenarios in features/session_create_error.feature that are marked with @tdd_issue @tdd_issue_570:

Session create produces a new session
Created session persists and can be retrieved
Session create with custom actor succeeds
Session create with arbitrary actor name succeeds

Root Cause

Bug #570 reports that the DI container fix for session create command is not working correctly. The file comment indicates that these are "regression tests for bug #570 — verifies that the DI container fix for session create command works correctly." The comment also mentions "The @tdd_expected_fail tags have been removed now that the fix has landed" but the tests are still failing, suggesting the fix may not be complete or there's a regression.

Definition of Done

Investigate why the session create tests are failing after the fix was supposedly applied
Fix the underlying DI container wiring issue
Remove @tdd_expected_fail tags from all scenarios
Verify all tests pass without the expected fail tags
CI shows all tests passing

Priority

High - Session creation is a core functionality and DI container issues can affect many parts of the system.

Labels

Type/Bug
Priority/High
Component/DI
Component/CLI
TDD/Expected-Fail

## Problem The session create error tests in `features/session_create_error.feature` are currently failing and have been tagged with `@tdd_expected_fail` to allow CI to pass. ## Tests Affected All 4 scenarios in `features/session_create_error.feature` that are marked with `@tdd_issue @tdd_issue_570`: - Session create produces a new session - Created session persists and can be retrieved - Session create with custom actor succeeds - Session create with arbitrary actor name succeeds ## Root Cause Bug #570 reports that the DI container fix for session create command is not working correctly. The file comment indicates that these are "regression tests for bug #570 — verifies that the DI container fix for session create command works correctly." The comment also mentions "The @tdd_expected_fail tags have been removed now that the fix has landed" but the tests are still failing, suggesting the fix may not be complete or there's a regression. ## Definition of Done 1. [ ] Investigate why the session create tests are failing after the fix was supposedly applied 2. [ ] Fix the underlying DI container wiring issue 3. [ ] Remove `@tdd_expected_fail` tags from all scenarios 4. [ ] Verify all tests pass without the expected fail tags 5. [ ] CI shows all tests passing ## Priority High - Session creation is a core functionality and DI container issues can affect many parts of the system. ## Labels - Type/Bug - Priority/High - Component/DI - Component/CLI - TDD/Expected-Fail

Rows
Columns