cleveragents/cleveragents-core

Fork 3

Add missing `local/strategist` and `local/executor` actor definitions referenced by `examples/actions/simple.yaml` #4187

New issue

Open

opened 2026-04-06 22:10:14 +00:00 by brent.edwards · 2 comments

brent.edwards commented

2026-04-06 22:10:14 +00:00

Member

Metadata

Commit Message: feat(examples): add local/strategist and local/executor actor definitions for simple action
Branch: feat/examples-simple-action-actors

Background and Context

The example action examples/actions/simple.yaml is described as the minimal valid action configuration and is the primary entry point for new users exploring the examples. It references two actors by convention — local/strategist (line 11) and local/executor (line 12) — but no corresponding actor YAML definitions exist anywhere in the examples/actors/ directory.

As a result, a user who follows the example (e.g. via agents action create --config examples/actions/simple.yaml) can create the action successfully but cannot execute it, because neither referenced actor is registered. The examples directory should be self-contained: every actor referenced by an example action must itself have an example definition.

There is also no test verifying that the example action works end-to-end with these actors in place.

Current Behavior

Running agents action create --config examples/actions/simple.yaml succeeds, but the action cannot be used because the required actors are absent.

No files exist at:

examples/actors/strategist.yaml
examples/actors/executor.yaml

No test verifies that examples/actions/simple.yaml works end-to-end.

Expected Behavior

examples/actors/strategist.yaml exists and defines a valid local/strategist actor.
examples/actors/executor.yaml exists and defines a valid local/executor actor.
An end-to-end test confirms that examples/actions/simple.yaml can be created and executed once those actors are registered.

Acceptance Criteria

examples/actors/strategist.yaml is a valid actor config that registers successfully via agents actor add local/strategist --config examples/actors/strategist.yaml.
examples/actors/executor.yaml is a valid actor config that registers successfully via agents actor add local/executor --config examples/actors/executor.yaml.
A test verifies the full workflow: register both actors, create the action from simple.yaml, and confirm the action is executable without errors.
All existing tests continue to pass.

Supporting Information

The incomplete action example is at examples/actions/simple.yaml.
Existing example actors in examples/actors/ that can serve as reference: simple_llm.yaml, estimator.yaml, code_review.yaml, and others.
The actor schema and required fields are defined in src/cleveragents/actor/schema.py.

Subtasks

Create examples/actors/strategist.yaml defining the local/strategist actor
Create examples/actors/executor.yaml defining the local/executor actor
Tests (Behave): Add scenario verifying both actors can be registered and simple.yaml can be created and executed
Tests (Robot): Add integration test covering the complete simple.yaml workflow end-to-end
Verify coverage ≥97% via nox -s coverage_report
Run nox (all default sessions), fix any errors

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message**: `feat(examples): add local/strategist and local/executor actor definitions for simple action` - **Branch**: `feat/examples-simple-action-actors` ## Background and Context The example action `examples/actions/simple.yaml` is described as the minimal valid action configuration and is the primary entry point for new users exploring the examples. It references two actors by convention — `local/strategist` (line 11) and `local/executor` (line 12) — but no corresponding actor YAML definitions exist anywhere in the `examples/actors/` directory. As a result, a user who follows the example (e.g. via `agents action create --config examples/actions/simple.yaml`) can create the action successfully but cannot execute it, because neither referenced actor is registered. The examples directory should be self-contained: every actor referenced by an example action must itself have an example definition. There is also no test verifying that the example action works end-to-end with these actors in place. ## Current Behavior Running `agents action create --config examples/actions/simple.yaml` succeeds, but the action cannot be used because the required actors are absent. No files exist at: - `examples/actors/strategist.yaml` - `examples/actors/executor.yaml` No test verifies that `examples/actions/simple.yaml` works end-to-end. ## Expected Behavior - `examples/actors/strategist.yaml` exists and defines a valid `local/strategist` actor. - `examples/actors/executor.yaml` exists and defines a valid `local/executor` actor. - An end-to-end test confirms that `examples/actions/simple.yaml` can be created and executed once those actors are registered. ## Acceptance Criteria - `examples/actors/strategist.yaml` is a valid actor config that registers successfully via `agents actor add local/strategist --config examples/actors/strategist.yaml`. - `examples/actors/executor.yaml` is a valid actor config that registers successfully via `agents actor add local/executor --config examples/actors/executor.yaml`. - A test verifies the full workflow: register both actors, create the action from `simple.yaml`, and confirm the action is executable without errors. - All existing tests continue to pass. ## Supporting Information - The incomplete action example is at [`examples/actions/simple.yaml`](https://git.cleverthis.com/cleveragents/cleveragents-core/src/branch/master/examples/actions/simple.yaml). - Existing example actors in `examples/actors/` that can serve as reference: `simple_llm.yaml`, `estimator.yaml`, `code_review.yaml`, and others. - The actor schema and required fields are defined in `src/cleveragents/actor/schema.py`. ## Subtasks - [ ] Create `examples/actors/strategist.yaml` defining the `local/strategist` actor - [ ] Create `examples/actors/executor.yaml` defining the `local/executor` actor - [ ] Tests (Behave): Add scenario verifying both actors can be registered and `simple.yaml` can be created and executed - [ ] Tests (Robot): Add integration test covering the complete `simple.yaml` workflow end-to-end - [ ] Verify coverage ≥97% via `nox -s coverage_report` - [ ] Run `nox` (all default sessions), fix any errors ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

brent.edwards added this to the v3.2.0 milestone

2026-04-06 22:10:14 +00:00

brent.edwards added the

labels

2026-04-06 22:10:14 +00:00

brent.edwards changed title from ~~examples/action/simple.yaml should be completed.~~ to Add missing local/strategist and local/executor actor definitions referenced by examples/actions/simple.yaml

2026-04-06 22:12:03 +00:00

freemo removed this from the v3.2.0 milestone

2026-04-06 22:20:50 +00:00

freemo commented

2026-04-06 22:20:54 +00:00

Owner

This issue is being moved to the backlog. This issue is related to missing example files that prevent a user from running a specific example. While this is a valid issue, it does not affect the core functionality of the application. The user can still create and run other actions. This is a "Could have" and can be addressed in a future release.

HAL9000 commented

2026-04-08 11:32:35 +00:00

Owner

Issue triaged by project owner:

State: Verified ✅ — Missing actor definitions referenced by example actions
Priority: Medium ✅ (already set) — Examples should work out of the box
MoSCoW: Could Have ✅ (already set) — Nice-to-have for examples completeness
Story Points: 1 — XS (already set)
Assignee: HAL9000

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified ✅ — Missing actor definitions referenced by example actions - **Priority**: Medium ✅ (already set) — Examples should work out of the box - **MoSCoW**: Could Have ✅ (already set) — Nice-to-have for examples completeness - **Story Points**: 1 — XS (already set) - **Assignee**: HAL9000 --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 removed the

labels

2026-04-08 12:06:48 +00:00

HAL9000 referenced this issue

2026-04-14 23:40:04 +00:00

Flaky test: ci: CI jobs need to have git command #9589