Refactor: Decompose models.py into smaller modules #4170

New issue

Closed

opened 2026-04-06 12:24:01 +00:00 by freemo · 1 comment

freemo commented

2026-04-06 12:24:01 +00:00

Owner

The src/cleveragents/infrastructure/database/models.py file has been identified as a major violation of the Single Responsibility Principle, the "clear, single purpose per directory" rule, and the 500-line limit guideline.

Issues:

God Module: The file is a massive "god module" that contains 30 different SQLAlchemy ORM models. This makes the file extremely difficult to read, understand, and maintain.
File Length: The file is over 3500 lines long, which is a massive violation of the 500-line limit.
Mixed Concerns: The file mixes ORM models for many different domain concepts, from projects and plans to resources, tools, and sessions.

Recommendation:

Perform a major refactoring of the models.py file by splitting it into smaller, more focused modules:

Create a new models directory within src/cleveragents/infrastructure/database.
Move each ORM model into its own file within the new models directory (e.g., project_model.py, plan_model.py, etc.).
Update the __init__.py file in the database package to import the models from their new locations.

This refactoring is critical for improving the architecture of the persistence layer and making the codebase more modular, maintainable, and testable.

Automated by CleverAgents Bot
Supervisor: Architecture Guard | Agent: ca-architecture-guard

The `src/cleveragents/infrastructure/database/models.py` file has been identified as a major violation of the Single Responsibility Principle, the "clear, single purpose per directory" rule, and the 500-line limit guideline. **Issues:** 1. **God Module:** The file is a massive "god module" that contains 30 different SQLAlchemy ORM models. This makes the file extremely difficult to read, understand, and maintain. 2. **File Length:** The file is over 3500 lines long, which is a massive violation of the 500-line limit. 3. **Mixed Concerns:** The file mixes ORM models for many different domain concepts, from projects and plans to resources, tools, and sessions. **Recommendation:** Perform a major refactoring of the `models.py` file by splitting it into smaller, more focused modules: * Create a new `models` directory within `src/cleveragents/infrastructure/database`. * Move each ORM model into its own file within the new `models` directory (e.g., `project_model.py`, `plan_model.py`, etc.). * Update the `__init__.py` file in the `database` package to import the models from their new locations. This refactoring is critical for improving the architecture of the persistence layer and making the codebase more modular, maintainable, and testable. --- **Automated by CleverAgents Bot** Supervisor: Architecture Guard | Agent: ca-architecture-guard

freemo referenced this issue

2026-04-06 12:26:28 +00:00

[Automated] CleverAgents Build Session - 2026-04-06 #3775

freemo added the

Points

label

2026-04-06 12:29:00 +00:00

freemo referenced this issue

2026-04-06 16:19:03 +00:00

Epic: Code Architecture Cleanup - Single Responsibility Principle Violations #4179

freemo commented

2026-04-06 16:42:14 +00:00

Author

Owner

CLOSED: Consolidated into Epic #4179

This models.py refactoring issue has been consolidated into Epic #4179: "Code Architecture Cleanup" as part of the Critical Plan Lifecycle Files (Phase 1 - v3.3.0) category.

See Epic #4179 for consolidated implementation approach. Closing as duplicate/consolidated.

**CLOSED: Consolidated into Epic #4179** This models.py refactoring issue has been consolidated into Epic #4179: "Code Architecture Cleanup" as part of the **Critical Plan Lifecycle Files (Phase 1 - v3.3.0)** category. See Epic #4179 for consolidated implementation approach. Closing as duplicate/consolidated.

freemo closed this issue

2026-04-06 16:42:17 +00:00