Refactor: Decompose repositories.py into smaller modules #4169

New issue

Closed

opened 2026-04-06 12:22:04 +00:00 by freemo · 1 comment

freemo commented

2026-04-06 12:22:04 +00:00

Owner

The src/cleveragents/infrastructure/database/repositories.py file has been identified as a major violation of the Single Responsibility Principle, the "clear, single purpose per directory" rule, and the 500-line limit guideline.

Issues:

God Module: The file is a massive "god module" that contains 15 different repository classes and 15 custom exception classes. This makes the file extremely difficult to read, understand, and maintain.
File Length: The file is over 6000 lines long, which is a massive violation of the 500-line limit.
Mixed Concerns: The file mixes repository logic for many different domain models, as well as custom exception classes.

Recommendation:

Perform a major refactoring of the repositories.py file by splitting it into smaller, more focused modules:

Create a new repositories directory within src/cleveragents/infrastructure/database.
Move each repository class into its own file within the new repositories directory (e.g., project_repository.py, plan_repository.py, etc.).
Move all the custom exception classes to a central exceptions module (e.g., src/cleveragents/core/exceptions.py).

This refactoring is critical for improving the architecture of the persistence layer and making the codebase more modular, maintainable, and testable.

Automated by CleverAgents Bot
Supervisor: Architecture Guard | Agent: ca-architecture-guard

The `src/cleveragents/infrastructure/database/repositories.py` file has been identified as a major violation of the Single Responsibility Principle, the "clear, single purpose per directory" rule, and the 500-line limit guideline. **Issues:** 1. **God Module:** The file is a massive "god module" that contains 15 different repository classes and 15 custom exception classes. This makes the file extremely difficult to read, understand, and maintain. 2. **File Length:** The file is over 6000 lines long, which is a massive violation of the 500-line limit. 3. **Mixed Concerns:** The file mixes repository logic for many different domain models, as well as custom exception classes. **Recommendation:** Perform a major refactoring of the `repositories.py` file by splitting it into smaller, more focused modules: * Create a new `repositories` directory within `src/cleveragents/infrastructure/database`. * Move each repository class into its own file within the new `repositories` directory (e.g., `project_repository.py`, `plan_repository.py`, etc.). * Move all the custom exception classes to a central exceptions module (e.g., `src/cleveragents/core/exceptions.py`). This refactoring is critical for improving the architecture of the persistence layer and making the codebase more modular, maintainable, and testable. --- **Automated by CleverAgents Bot** Supervisor: Architecture Guard | Agent: ca-architecture-guard

freemo referenced this issue

2026-04-06 12:26:28 +00:00

[Automated] CleverAgents Build Session - 2026-04-06 #3775

freemo added the

Points

label

2026-04-06 12:29:01 +00:00

freemo referenced this issue

2026-04-06 16:19:03 +00:00

Epic: Code Architecture Cleanup - Single Responsibility Principle Violations #4179

freemo commented

2026-04-06 17:28:39 +00:00

Author

Owner

CLOSED: Consolidated into Epic #4179 - Repositories.py refactoring consolidated into Epic #4179 (Infrastructure Files - Phase 2). Closing as duplicate.

**CLOSED: Consolidated into Epic #4179** - Repositories.py refactoring consolidated into Epic #4179 (Infrastructure Files - Phase 2). Closing as duplicate.

freemo closed this issue

2026-04-06 17:28:43 +00:00