Refactor: Decompose skill.py into smaller modules #4163

New issue

Closed

opened 2026-04-06 12:05:20 +00:00 by freemo · 1 comment

freemo commented

2026-04-06 12:05:20 +00:00

Owner

The src/cleveragents/domain/models/core/skill.py file has been identified as a major violation of the Single Responsibility Principle and the 500-line limit guideline.

Issues:

Mixed Concerns: The file mixes a large number of distinct concerns:
- Data Models: SkillToolRef, SkillInclude, SkillInlineTool, SkillMcpSource, SkillAgentSource, SkillCapabilitySummary, Skill, and ResolvedToolEntry.
- Business Logic: The SkillResolver class contains business logic for resolving a skill's toolset.
- Helper Functions: The _validate_override_keys function is a helper for the resolver.
File Length: The file is over 700 lines long, which makes it extremely difficult to read, understand, and maintain.

Recommendation:

Perform a major refactoring of the skill.py file by splitting it into smaller, more focused modules:

Keep the data models in src/cleveragents/domain/models/core/skill.py, but consider breaking them down into smaller files if the file is still too large.
Move the SkillResolver class and the _validate_override_keys function to the src/cleveragents/application layer, possibly in a new skills package.

This refactoring is critical for improving the architecture of the skill-related functionality and making the codebase more modular and maintainable.

Automated by CleverAgents Bot
Supervisor: Architecture Guard | Agent: ca-architecture-guard

The `src/cleveragents/domain/models/core/skill.py` file has been identified as a major violation of the Single Responsibility Principle and the 500-line limit guideline. **Issues:** 1. **Mixed Concerns:** The file mixes a large number of distinct concerns: * **Data Models:** `SkillToolRef`, `SkillInclude`, `SkillInlineTool`, `SkillMcpSource`, `SkillAgentSource`, `SkillCapabilitySummary`, `Skill`, and `ResolvedToolEntry`. * **Business Logic:** The `SkillResolver` class contains business logic for resolving a skill's toolset. * **Helper Functions:** The `_validate_override_keys` function is a helper for the resolver. 2. **File Length:** The file is over 700 lines long, which makes it extremely difficult to read, understand, and maintain. **Recommendation:** Perform a major refactoring of the `skill.py` file by splitting it into smaller, more focused modules: * Keep the data models in `src/cleveragents/domain/models/core/skill.py`, but consider breaking them down into smaller files if the file is still too large. * Move the `SkillResolver` class and the `_validate_override_keys` function to the `src/cleveragents/application` layer, possibly in a new `skills` package. This refactoring is critical for improving the architecture of the skill-related functionality and making the codebase more modular and maintainable. --- **Automated by CleverAgents Bot** Supervisor: Architecture Guard | Agent: ca-architecture-guard

freemo referenced this issue

2026-04-06 12:05:47 +00:00

[Automated] CleverAgents Build Session - 2026-04-06 #3775

freemo referenced this issue

2026-04-06 12:08:56 +00:00

[Automated] CleverAgents Build Session - 2026-04-06 #3775

freemo referenced this issue

2026-04-06 12:10:24 +00:00

[Automated] CleverAgents Build Session - 2026-04-06 #3775

freemo added the

Points

label

2026-04-06 12:13:01 +00:00

freemo referenced this issue

2026-04-06 16:19:03 +00:00

Epic: Code Architecture Cleanup - Single Responsibility Principle Violations #4179

freemo commented

2026-04-06 17:37:33 +00:00

Author

Owner

DUPLICATE: Consolidated into Epic #4179 "Code Architecture Cleanup - Single Responsibility Principle Violations"

This refactoring task for decomposing skill.py into smaller modules is part of the broader architectural cleanup effort. All Single Responsibility Principle violation fixes are being tracked collectively in the epic.

Action: Closing as duplicate in favor of Epic #4179

**DUPLICATE**: Consolidated into Epic #4179 "Code Architecture Cleanup - Single Responsibility Principle Violations" This refactoring task for decomposing `skill.py` into smaller modules is part of the broader architectural cleanup effort. All Single Responsibility Principle violation fixes are being tracked collectively in the epic. **Action**: Closing as duplicate in favor of Epic #4179

freemo closed this issue

2026-04-06 17:37:39 +00:00