Refactor: Decompose context_policy.py into smaller modules #4158

New issue

Closed

opened 2026-04-06 12:01:33 +00:00 by freemo · 1 comment

freemo commented

2026-04-06 12:01:33 +00:00

Owner

The src/cleveragents/domain/models/core/context_policy.py file has been identified as a violation of the Single Responsibility Principle.

Issues:

The file mixes several distinct concerns:

Data Models: ContextView, ProjectContextPolicy, BudgetViolation, and BudgetEnforcementResult.
Business Logic: The enforce_size_budget function contains business logic for enforcing budget limits on context fragments.

Recommendation:

Refactor the context_policy.py file by splitting it into smaller, more focused modules:

Keep the data models in src/cleveragents/domain/models/core/context_policy.py.
Move the enforce_size_budget function to the src/cleveragents/application layer, possibly in a new context package or a utils module.

This refactoring will improve the modularity, maintainability, and testability of the context policy functionality.

Automated by CleverAgents Bot
Supervisor: Architecture Guard | Agent: ca-architecture-guard

The `src/cleveragents/domain/models/core/context_policy.py` file has been identified as a violation of the Single Responsibility Principle. **Issues:** The file mixes several distinct concerns: 1. **Data Models:** `ContextView`, `ProjectContextPolicy`, `BudgetViolation`, and `BudgetEnforcementResult`. 2. **Business Logic:** The `enforce_size_budget` function contains business logic for enforcing budget limits on context fragments. **Recommendation:** Refactor the `context_policy.py` file by splitting it into smaller, more focused modules: * Keep the data models in `src/cleveragents/domain/models/core/context_policy.py`. * Move the `enforce_size_budget` function to the `src/cleveragents/application` layer, possibly in a new `context` package or a `utils` module. This refactoring will improve the modularity, maintainability, and testability of the context policy functionality. --- **Automated by CleverAgents Bot** Supervisor: Architecture Guard | Agent: ca-architecture-guard

freemo referenced this issue

2026-04-06 12:03:10 +00:00

[Automated] CleverAgents Build Session - 2026-04-06 #3775

freemo added the

Points

label

2026-04-06 12:07:42 +00:00

freemo referenced this issue

2026-04-06 16:19:03 +00:00

Epic: Code Architecture Cleanup - Single Responsibility Principle Violations #4179

freemo commented

2026-04-06 17:37:54 +00:00

Author

Owner

DUPLICATE: Consolidated into Epic #4179 "Code Architecture Cleanup - Single Responsibility Principle Violations"

This refactoring task for decomposing context_policy.py into smaller modules is part of the broader architectural cleanup effort. All Single Responsibility Principle violation fixes are being tracked collectively in the epic.

Action: Closing as duplicate in favor of Epic #4179

**DUPLICATE**: Consolidated into Epic #4179 "Code Architecture Cleanup - Single Responsibility Principle Violations" This refactoring task for decomposing `context_policy.py` into smaller modules is part of the broader architectural cleanup effort. All Single Responsibility Principle violation fixes are being tracked collectively in the epic. **Action**: Closing as duplicate in favor of Epic #4179

freemo closed this issue

2026-04-06 17:38:01 +00:00