Refactor: Decompose error_recovery.py into smaller modules #3899

New issue

Open

opened 2026-04-06 07:17:07 +00:00 by freemo · 0 comments

freemo commented

2026-04-06 07:17:07 +00:00

Owner

The src/cleveragents/domain/models/core/error_recovery.py file has been identified as a violation of the Single Responsibility Principle and the 500-line limit guideline.

Issues:

Mixed Concerns: The file mixes several distinct concerns:
- Data Models: ErrorCategory, RecoveryAction, RecoveryHint, ErrorRecord, and ErrorHistory.
- Policy Logic: The ErrorRecoveryPolicy class.
- Helper Functions: get_recovery_hints and classify_error.
File Length: The file is over 600 lines long, which makes it difficult to read and maintain.

Recommendation:

Refactor the error_recovery.py file by splitting it into smaller, more focused modules:

Keep the data models in src/cleveragents/domain/models/core/error_recovery.py.
Move the ErrorRecoveryPolicy class to the src/cleveragents/application layer, possibly in a new policies package.
Move the helper functions (get_recovery_hints, classify_error) to a utils or helpers module.

This refactoring will improve the modularity, maintainability, and testability of the error recovery functionality, and it will also resolve the file length issue.

Automated by CleverAgents Bot
Supervisor: Architecture Guard | Agent: ca-architecture-guard

The `src/cleveragents/domain/models/core/error_recovery.py` file has been identified as a violation of the Single Responsibility Principle and the 500-line limit guideline. **Issues:** 1. **Mixed Concerns:** The file mixes several distinct concerns: * **Data Models:** `ErrorCategory`, `RecoveryAction`, `RecoveryHint`, `ErrorRecord`, and `ErrorHistory`. * **Policy Logic:** The `ErrorRecoveryPolicy` class. * **Helper Functions:** `get_recovery_hints` and `classify_error`. 2. **File Length:** The file is over 600 lines long, which makes it difficult to read and maintain. **Recommendation:** Refactor the `error_recovery.py` file by splitting it into smaller, more focused modules: * Keep the data models in `src/cleveragents/domain/models/core/error_recovery.py`. * Move the `ErrorRecoveryPolicy` class to the `src/cleveragents/application` layer, possibly in a new `policies` package. * Move the helper functions (`get_recovery_hints`, `classify_error`) to a `utils` or `helpers` module. This refactoring will improve the modularity, maintainability, and testability of the error recovery functionality, and it will also resolve the file length issue. --- **Automated by CleverAgents Bot** Supervisor: Architecture Guard | Agent: ca-architecture-guard

Rows
Columns