BUG-HUNT: [spec-alignment] Use of `# type: ignore` in project_repository_bench.py violates coding standards #3886

New issue

Open

opened 2026-04-06 07:09:00 +00:00 by freemo · 1 comment

freemo commented

2026-04-06 07:09:00 +00:00

Owner

Bug Report: [spec-alignment] — Use of `# type: ignore` in project_repository_bench.py violates coding standards

Background and Context

The project's contribution guidelines explicitly forbid the use of # type: ignore or any other mechanism to suppress or disable type checking. The file benchmarks/project_repository_bench.py contains multiple such suppressions, violating the project's strict type-safety standards.

Current Behavior

The file benchmarks/project_repository_bench.py uses # type: ignore[assignment] comments to suppress type errors in the LinkRepositoryCRUD.setup method.

Evidence — Lines 93–98:

        rt = ResourceTypeModel()
        rt.name = "bench/git-checkout"  # type: ignore[assignment]
        rt.namespace = "bench"  # type: ignore[assignment]
        rt.resource_kind = "physical"  # type: ignore[assignment]
        rt.user_addable = True  # type: ignore[assignment]
        rt.created_at = _now_iso()  # type: ignore[assignment]
        rt.updated_at = _now_iso()  # type: ignore[assignment]

Evidence — Lines 113–117:

            r = ResourceModel()
            r.resource_id = str(i).zfill(26)  # type: ignore[assignment]
            r.type_name = "bench/git-checkout"  # type: ignore[assignment]
            r.resource_kind = "physical"  # type: ignore[assignment]
            r.created_at = _now_iso()  # type: ignore[assignment]
            r.updated_at = _now_iso()  # type: ignore[assignment]

Expected Behavior

The code should be written in a way that passes the type checker without suppressing errors. This might involve constructing models with required attributes in the constructor, using typed keyword arguments, or using a factory/builder pattern that is compatible with the type checker.

Severity Assessment

Impact: Medium. The use of # type: ignore suppresses potential type errors and violates the project's strict type-checking standards, making the code harder to maintain and reason about.
Likelihood: High. The type: ignore comments are present in the code and will always suppress type checks.
Priority: Medium

Metadata

Branch: fix/benchmark-remove-type-ignore-project-repository
Commit Message: fix(benchmarks): remove type: ignore suppressions from project_repository_bench
Milestone: Backlog (no milestone assigned)
Parent Epic: TBD — see orphan note below

Subtasks

Investigate the root cause of the type errors being suppressed in LinkRepositoryCRUD.setup
Refactor ResourceTypeModel and ResourceModel instantiation to be type-safe (e.g., use constructor kwargs or a typed factory)
Remove all # type: ignore[assignment] comments from benchmarks/project_repository_bench.py
Verify the type checker passes with zero suppressions (nox -s typecheck or equivalent)
Run nox (all default sessions), fix any errors
Verify coverage >= 97% via nox -s coverage_report

Definition of Done

All subtasks above are completed and checked off
No # type: ignore comments remain in benchmarks/project_repository_bench.py
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional details
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done
All nox stages pass
Coverage >= 97%

Backlog note: This issue was discovered during autonomous operation
on milestone v3.7.0. It does not block milestone completion and has been
placed in the backlog for human review and future milestone assignment.

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: ca-new-issue-creator

## Bug Report: [spec-alignment] — Use of `# type: ignore` in project_repository_bench.py violates coding standards ### Background and Context The project's contribution guidelines explicitly forbid the use of `# type: ignore` or any other mechanism to suppress or disable type checking. The file `benchmarks/project_repository_bench.py` contains multiple such suppressions, violating the project's strict type-safety standards. ### Current Behavior The file `benchmarks/project_repository_bench.py` uses `# type: ignore[assignment]` comments to suppress type errors in the `LinkRepositoryCRUD.setup` method. **Evidence — Lines 93–98:** ```python rt = ResourceTypeModel() rt.name = "bench/git-checkout" # type: ignore[assignment] rt.namespace = "bench" # type: ignore[assignment] rt.resource_kind = "physical" # type: ignore[assignment] rt.user_addable = True # type: ignore[assignment] rt.created_at = _now_iso() # type: ignore[assignment] rt.updated_at = _now_iso() # type: ignore[assignment] ``` **Evidence — Lines 113–117:** ```python r = ResourceModel() r.resource_id = str(i).zfill(26) # type: ignore[assignment] r.type_name = "bench/git-checkout" # type: ignore[assignment] r.resource_kind = "physical" # type: ignore[assignment] r.created_at = _now_iso() # type: ignore[assignment] r.updated_at = _now_iso() # type: ignore[assignment] ``` ### Expected Behavior The code should be written in a way that passes the type checker without suppressing errors. This might involve constructing models with required attributes in the constructor, using typed keyword arguments, or using a factory/builder pattern that is compatible with the type checker. ### Severity Assessment - **Impact**: Medium. The use of `# type: ignore` suppresses potential type errors and violates the project's strict type-checking standards, making the code harder to maintain and reason about. - **Likelihood**: High. The `type: ignore` comments are present in the code and will always suppress type checks. - **Priority**: Medium ### Category spec-alignment ## Metadata - **Branch**: `fix/benchmark-remove-type-ignore-project-repository` - **Commit Message**: `fix(benchmarks): remove type: ignore suppressions from project_repository_bench` - **Milestone**: Backlog (no milestone assigned) - **Parent Epic**: TBD — see orphan note below ## Subtasks - [ ] Investigate the root cause of the type errors being suppressed in `LinkRepositoryCRUD.setup` - [ ] Refactor `ResourceTypeModel` and `ResourceModel` instantiation to be type-safe (e.g., use constructor kwargs or a typed factory) - [ ] Remove all `# type: ignore[assignment]` comments from `benchmarks/project_repository_bench.py` - [ ] Verify the type checker passes with zero suppressions (`nox -s typecheck` or equivalent) - [ ] Run `nox` (all default sessions), fix any errors - [ ] Verify coverage >= 97% via `nox -s coverage_report` ## Definition of Done - [ ] All subtasks above are completed and checked off - [ ] No `# type: ignore` comments remain in `benchmarks/project_repository_bench.py` - [ ] A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional details - [ ] The commit is pushed to the remote on the branch matching the Branch in Metadata exactly - [ ] The commit is submitted as a pull request to `master`, reviewed, and merged before this issue is marked done - All nox stages pass - Coverage >= 97% > **Backlog note:** This issue was discovered during autonomous operation > on milestone v3.7.0. It does not block milestone completion and has been > placed in the backlog for human review and future milestone assignment. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: ca-new-issue-creator

freemo commented

2026-04-06 07:09:21 +00:00

Author

Owner

⚠️ Orphan Issue — Manual Linking Required

This issue was created during autonomous bug-hunting and no parent Epic was provided by the caller. Per project contribution guidelines, every issue must be linked to a parent Epic using Forgejo's dependency system (child blocks parent).

A human reviewer should identify the appropriate parent Epic and create the dependency link:

# Child issue BLOCKS parent Epic — correct direction
curl -s -X POST "https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/issues/3886/blocks" \
  -H "Authorization: token <FORGEJO_PAT>" \
  -H "Content-Type: application/json" \
  -d '{"owner": "cleveragents", "repo": "cleveragents-core", "index": <PARENT_EPIC_NUMBER>}'

Suggested candidate Epics to review:

#2810 — Epic: CI Quality Gates Restoration (type checking is a CI quality gate)
Any spec-alignment or coding standards Epic if one exists

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: ca-new-issue-creator

⚠️ **Orphan Issue — Manual Linking Required** This issue was created during autonomous bug-hunting and no parent Epic was provided by the caller. Per project contribution guidelines, every issue must be linked to a parent Epic using Forgejo's dependency system (child **blocks** parent). A human reviewer should identify the appropriate parent Epic and create the dependency link: ```bash # Child issue BLOCKS parent Epic — correct direction curl -s -X POST "https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/issues/3886/blocks" \ -H "Authorization: token <FORGEJO_PAT>" \ -H "Content-Type: application/json" \ -d '{"owner": "cleveragents", "repo": "cleveragents-core", "index": <PARENT_EPIC_NUMBER>}' ``` Suggested candidate Epics to review: - **#2810** — Epic: CI Quality Gates Restoration (type checking is a CI quality gate) - Any spec-alignment or coding standards Epic if one exists --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: ca-new-issue-creator

freemo added the

Points

label

2026-04-06 07:15:12 +00:00