UAT: YAML syntax error in push-validation CI job — step definition embedded inside run: block #3882

Open
opened 2026-04-06 07:08:10 +00:00 by freemo · 0 comments
Owner

Metadata

  • Branch: fix/ci-quality-gates/push-validation-yaml-syntax
  • Commit Message: fix(ci): correct YAML indentation for smoke-test step in push-validation job
  • Milestone: None (backlog — see note below)
  • Parent Epic: #2810

Backlog note: This issue was discovered during autonomous operation
on milestone v3.7.0. It does not block milestone completion and has been
placed in the backlog for human review and future milestone assignment.

Bug Description

In .forgejo/workflows/ci.yml, the push-validation job has a YAML structure error. The step definition for "Smoke-test push access via API" is embedded inside the run: block of the previous step ("Verify HTTPS credential helper is configured") rather than being defined as a proper CI step.

What Was Tested

Code-level analysis of .forgejo/workflows/ci.yml in the push-validation job.

Expected Behavior (from spec)

Each CI step should be properly defined as a YAML list item with - name:, env:, and run: keys at the correct indentation level within the steps: block.

Actual Behavior

The "Smoke-test push access via API" step definition appears at 18 spaces of indentation inside the run: | block of the "Verify HTTPS credential helper is configured" step. This means:

  1. The shell script will attempt to execute - name: Smoke-test push access via API as a shell command, which will fail with a "command not found" error
  2. The env: and run: blocks that follow are orphaned YAML keys at the step level without a preceding - name: or - uses:, creating an invalid YAML structure
  3. The actual smoke-test logic (curl API calls to verify push permissions) will never execute as intended

Code Location

.forgejo/workflows/ci.ymlpush-validation job, steps section

Steps to Reproduce

  1. Open .forgejo/workflows/ci.yml
  2. Navigate to the push-validation job
  3. Find the "Verify HTTPS credential helper is configured" step
  4. Observe that - name: Smoke-test push access via API appears inside the run: | block at 18 spaces indentation
  5. The env: and run: blocks that follow are at 14 spaces (step level) but without a - name: prefix

Impact

The push-validation job's smoke-test step will fail with a shell error, and the actual API-based push permission verification will not execute. This means the CI pipeline cannot reliably validate that the FORGEJO_TOKEN has write permissions before attempting push operations.

Subtasks

  • Identify the exact line range in .forgejo/workflows/ci.yml where the indentation error occurs
  • Fix the indentation of - name: Smoke-test push access via API to be a proper top-level step list item within steps:
  • Ensure the associated env: and run: blocks are correctly nested under the new step definition
  • Validate the corrected YAML with a YAML linter
  • Trigger the push-validation CI job and confirm the smoke-test step executes successfully
  • Confirm the API-based push permission verification logic runs and produces expected output

Definition of Done

  • All subtasks are completed
  • The push-validation job's "Smoke-test push access via API" step is a properly indented YAML list item under steps:
  • The env: and run: blocks for the smoke-test step are correctly nested under their - name: entry
  • The CI push-validation job passes end-to-end with the smoke-test step executing as intended
  • No other CI steps are inadvertently affected by the fix
  • The commit is created with the exact message from Metadata
  • The commit is pushed to the branch specified in Metadata
  • A pull request has been created, reviewed, and merged
  • All nox stages pass
  • Coverage >= 97%

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-uat-tester

## Metadata - **Branch**: `fix/ci-quality-gates/push-validation-yaml-syntax` - **Commit Message**: `fix(ci): correct YAML indentation for smoke-test step in push-validation job` - **Milestone**: None (backlog — see note below) - **Parent Epic**: #2810 > **Backlog note:** This issue was discovered during autonomous operation > on milestone v3.7.0. It does not block milestone completion and has been > placed in the backlog for human review and future milestone assignment. ## Bug Description In `.forgejo/workflows/ci.yml`, the `push-validation` job has a YAML structure error. The step definition for "Smoke-test push access via API" is embedded inside the `run:` block of the previous step ("Verify HTTPS credential helper is configured") rather than being defined as a proper CI step. ### What Was Tested Code-level analysis of `.forgejo/workflows/ci.yml` in the `push-validation` job. ### Expected Behavior (from spec) Each CI step should be properly defined as a YAML list item with `- name:`, `env:`, and `run:` keys at the correct indentation level within the `steps:` block. ### Actual Behavior The "Smoke-test push access via API" step definition appears at 18 spaces of indentation inside the `run: |` block of the "Verify HTTPS credential helper is configured" step. This means: 1. The shell script will attempt to execute `- name: Smoke-test push access via API` as a shell command, which will fail with a "command not found" error 2. The `env:` and `run:` blocks that follow are orphaned YAML keys at the step level without a preceding `- name:` or `- uses:`, creating an invalid YAML structure 3. The actual smoke-test logic (curl API calls to verify push permissions) will never execute as intended ### Code Location `.forgejo/workflows/ci.yml` — `push-validation` job, steps section ### Steps to Reproduce 1. Open `.forgejo/workflows/ci.yml` 2. Navigate to the `push-validation` job 3. Find the "Verify HTTPS credential helper is configured" step 4. Observe that `- name: Smoke-test push access via API` appears inside the `run: |` block at 18 spaces indentation 5. The `env:` and `run:` blocks that follow are at 14 spaces (step level) but without a `- name:` prefix ### Impact The push-validation job's smoke-test step will fail with a shell error, and the actual API-based push permission verification will not execute. This means the CI pipeline cannot reliably validate that the `FORGEJO_TOKEN` has write permissions before attempting push operations. ## Subtasks - [ ] Identify the exact line range in `.forgejo/workflows/ci.yml` where the indentation error occurs - [ ] Fix the indentation of `- name: Smoke-test push access via API` to be a proper top-level step list item within `steps:` - [ ] Ensure the associated `env:` and `run:` blocks are correctly nested under the new step definition - [ ] Validate the corrected YAML with a YAML linter - [ ] Trigger the `push-validation` CI job and confirm the smoke-test step executes successfully - [ ] Confirm the API-based push permission verification logic runs and produces expected output ## Definition of Done - [ ] All subtasks are completed - [ ] The `push-validation` job's "Smoke-test push access via API" step is a properly indented YAML list item under `steps:` - [ ] The `env:` and `run:` blocks for the smoke-test step are correctly nested under their `- name:` entry - [ ] The CI `push-validation` job passes end-to-end with the smoke-test step executing as intended - [ ] No other CI steps are inadvertently affected by the fix - [ ] The commit is created with the exact message from Metadata - [ ] The commit is pushed to the branch specified in Metadata - [ ] A pull request has been created, reviewed, and merged - [ ] All nox stages pass - [ ] Coverage >= 97% --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-uat-tester
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
cleveragents/cleveragents-core#3882
No description provided.