BUG-HUNT: [type-safety] Missing arguments in Actor constructor in actor_registry_bench.py #3870

Open
opened 2026-04-06 07:03:42 +00:00 by freemo · 0 comments
Owner

Metadata

  • Branch: bug/missing-actor-constructor-args-bench
  • Commit Message: fix(benchmarks): add missing required arguments to Actor constructor in actor_registry_bench
  • Milestone: N/A (Backlog)
  • Parent Epic: #2810

Bug Report: [type-safety] — Missing arguments in Actor constructor in actor_registry_bench.py

Severity Assessment

  • Impact: Medium. This violates the type contract of the Actor class, which could lead to unexpected behavior or runtime errors.
  • Likelihood: High. The code as written will always trigger this type error.
  • Priority: Medium

Location

  • File: benchmarks/actor_registry_bench.py
  • Function/Class: _make_actor
  • Lines: 38

Description

Pyright has detected that the Actor constructor is called without the required arguments: unsafe, is_built_in, and is_default.

Evidence

# benchmarks/actor_registry_bench.py:38
    return Actor(
        id=None,
        name=name,
        provider="openai",
        model="gpt-4",
        config_blob=blob,
        config_hash=Actor.compute_hash(blob),
        yaml_text=yaml_text,
        schema_version=schema_version,
        compiled_metadata=compiled_metadata,
    )

Pyright Error:

error: Arguments missing for parameters "unsafe", "is_built_in", "is_default" (reportCallIssue)

Expected Behavior

The Actor constructor should be called with all required arguments.

Actual Behavior

The Actor constructor is called with missing arguments, resulting in a type error.

Suggested Fix

Provide values for the missing arguments in the Actor constructor call. Default or mock values can be used as appropriate for the benchmark context.

Category

type-safety

Subtasks

  • Inspect the Actor class constructor signature to confirm all required parameters
  • Add unsafe, is_built_in, and is_default arguments to the Actor(...) call in _make_actor (line 38 of benchmarks/actor_registry_bench.py)
  • Run nox -e typecheck to confirm the Pyright error is resolved
  • Run nox to confirm all quality gates pass

Definition of Done

  • benchmarks/actor_registry_bench.py passes Pyright type checking with no reportCallIssue errors
  • The Actor constructor call in _make_actor includes all required arguments (unsafe, is_built_in, is_default)
  • All nox stages pass
  • Coverage >= 97%

Backlog note: This issue was discovered during autonomous operation
on milestone v3.7.0. It does not block milestone completion and has been
placed in the backlog for human review and future milestone assignment.


Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: ca-new-issue-creator

## Metadata - **Branch**: `bug/missing-actor-constructor-args-bench` - **Commit Message**: `fix(benchmarks): add missing required arguments to Actor constructor in actor_registry_bench` - **Milestone**: N/A (Backlog) - **Parent Epic**: #2810 ## Bug Report: [type-safety] — Missing arguments in Actor constructor in actor_registry_bench.py ### Severity Assessment - **Impact**: Medium. This violates the type contract of the `Actor` class, which could lead to unexpected behavior or runtime errors. - **Likelihood**: High. The code as written will always trigger this type error. - **Priority**: Medium ### Location - **File**: `benchmarks/actor_registry_bench.py` - **Function/Class**: `_make_actor` - **Lines**: 38 ### Description Pyright has detected that the `Actor` constructor is called without the required arguments: `unsafe`, `is_built_in`, and `is_default`. ### Evidence ```python # benchmarks/actor_registry_bench.py:38 return Actor( id=None, name=name, provider="openai", model="gpt-4", config_blob=blob, config_hash=Actor.compute_hash(blob), yaml_text=yaml_text, schema_version=schema_version, compiled_metadata=compiled_metadata, ) ``` **Pyright Error:** ``` error: Arguments missing for parameters "unsafe", "is_built_in", "is_default" (reportCallIssue) ``` ### Expected Behavior The `Actor` constructor should be called with all required arguments. ### Actual Behavior The `Actor` constructor is called with missing arguments, resulting in a type error. ### Suggested Fix Provide values for the missing arguments in the `Actor` constructor call. Default or mock values can be used as appropriate for the benchmark context. ### Category type-safety ## Subtasks - [ ] Inspect the `Actor` class constructor signature to confirm all required parameters - [ ] Add `unsafe`, `is_built_in`, and `is_default` arguments to the `Actor(...)` call in `_make_actor` (line 38 of `benchmarks/actor_registry_bench.py`) - [ ] Run `nox -e typecheck` to confirm the Pyright error is resolved - [ ] Run `nox` to confirm all quality gates pass ## Definition of Done - [ ] `benchmarks/actor_registry_bench.py` passes Pyright type checking with no `reportCallIssue` errors - [ ] The `Actor` constructor call in `_make_actor` includes all required arguments (`unsafe`, `is_built_in`, `is_default`) - [ ] All nox stages pass - [ ] Coverage >= 97% > **Backlog note:** This issue was discovered during autonomous operation > on milestone v3.7.0. It does not block milestone completion and has been > placed in the backlog for human review and future milestone assignment. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: ca-new-issue-creator
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
cleveragents/cleveragents-core#3870
No description provided.