BUG-HUNT: [type-safety] Missing arguments in constructor calls in actor_runtime_bench.py #3862

New issue

Open

opened 2026-04-06 07:00:42 +00:00 by freemo · 0 comments

freemo commented

2026-04-06 07:00:42 +00:00

Owner

Metadata

Branch: fix/benchmarks/actor-runtime-bench-constructor-args
Commit Message: fix(benchmarks): add missing constructor arguments in actor_runtime_bench
Milestone: None (Backlog — see note below)
Parent Epic: #2810

Backlog note: This issue was discovered during autonomous operation
on milestone v3.7.0. It does not block milestone completion and has been
placed in the backlog for human review and future milestone assignment.

Bug Report: [type-safety] — Missing arguments in constructor calls in actor_runtime_bench.py

Severity Assessment

Impact: Medium. These violations of the domain model's contracts could lead to unexpected behavior or runtime errors.
Likelihood: High. The code as written will always trigger these type errors.
Priority: Medium

Location

File: benchmarks/actor_runtime_bench.py
Classes: _SingleToolLLM, _AlwaysToolLLM, ToolActorContextSuite

Description

Pyright has detected multiple instances of missing arguments in constructor calls within actor_runtime_bench.py.

The LLMResponse constructor is called without the required content argument in _SingleToolLLM and _AlwaysToolLLM.
The ToolCallRecord constructor is called without the required success and iteration arguments in ToolActorContextSuite.

These omissions violate the type contracts of the respective classes and should be corrected.

Evidence

Pyright Errors:

- error at 58:20 (reportCallIssue): Argument missing for parameter "content"
- error at 72:16 (reportCallIssue): Argument missing for parameter "content"
- error at 169:18 (reportCallIssue): Arguments missing for parameters "success", "iteration"

Expected Behavior

All constructor calls should provide all required arguments as defined by the class definitions.

Actual Behavior

The constructor calls are missing required arguments, resulting in type errors.

Suggested Fix

Provide the missing arguments in the constructor calls. Default or mock values can be used as appropriate for the benchmark context.

Subtasks

Inspect LLMResponse class definition to confirm all required constructor arguments (content)
Inspect ToolCallRecord class definition to confirm all required constructor arguments (success, iteration)
Fix _SingleToolLLM: add missing content argument to LLMResponse constructor call (line 58)
Fix _AlwaysToolLLM: add missing content argument to LLMResponse constructor call (line 72)
Fix ToolActorContextSuite: add missing success and iteration arguments to ToolCallRecord constructor call (line 169)
Run nox -e typecheck to confirm all Pyright errors in actor_runtime_bench.py are resolved
Run full nox suite to confirm no regressions

Definition of Done

All Pyright errors in benchmarks/actor_runtime_bench.py are resolved
All constructor calls in actor_runtime_bench.py provide all required arguments
All nox stages pass
Coverage >= 97%

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: ca-new-issue-creator

## Metadata - **Branch**: `fix/benchmarks/actor-runtime-bench-constructor-args` - **Commit Message**: `fix(benchmarks): add missing constructor arguments in actor_runtime_bench` - **Milestone**: None (Backlog — see note below) - **Parent Epic**: #2810 > **Backlog note:** This issue was discovered during autonomous operation > on milestone v3.7.0. It does not block milestone completion and has been > placed in the backlog for human review and future milestone assignment. ## Bug Report: [type-safety] — Missing arguments in constructor calls in actor_runtime_bench.py ### Severity Assessment - **Impact**: Medium. These violations of the domain model's contracts could lead to unexpected behavior or runtime errors. - **Likelihood**: High. The code as written will always trigger these type errors. - **Priority**: Medium ### Location - **File**: `benchmarks/actor_runtime_bench.py` - **Classes**: `_SingleToolLLM`, `_AlwaysToolLLM`, `ToolActorContextSuite` ### Description Pyright has detected multiple instances of missing arguments in constructor calls within `actor_runtime_bench.py`. 1. The `LLMResponse` constructor is called without the required `content` argument in `_SingleToolLLM` and `_AlwaysToolLLM`. 2. The `ToolCallRecord` constructor is called without the required `success` and `iteration` arguments in `ToolActorContextSuite`. These omissions violate the type contracts of the respective classes and should be corrected. ### Evidence **Pyright Errors:** ``` - error at 58:20 (reportCallIssue): Argument missing for parameter "content" - error at 72:16 (reportCallIssue): Argument missing for parameter "content" - error at 169:18 (reportCallIssue): Arguments missing for parameters "success", "iteration" ``` ### Expected Behavior All constructor calls should provide all required arguments as defined by the class definitions. ### Actual Behavior The constructor calls are missing required arguments, resulting in type errors. ### Suggested Fix Provide the missing arguments in the constructor calls. Default or mock values can be used as appropriate for the benchmark context. ### Category type-safety ## Subtasks - [ ] Inspect `LLMResponse` class definition to confirm all required constructor arguments (`content`) - [ ] Inspect `ToolCallRecord` class definition to confirm all required constructor arguments (`success`, `iteration`) - [ ] Fix `_SingleToolLLM`: add missing `content` argument to `LLMResponse` constructor call (line 58) - [ ] Fix `_AlwaysToolLLM`: add missing `content` argument to `LLMResponse` constructor call (line 72) - [ ] Fix `ToolActorContextSuite`: add missing `success` and `iteration` arguments to `ToolCallRecord` constructor call (line 169) - [ ] Run `nox -e typecheck` to confirm all Pyright errors in `actor_runtime_bench.py` are resolved - [ ] Run full `nox` suite to confirm no regressions ## Definition of Done - [ ] All Pyright errors in `benchmarks/actor_runtime_bench.py` are resolved - [ ] All constructor calls in `actor_runtime_bench.py` provide all required arguments - [ ] All nox stages pass - [ ] Coverage >= 97% --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: ca-new-issue-creator

freemo added a new dependency

2026-04-06 07:01:01 +00:00

#2810 Epic: CI Quality Gates Restoration — Restore All 11 CI Jobs to Passing on Master

freemo added the

Points

label

2026-04-06 07:03:34 +00:00