UAT: Spec contradiction in DEFAULT_ENABLED_STRATEGIES — §25659 lists 4 strategies (including 'arce') but §30732 lists 3 (without 'arce') #3833

Open
opened 2026-04-06 06:50:26 +00:00 by freemo · 0 comments
Owner

Metadata

  • Branch: fix/acms-default-enabled-strategies-spec-contradiction
  • Commit Message: fix(acms): resolve spec contradiction in DEFAULT_ENABLED_STRATEGIES between §25659 and §30732
  • Milestone: (none — backlog)
  • Parent Epic: #396

Background

The specification has two conflicting definitions of the default enabled ACMS context strategies. The implementation follows one definition but not the other.

What Was Tested

Code-level analysis of src/cleveragents/domain/models/acms/strategy_stubs.py against docs/specification.md §25659 and §30732.

Spec Contradiction

§25659 (Context Strategy Configuration example):

[context.strategies]
enabled = ["simple-keyword", "semantic-embedding", "arce", "breadth-depth-navigator"]

This lists 4 strategies including arce.

§30732 (Configuration Reference Table):

context.strategies.enabled | list | ["simple-keyword", "semantic-embedding", "breadth-depth-navigator"] | ...

This lists 3 strategies without arce.

Current Implementation

src/cleveragents/domain/models/acms/strategy_stubs.py follows §30732:

DEFAULT_ENABLED_STRATEGIES: tuple[str, ...] = (
    "simple-keyword",
    "semantic-embedding",
    "breadth-depth-navigator",
)

The code includes a comment noting this contradiction: "NOTE: Spec §25223 lists 4 strategies (including 'arce') in the default enabled config, but §28682 lists only 3 (without 'arce'). This is a spec internal contradiction. We follow §28682 (the config key table) because it is the more specific/operational reference."

Impact

  • If arce should be in the default enabled list, users will not get the highest-quality context assembly (quality=0.95) by default
  • If arce should NOT be in the default list, the spec example at §25659 is misleading
  • Any tooling or documentation that references the spec example will expect arce to be enabled by default

Expected Resolution

The spec should be clarified to have a single consistent definition of the default enabled strategies. The implementation should be updated to match the clarified spec.

Code Location

  • src/cleveragents/domain/models/acms/strategy_stubs.pyDEFAULT_ENABLED_STRATEGIES constant
  • docs/specification.md §25659 (example config)
  • docs/specification.md §30732 (config reference table)

Subtasks

  • Clarify the spec to have a single consistent definition of default enabled strategies
  • Update DEFAULT_ENABLED_STRATEGIES in strategy_stubs.py to match the clarified spec
  • Update any documentation or tests that reference the default strategy list

Definition of Done

  • Spec has a single consistent definition of default enabled strategies
  • DEFAULT_ENABLED_STRATEGIES matches the clarified spec
  • All tests pass
  • All nox stages pass
  • Coverage >= 97%

Backlog note: This issue was discovered during autonomous UAT testing of the ACMS Context Management feature area. It does not block milestone completion and has been placed in the backlog for human review and future milestone assignment.


Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-new-issue-creator

## Metadata - **Branch**: `fix/acms-default-enabled-strategies-spec-contradiction` - **Commit Message**: `fix(acms): resolve spec contradiction in DEFAULT_ENABLED_STRATEGIES between §25659 and §30732` - **Milestone**: (none — backlog) - **Parent Epic**: #396 ## Background The specification has two conflicting definitions of the default enabled ACMS context strategies. The implementation follows one definition but not the other. ## What Was Tested Code-level analysis of `src/cleveragents/domain/models/acms/strategy_stubs.py` against `docs/specification.md` §25659 and §30732. ## Spec Contradiction **§25659** (Context Strategy Configuration example): ```toml [context.strategies] enabled = ["simple-keyword", "semantic-embedding", "arce", "breadth-depth-navigator"] ``` This lists **4 strategies** including `arce`. **§30732** (Configuration Reference Table): ``` context.strategies.enabled | list | ["simple-keyword", "semantic-embedding", "breadth-depth-navigator"] | ... ``` This lists **3 strategies** without `arce`. ## Current Implementation `src/cleveragents/domain/models/acms/strategy_stubs.py` follows §30732: ```python DEFAULT_ENABLED_STRATEGIES: tuple[str, ...] = ( "simple-keyword", "semantic-embedding", "breadth-depth-navigator", ) ``` The code includes a comment noting this contradiction: "NOTE: Spec §25223 lists 4 strategies (including 'arce') in the default enabled config, but §28682 lists only 3 (without 'arce'). This is a spec internal contradiction. We follow §28682 (the config key table) because it is the more specific/operational reference." ## Impact - If `arce` should be in the default enabled list, users will not get the highest-quality context assembly (quality=0.95) by default - If `arce` should NOT be in the default list, the spec example at §25659 is misleading - Any tooling or documentation that references the spec example will expect `arce` to be enabled by default ## Expected Resolution The spec should be clarified to have a single consistent definition of the default enabled strategies. The implementation should be updated to match the clarified spec. ## Code Location - `src/cleveragents/domain/models/acms/strategy_stubs.py` — `DEFAULT_ENABLED_STRATEGIES` constant - `docs/specification.md` §25659 (example config) - `docs/specification.md` §30732 (config reference table) ## Subtasks - [ ] Clarify the spec to have a single consistent definition of default enabled strategies - [ ] Update `DEFAULT_ENABLED_STRATEGIES` in `strategy_stubs.py` to match the clarified spec - [ ] Update any documentation or tests that reference the default strategy list ## Definition of Done - [ ] Spec has a single consistent definition of default enabled strategies - [ ] `DEFAULT_ENABLED_STRATEGIES` matches the clarified spec - [ ] All tests pass - [ ] All nox stages pass - [ ] Coverage >= 97% > **Backlog note:** This issue was discovered during autonomous UAT testing of the ACMS Context Management feature area. It does not block milestone completion and has been placed in the backlog for human review and future milestone assignment. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-new-issue-creator
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#396 Epic: ACMS Context Pipeline
cleveragents/cleveragents-core
Reference
cleveragents/cleveragents-core#3833
No description provided.