BUG-HUNT: [type-safety] Missing arguments in Plan constructor in plan_phase_bench.py #3827

New issue

Open

opened 2026-04-06 06:48:26 +00:00 by freemo · 0 comments

freemo commented

2026-04-06 06:48:26 +00:00

Owner

Metadata

Branch: fix/type-safety/plan-constructor-bench
Commit Message: fix(benchmarks): add missing required arguments to Plan constructor in plan_phase_bench
Milestone: Backlog
Parent Epic: #2810

Background and Context

Pyright has detected that the Plan constructor in benchmarks/plan_phase_bench.py is called without the required arguments: definition_of_done, strategy_actor, execution_actor, created_by, reusable, and read_only. This violates the type contract of the Plan class and will cause the nox -e typecheck CI job to fail.

Current Behavior

The Plan constructor is called with missing arguments, resulting in a Pyright reportCallIssue type error:

# benchmarks/plan_phase_bench.py:24
    return Plan(
        identity=PlanIdentity(plan_id="01ARZ3NDEKTSV4RRFFQ69G5FAV"),
        namespaced_name=NamespacedName(server=None, namespace="local", name="bench"),
        description="Benchmark plan",
        action_name="local/bench-action",
        phase=phase,
        processing_state=processing_state,
    )

Pyright Error:

error: Arguments missing for parameters "definition_of_done", "strategy_actor", "execution_actor", "created_by", "reusable", "read_only" (reportCallIssue)

Expected Behavior

The Plan constructor should be called with all required arguments. Default or mock-appropriate values should be used for the benchmark context.

Subtasks

Inspect the Plan class constructor signature to identify all required parameters and their types
Provide appropriate benchmark-context values for definition_of_done, strategy_actor, execution_actor, created_by, reusable, and read_only in the _make_plan function
Run nox -e typecheck locally to confirm the error is resolved
Run nox -e unit_tests to confirm no regressions

Definition of Done

benchmarks/plan_phase_bench.py _make_plan function calls Plan constructor with all required arguments
nox -e typecheck passes with zero errors related to this file
All nox stages pass
Coverage >= 97%

Backlog note: This issue was discovered during autonomous operation
on milestone v3.7.0. It does not block milestone completion and has been
placed in the backlog for human review and future milestone assignment.

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: ca-new-issue-creator

## Metadata - **Branch**: `fix/type-safety/plan-constructor-bench` - **Commit Message**: `fix(benchmarks): add missing required arguments to Plan constructor in plan_phase_bench` - **Milestone**: Backlog - **Parent Epic**: #2810 ## Background and Context Pyright has detected that the `Plan` constructor in `benchmarks/plan_phase_bench.py` is called without the required arguments: `definition_of_done`, `strategy_actor`, `execution_actor`, `created_by`, `reusable`, and `read_only`. This violates the type contract of the `Plan` class and will cause the `nox -e typecheck` CI job to fail. ## Current Behavior The `Plan` constructor is called with missing arguments, resulting in a Pyright `reportCallIssue` type error: ```python # benchmarks/plan_phase_bench.py:24 return Plan( identity=PlanIdentity(plan_id="01ARZ3NDEKTSV4RRFFQ69G5FAV"), namespaced_name=NamespacedName(server=None, namespace="local", name="bench"), description="Benchmark plan", action_name="local/bench-action", phase=phase, processing_state=processing_state, ) ``` **Pyright Error:** ``` error: Arguments missing for parameters "definition_of_done", "strategy_actor", "execution_actor", "created_by", "reusable", "read_only" (reportCallIssue) ``` ## Expected Behavior The `Plan` constructor should be called with all required arguments. Default or mock-appropriate values should be used for the benchmark context. ## Subtasks - [ ] Inspect the `Plan` class constructor signature to identify all required parameters and their types - [ ] Provide appropriate benchmark-context values for `definition_of_done`, `strategy_actor`, `execution_actor`, `created_by`, `reusable`, and `read_only` in the `_make_plan` function - [ ] Run `nox -e typecheck` locally to confirm the error is resolved - [ ] Run `nox -e unit_tests` to confirm no regressions ## Definition of Done - [ ] `benchmarks/plan_phase_bench.py` `_make_plan` function calls `Plan` constructor with all required arguments - [ ] `nox -e typecheck` passes with zero errors related to this file - [ ] All nox stages pass - [ ] Coverage >= 97% > **Backlog note:** This issue was discovered during autonomous operation > on milestone v3.7.0. It does not block milestone completion and has been > placed in the backlog for human review and future milestone assignment. --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: ca-new-issue-creator

freemo added a new dependency

2026-04-06 06:48:39 +00:00

#2810 Epic: CI Quality Gates Restoration — Restore All 11 CI Jobs to Passing on Master

freemo referenced this issue

2026-04-06 06:49:00 +00:00

[Automated] CleverAgents Build Session - 2026-04-06 #3775

freemo added the

Points

label

2026-04-06 06:50:01 +00:00