BUG-HUNT: [type-safety] Missing 'timeout' argument in SkillInlineTool constructor in skill_flatten_bench.py #3811

New issue

Open

opened 2026-04-06 06:32:29 +00:00 by freemo · 0 comments

freemo commented

2026-04-06 06:32:29 +00:00

Owner

Metadata

Branch: fix/benchmarks/skill-flatten-bench-inline-tool-timeout
Commit Message: fix(benchmarks): add missing timeout argument to SkillInlineTool constructor in skill_flatten_bench
Milestone: None (Backlog — see note below)
Parent Epic: #392

Backlog note: This issue was discovered during autonomous operation
on milestone v3.5.0. It does not block milestone completion and has been
placed in the backlog for human review and future milestone assignment.

Bug Report: [type-safety] — Missing 'timeout' argument in SkillInlineTool constructor in skill_flatten_bench.py

Severity Assessment

Impact: Medium. This violates the type contract of the SkillInlineTool class, which could lead to unexpected behavior or runtime errors.
Likelihood: High. The code as written will always trigger this type error.
Priority: Medium

Location

File: benchmarks/skill_flatten_bench.py
Function/Class: ComputeSummarySuite.setup
Lines: 132-138

Description

Pyright has detected that the timeout argument is missing in the SkillInlineTool constructor call within the setup method of the ComputeSummarySuite class. The SkillInlineTool class requires a timeout argument to be provided.

Evidence

# benchmarks/skill_flatten_bench.py:132-138
            inlines.append(
                SkillInlineTool(
                    description=f"Tool {i}",
                    source=ToolSource.CUSTOM,
                    code=f"return {i}",
                    capability=cap,
                )
            )

Pyright Error:

error: Argument missing for parameter "timeout" (reportCallIssue)

Expected Behavior

The SkillInlineTool constructor should be called with all required arguments, including timeout.

Actual Behavior

The timeout argument is missing, resulting in a type error.

Suggested Fix

Provide a value for the timeout argument in the SkillInlineTool constructor call. A default value appropriate for the benchmark context can be used.

Subtasks

Inspect SkillInlineTool class definition to confirm timeout field requirements and default value
Add timeout argument to the SkillInlineTool constructor call in ComputeSummarySuite.setup in benchmarks/skill_flatten_bench.py
Run nox -e typecheck to confirm Pyright error is resolved
Run nox (all default sessions), fix any errors
Verify coverage >= 97% via nox -s coverage_report

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.
All nox stages pass
Coverage >= 97%

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: ca-new-issue-creator

## Metadata - **Branch**: `fix/benchmarks/skill-flatten-bench-inline-tool-timeout` - **Commit Message**: `fix(benchmarks): add missing timeout argument to SkillInlineTool constructor in skill_flatten_bench` - **Milestone**: None (Backlog — see note below) - **Parent Epic**: #392 > **Backlog note:** This issue was discovered during autonomous operation > on milestone v3.5.0. It does not block milestone completion and has been > placed in the backlog for human review and future milestone assignment. ## Bug Report: [type-safety] — Missing 'timeout' argument in SkillInlineTool constructor in skill_flatten_bench.py ### Severity Assessment - **Impact**: Medium. This violates the type contract of the `SkillInlineTool` class, which could lead to unexpected behavior or runtime errors. - **Likelihood**: High. The code as written will always trigger this type error. - **Priority**: Medium ### Location - **File**: `benchmarks/skill_flatten_bench.py` - **Function/Class**: `ComputeSummarySuite.setup` - **Lines**: 132-138 ### Description Pyright has detected that the `timeout` argument is missing in the `SkillInlineTool` constructor call within the `setup` method of the `ComputeSummarySuite` class. The `SkillInlineTool` class requires a `timeout` argument to be provided. ### Evidence ```python # benchmarks/skill_flatten_bench.py:132-138 inlines.append( SkillInlineTool( description=f"Tool {i}", source=ToolSource.CUSTOM, code=f"return {i}", capability=cap, ) ) ``` **Pyright Error:** ``` error: Argument missing for parameter "timeout" (reportCallIssue) ``` ### Expected Behavior The `SkillInlineTool` constructor should be called with all required arguments, including `timeout`. ### Actual Behavior The `timeout` argument is missing, resulting in a type error. ### Suggested Fix Provide a value for the `timeout` argument in the `SkillInlineTool` constructor call. A default value appropriate for the benchmark context can be used. ### Category type-safety ## Subtasks - [ ] Inspect `SkillInlineTool` class definition to confirm `timeout` field requirements and default value - [ ] Add `timeout` argument to the `SkillInlineTool` constructor call in `ComputeSummarySuite.setup` in `benchmarks/skill_flatten_bench.py` - [ ] Run `nox -e typecheck` to confirm Pyright error is resolved - [ ] Run `nox` (all default sessions), fix any errors - [ ] Verify coverage >= 97% via `nox -s coverage_report` ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. - All nox stages pass - Coverage >= 97% --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: ca-new-issue-creator

freemo added a new dependency

2026-04-06 06:32:49 +00:00

#392 Epic: Actor YAML & Compiler

freemo added the

Points

label

2026-04-06 06:35:57 +00:00