[WATCHDOG] Branch protection misconfiguration: required_approvals=0, block_on_rejected_reviews=false #3786

New issue

Open

opened 2026-04-06 06:18:47 +00:00 by freemo · 0 comments

freemo commented

2026-04-06 06:18:47 +00:00

Owner

Problem

The system watchdog detected that the Forgejo branch protection rules for master do not match the requirements specified in CONTRIBUTING.md.

Current Configuration

Setting	Current Value	Required Value
`required_approvals`	0	2
`block_on_rejected_reviews`	false	true
`enable_status_check`	true ✅	true
`apply_to_admins`	true ✅	true
`block_on_outdated_branch`	true ✅	true

Impact

PRs can be merged without any reviews, violating the 2-approval requirement in CONTRIBUTING.md
PRs with outstanding "Request Changes" reviews can still be merged
This undermines the quality gate process

Required Fix

Update the branch protection rules for master to:

Set required_approvals to 2
Set block_on_rejected_reviews to true

Metadata

Commit Message: fix(ci): update branch protection to require 2 approvals and block on rejected reviews
Branch: fix/branch-protection-config

Subtasks

Update Forgejo branch protection settings for master
Verify settings are applied correctly

Definition of Done

required_approvals is set to 2
block_on_rejected_reviews is set to true
Settings verified via API

Automated by CleverAgents Bot
Supervisor: System Watchdog | Agent: ca-system-watchdog

## Problem The system watchdog detected that the Forgejo branch protection rules for `master` do not match the requirements specified in CONTRIBUTING.md. ### Current Configuration | Setting | Current Value | Required Value | |---------|--------------|----------------| | `required_approvals` | **0** | **2** | | `block_on_rejected_reviews` | **false** | **true** | | `enable_status_check` | true ✅ | true | | `apply_to_admins` | true ✅ | true | | `block_on_outdated_branch` | true ✅ | true | ### Impact - PRs can be merged without **any** reviews, violating the 2-approval requirement in CONTRIBUTING.md - PRs with outstanding "Request Changes" reviews can still be merged - This undermines the quality gate process ### Required Fix Update the branch protection rules for `master` to: 1. Set `required_approvals` to `2` 2. Set `block_on_rejected_reviews` to `true` ### Metadata - **Commit Message:** `fix(ci): update branch protection to require 2 approvals and block on rejected reviews` - **Branch:** `fix/branch-protection-config` ### Subtasks - [ ] Update Forgejo branch protection settings for master - [ ] Verify settings are applied correctly ### Definition of Done - [ ] `required_approvals` is set to 2 - [ ] `block_on_rejected_reviews` is set to true - [ ] Settings verified via API --- **Automated by CleverAgents Bot** Supervisor: System Watchdog | Agent: ca-system-watchdog

Rows
Columns