UAT: `_resource_registry_cloud.py` exceeds 500-line CONTRIBUTING limit at 761 lines — no tracking issue exists #3706

New issue

Open

opened 2026-04-05 22:15:26 +00:00 by freemo · 0 comments

freemo commented

2026-04-05 22:15:26 +00:00

Owner

Bug Report

What Was Tested

src/cleveragents/application/services/_resource_registry_cloud.py was analyzed for compliance with the CONTRIBUTING.md 500-line module limit.

Expected Behavior (from CONTRIBUTING)

CONTRIBUTING.md specifies a maximum of 500 lines per module. Files exceeding this limit must be split into smaller modules.

Actual Behavior (from code analysis)

_resource_registry_cloud.py is 761 lines — 52% over the 500-line limit. The file itself acknowledges this in its docstring:

"""Cloud resource type definitions for the Resource Registry.
...
.. note::

    This module is 754 lines, exceeding the 500-line CONTRIBUTING
    guideline.  The overage is accepted because splitting the 36 AWS
    type definitions mid-file would break the ``_aws_type()`` helper
    pattern.  A follow-up extraction to ``_resource_registry_cloud_aws``
    is tracked but not blocking.
"""

However, no tracking issue exists for the follow-up extraction to _resource_registry_cloud_aws.

Impact

Violates CONTRIBUTING.md module size limit
The file contains 36 AWS type definitions plus GCP/Azure placeholders that could be split
The _aws_type() helper pattern could be moved to a shared module

Code Locations

src/cleveragents/application/services/_resource_registry_cloud.py (761 lines)

Suggested Fix

Extract AWS types to _resource_registry_cloud_aws.py and GCP/Azure types to _resource_registry_cloud_gcp_azure.py, keeping only the base types and helper functions in _resource_registry_cloud.py.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-uat-tester

## Bug Report ### What Was Tested `src/cleveragents/application/services/_resource_registry_cloud.py` was analyzed for compliance with the CONTRIBUTING.md 500-line module limit. ### Expected Behavior (from CONTRIBUTING) CONTRIBUTING.md specifies a maximum of 500 lines per module. Files exceeding this limit must be split into smaller modules. ### Actual Behavior (from code analysis) `_resource_registry_cloud.py` is **761 lines** — 52% over the 500-line limit. The file itself acknowledges this in its docstring: ```python """Cloud resource type definitions for the Resource Registry. ... .. note:: This module is 754 lines, exceeding the 500-line CONTRIBUTING guideline. The overage is accepted because splitting the 36 AWS type definitions mid-file would break the ``_aws_type()`` helper pattern. A follow-up extraction to ``_resource_registry_cloud_aws`` is tracked but not blocking. """ ``` However, no tracking issue exists for the follow-up extraction to `_resource_registry_cloud_aws`. ### Impact - Violates CONTRIBUTING.md module size limit - The file contains 36 AWS type definitions plus GCP/Azure placeholders that could be split - The `_aws_type()` helper pattern could be moved to a shared module ### Code Locations - `src/cleveragents/application/services/_resource_registry_cloud.py` (761 lines) ### Suggested Fix Extract AWS types to `_resource_registry_cloud_aws.py` and GCP/Azure types to `_resource_registry_cloud_gcp_azure.py`, keeping only the base types and helper functions in `_resource_registry_cloud.py`. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-uat-tester

Rows
Columns

UAT: _resource_registry_cloud.py exceeds 500-line CONTRIBUTING limit at 761 lines — no tracking issue exists #3706