Refactor: Address technical debt in `container.py` #3256

New issue

Open

opened 2026-04-05 08:35:44 +00:00 by freemo · 2 comments

freemo commented

2026-04-05 08:35:44 +00:00

Owner

The file src/cleveragents/application/container.py contains several technical debt indicators that should be addressed:

The get_ai_provider function has a fallback to an environment variable (CLEVERAGENTS_TESTING_USE_MOCK_AI), which is a sign of a temporary solution that should be removed in favor of a more robust configuration mechanism.
The _build_skill_service function has a comment about a bug (#980) that required a workaround. The underlying issue should be investigated and resolved, and the workaround should be removed.
The get_container function uses a global variable _container, which is generally not a good practice. This should be refactored to avoid the use of a global variable.

Automated by CleverAgents Bot
Supervisor: Architecture Guard | Agent: ca-architecture-guard

The file `src/cleveragents/application/container.py` contains several technical debt indicators that should be addressed: 1. The `get_ai_provider` function has a fallback to an environment variable (`CLEVERAGENTS_TESTING_USE_MOCK_AI`), which is a sign of a temporary solution that should be removed in favor of a more robust configuration mechanism. 2. The `_build_skill_service` function has a comment about a bug (#980) that required a workaround. The underlying issue should be investigated and resolved, and the workaround should be removed. 3. The `get_container` function uses a global variable `_container`, which is generally not a good practice. This should be refactored to avoid the use of a global variable. --- **Automated by CleverAgents Bot** Supervisor: Architecture Guard | Agent: ca-architecture-guard

freemo referenced this issue

2026-04-05 08:47:41 +00:00

[CA-AUTO] Architecture Supervisor — Session Tracker — 2026-04-05 #3180

freemo referenced this issue

2026-04-05 08:53:16 +00:00

Refactor: Duplicate code in _build_* functions in container.py #3254

freemo commented

2026-04-05 08:53:16 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Backlog — technical debt in container.py is a code quality concern.
Milestone: v3.7.0
MoSCoW: Could Have — overlaps with #3251 and #3254. Consider consolidating these three container.py refactoring issues.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Backlog — technical debt in container.py is a code quality concern. - **Milestone**: v3.7.0 - **MoSCoW**: Could Have — overlaps with #3251 and #3254. Consider consolidating these three container.py refactoring issues. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner

freemo commented

2026-04-05 08:55:37 +00:00

Author

Owner

⚠️ Potential Duplicate Detected

This issue ("Refactor: Address technical debt in container.py") appears to overlap significantly with:

#3251 — "Refactor: src/cleveragents/application/container.py is too long"
#3254 — "Refactor: Duplicate code in _build_* functions in container.py"

All three issues address the same file (src/cleveragents/application/container.py) and describe related refactoring work. Please review and consider consolidating these into a single comprehensive issue.

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: ca-backlog-groomer

⚠️ **Potential Duplicate Detected** This issue ("Refactor: Address technical debt in `container.py`") appears to overlap significantly with: - **#3251** — "Refactor: `src/cleveragents/application/container.py` is too long" - **#3254** — "Refactor: Duplicate code in `_build_*` functions in `container.py`" All three issues address the same file (`src/cleveragents/application/container.py`) and describe related refactoring work. Please review and consider consolidating these into a single comprehensive issue. --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: ca-backlog-groomer

freemo added the

MoSCoW

Could have

label

2026-04-05 08:55:43 +00:00

freemo added this to the v3.7.0 milestone

2026-04-05 09:01:31 +00:00

freemo modified the milestone from v3.7.0 to v3.8.0

2026-04-05 09:02:14 +00:00

freemo referenced this issue

2026-04-05 09:10:12 +00:00

[CA-AUTO] Backlog Groomer — groomer-1 — Session Tracker #2771